From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jordan.l.justen@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Sun, 28 Apr 2019 21:53:40 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2019 21:53:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,408,1549958400"; 
   d="scan'208";a="146566177"
Received: from vtcao-mobl1.amr.corp.intel.com (HELO localhost) ([10.251.149.211])
  by orsmga003.jf.intel.com with ESMTP; 28 Apr 2019 21:53:39 -0700
MIME-Version: 1.0
In-Reply-To: <20190429030425.20556-1-zhiguang.liu@intel.com>
References: <20190429030425.20556-1-zhiguang.liu@intel.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Add the second console to Emulator
To: Zhiguang Liu <zhiguang.liu@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>
Message-ID: <155651361916.18471.16527159378922602650@jljusten-skl>
User-Agent: alot/0.8
Date: Sun, 28 Apr 2019 21:53:39 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

What do you think about this change to the commit message?

EmulatorPkg: Support a second GOP window

Two GOP screens will be created if PcdEmuGop is set in
EmulatorPkg.dsc:

gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window 2"

On 2019-04-28 20:04:25, Zhiguang Liu wrote:
> @@ -51,6 +83,10 @@ BDS_CONSOLE_CONNECT_ENTRY   gPlatformConsole[] =3D {
>      (CONSOLE_OUT | CONSOLE_IN)
>    },
>    {
> +(EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2,
> +    (CONSOLE_OUT | CONSOLE_IN)
> +  },
> +    {

The indentation looks wrong on these lines.

With these fixes:
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>      NULL,
>      0
>    }