Re: [Patch V3] EmulatorPkg: Support a second GOP window

["Jordan Justen" <jordan.l.justen@intel.com>]

On 2019-04-28 23:12:35, Zhiguang Liu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1687
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> 
> IN V3: change the title
> 
> IN V2: change the indentation
> 


> Two GOP screens will be created if PcdEmuGop is set in
> EmulatorPkg.dsc:
> 
> gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window 2"

I prefer if this ^^ text goes at the start of the commit message, just
after the subject line. I think this information is more important to
be placed near the top since if it important when browsing the repo
log.

I guess this wiki page has added the REF near the top:

https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Personally, I think Ref should be added near the end, by the
Signed-off-by, Cc, Reviewed-by tags, but at least the wiki order is
closer. (I think the Ref, Signed-off-by, etc are part of 'tags' block
that should all go at the end of the commit message.)

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c b/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c
> index 633a97d14a..1151021606 100644
> --- a/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c
> +++ b/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c
> @@ -42,6 +42,38 @@ EMU_PLATFORM_UGA_DEVICE_PATH gGopDevicePath = {
>    gEndEntire
>  };
>  
> +EMU_PLATFORM_UGA_DEVICE_PATH gGopDevicePath2 = {
> +  {
> +    {
> +      {
> +        HARDWARE_DEVICE_PATH,
> +        HW_VENDOR_DP,
> +        {
> +          (UINT8) (sizeof (EMU_VENDOR_DEVICE_PATH_NODE)),
> +          (UINT8) ((sizeof (EMU_VENDOR_DEVICE_PATH_NODE)) >> 8)
> +        }
> +      },
> +      EMU_THUNK_PROTOCOL_GUID
> +    },
> +    0
> +  },
> +  {
> +    {
> +      {
> +        HARDWARE_DEVICE_PATH,
> +        HW_VENDOR_DP,
> +        {
> +          (UINT8) (sizeof (EMU_VENDOR_DEVICE_PATH_NODE)),
> +          (UINT8) ((sizeof (EMU_VENDOR_DEVICE_PATH_NODE)) >> 8)
> +        },
> +      },
> +      EMU_GRAPHICS_WINDOW_PROTOCOL_GUID,
> +    },
> +    1
> +  },
> +  gEndEntire
> +};
> +
>  //
>  // Predefined platform default console device path
>  //
> @@ -50,6 +82,10 @@ BDS_CONSOLE_CONNECT_ENTRY   gPlatformConsole[] = {
>      (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath,
>      (CONSOLE_OUT | CONSOLE_IN)
>    },
> +  {
> +    (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2,
> +    (CONSOLE_OUT | CONSOLE_IN)
> +  },
>    {
>      NULL,
>      0
> -- 
> 2.21.0.windows.1
>