From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jordan.l.justen@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Sun, 28 Apr 2019 23:48:07 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2019 23:48:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,408,1549958400"; 
   d="scan'208";a="341713238"
Received: from vtcao-mobl1.amr.corp.intel.com (HELO localhost) ([10.251.149.211])
  by fmsmga006.fm.intel.com with ESMTP; 28 Apr 2019 23:48:06 -0700
MIME-Version: 1.0
In-Reply-To: <20190429061235.10896-1-zhiguang.liu@intel.com>
References: <20190429061235.10896-1-zhiguang.liu@intel.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Zhiguang Liu <zhiguang.liu@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [Patch V3] EmulatorPkg: Support a second GOP window
Message-ID: <155652048615.20712.2816410110352110411@jljusten-skl>
User-Agent: alot/0.8
Date: Sun, 28 Apr 2019 23:48:06 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-04-28 23:12:35, Zhiguang Liu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1687
>=20
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
>=20
> IN V3: change the title
>=20
> IN V2: change the indentation
>=20


> Two GOP screens will be created if PcdEmuGop is set in
> EmulatorPkg.dsc:
>=20
> gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window 2"

I prefer if this ^^ text goes at the start of the commit message, just
after the subject line. I think this information is more important to
be placed near the top since if it important when browsing the repo
log.

I guess this wiki page has added the REF near the top:

https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

Personally, I think Ref should be added near the end, by the
Signed-off-by, Cc, Reviewed-by tags, but at least the wiki order is
closer. (I think the Ref, Signed-off-by, etc are part of 'tags' block
that should all go at the end of the commit message.)

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c | 36 ++++++++++++++++=
++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>=20
> diff --git a/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c b/Emulato=
rPkg/Library/PlatformBmLib/PlatformBmData.c
> index 633a97d14a..1151021606 100644
> --- a/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c
> +++ b/EmulatorPkg/Library/PlatformBmLib/PlatformBmData.c
> @@ -42,6 +42,38 @@ EMU_PLATFORM_UGA_DEVICE_PATH gGopDevicePath =3D {
>    gEndEntire
>  };
> =20
> +EMU_PLATFORM_UGA_DEVICE_PATH gGopDevicePath2 =3D {
> +  {
> +    {
> +      {
> +        HARDWARE_DEVICE_PATH,
> +        HW_VENDOR_DP,
> +        {
> +          (UINT8) (sizeof (EMU_VENDOR_DEVICE_PATH_NODE)),
> +          (UINT8) ((sizeof (EMU_VENDOR_DEVICE_PATH_NODE)) >> 8)
> +        }
> +      },
> +      EMU_THUNK_PROTOCOL_GUID
> +    },
> +    0
> +  },
> +  {
> +    {
> +      {
> +        HARDWARE_DEVICE_PATH,
> +        HW_VENDOR_DP,
> +        {
> +          (UINT8) (sizeof (EMU_VENDOR_DEVICE_PATH_NODE)),
> +          (UINT8) ((sizeof (EMU_VENDOR_DEVICE_PATH_NODE)) >> 8)
> +        },
> +      },
> +      EMU_GRAPHICS_WINDOW_PROTOCOL_GUID,
> +    },
> +    1
> +  },
> +  gEndEntire
> +};
> +
>  //
>  // Predefined platform default console device path
>  //
> @@ -50,6 +82,10 @@ BDS_CONSOLE_CONNECT_ENTRY   gPlatformConsole[] =3D {
>      (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath,
>      (CONSOLE_OUT | CONSOLE_IN)
>    },
> +  {
> +    (EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2,
> +    (CONSOLE_OUT | CONSOLE_IN)
> +  },
>    {
>      NULL,
>      0
> --=20
> 2.21.0.windows.1
>=20