From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
To: devel@edk2.groups.io, thloh85@gmail.com
Cc: "Tien Hock, Loh" <tien.hock.loh@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [[PATCH v2] 1/7] EmbeddedPkg: Fix DwEmmc driver bugs
Date: Fri, 3 May 2019 11:26:57 +0800 [thread overview]
Message-ID: <1556854023-5486-2-git-send-email-tien.hock.loh@intel.com> (raw)
In-Reply-To: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com>
From: "Tien Hock, Loh" <tien.hock.loh@intel.com>
Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command
should be an application command, which should not expect data
Signed-off-by: "Tien Hock, Loh" <tien.hock.loh@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
index adc6b06..fa24802 100644
--- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
+++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
@@ -39,6 +39,7 @@ DWEMMC_IDMAC_DESCRIPTOR *gpIdmacDesc;
EFI_GUID mDwEmmcDevicePathGuid = EFI_CALLER_ID_GUID;
STATIC UINT32 mDwEmmcCommand;
STATIC UINT32 mDwEmmcArgument;
+STATIC BOOLEAN mIsACmd = FALSE;
EFI_STATUS
DwEmmcReadBlockData (
@@ -321,6 +322,15 @@ DwEmmcSendCommand (
Cmd = BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC |
BIT_CMD_SEND_INIT;
break;
+ case MMC_INDX(6):
+ if(mIsACmd) {
+ Cmd = BIT_CMD_RESPONSE_EXPECT ;
+ }
+ else {
+ Cmd = BIT_CMD_RESPONSE_EXPECT | BIT_CMD_DATA_EXPECTED |
+ BIT_CMD_READ;
+ }
+ break;
case MMC_INDX(7):
if (Argument)
Cmd = BIT_CMD_RESPONSE_EXPECT | BIT_CMD_CHECK_RESPONSE_CRC;
@@ -371,6 +381,11 @@ DwEmmcSendCommand (
}
Cmd |= MMC_GET_INDX(MmcCmd) | BIT_CMD_USE_HOLD_REG | BIT_CMD_START;
+
+ if(MMC_INDX(55) == MMC_GET_INDX(MmcCmd))
+ mIsACmd = TRUE;
+ else
+ mIsACmd = FALSE;
if (IsPendingReadCommand (Cmd) || IsPendingWriteCommand (Cmd)) {
mDwEmmcCommand = Cmd;
mDwEmmcArgument = Argument;
--
2.2.2
next prev parent reply other threads:[~2019-05-03 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 3:26 [[PATCH v2] 0/7] Fix DwEmmc driver bugs Loh, Tien Hock
2019-05-03 3:26 ` Loh, Tien Hock [this message]
2019-05-03 11:51 ` [[PATCH v2] 1/7] EmbeddedPkg: " Leif Lindholm
2019-05-08 2:39 ` Loh, Tien Hock
2019-05-03 3:26 ` [[PATCH v2] 2/7] " Loh, Tien Hock
2019-05-03 3:26 ` [[PATCH v2] 3/7] " Loh, Tien Hock
2019-05-03 12:06 ` Leif Lindholm
2019-05-03 3:27 ` [[PATCH v2] 4/7] " Loh, Tien Hock
2019-05-03 3:27 ` [[PATCH v2] 5/7] " Loh, Tien Hock
2019-05-03 12:11 ` Leif Lindholm
2019-05-09 3:40 ` Loh, Tien Hock
2019-05-03 3:27 ` [[PATCH v2] 6/7] " Loh, Tien Hock
2019-05-03 3:27 ` [[PATCH v2] 7/7] " Loh, Tien Hock
2019-05-03 12:19 ` Leif Lindholm
2019-05-09 6:54 ` Loh, Tien Hock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556854023-5486-2-git-send-email-tien.hock.loh@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox