From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
To: devel@edk2.groups.io, thloh85@gmail.com
Cc: "Tien Hock, Loh" <tien.hock.loh@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [[PATCH v2] 5/7] EmbeddedPkg: Fix DwEmmc driver bugs
Date: Fri, 3 May 2019 11:27:01 +0800 [thread overview]
Message-ID: <1556854023-5486-6-git-send-email-tien.hock.loh@intel.com> (raw)
In-Reply-To: <1556854023-5486-1-git-send-email-tien.hock.loh@intel.com>
From: "Tien Hock, Loh" <tien.hock.loh@intel.com>
Send command when MMC ask for response in DwEmmcReceiveResponse, and
command is a pending command (eg. DMA needs to be set up first)
Signed-off-by: "Tien Hock, Loh" <tien.hock.loh@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
index 32572a9..a69d9ab 100644
--- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
+++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c
@@ -398,8 +398,11 @@ DwEmmcSendCommand (
mDwEmmcCommand = Cmd;
mDwEmmcArgument = Argument;
} else {
+ mDwEmmcCommand = Cmd;
+ mDwEmmcArgument = Argument;
Status = SendCommand (Cmd, Argument);
}
+
return Status;
}
@@ -410,6 +413,11 @@ DwEmmcReceiveResponse (
IN UINT32* Buffer
)
{
+ EFI_STATUS Status = EFI_SUCCESS;
+
+ if(IsPendingReadCommand (mDwEmmcCommand) || IsPendingWriteCommand(mDwEmmcCommand))
+ Status = SendCommand (mDwEmmcCommand, mDwEmmcArgument);
+
if (Buffer == NULL) {
return EFI_INVALID_PARAMETER;
}
@@ -427,7 +435,7 @@ DwEmmcReceiveResponse (
Buffer[2] = MmioRead32 (DWEMMC_RESP2);
Buffer[3] = MmioRead32 (DWEMMC_RESP3);
}
- return EFI_SUCCESS;
+ return Status;
}
VOID
--
2.2.2
next prev parent reply other threads:[~2019-05-03 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 3:26 [[PATCH v2] 0/7] Fix DwEmmc driver bugs Loh, Tien Hock
2019-05-03 3:26 ` [[PATCH v2] 1/7] EmbeddedPkg: " Loh, Tien Hock
2019-05-03 11:51 ` Leif Lindholm
2019-05-08 2:39 ` Loh, Tien Hock
2019-05-03 3:26 ` [[PATCH v2] 2/7] " Loh, Tien Hock
2019-05-03 3:26 ` [[PATCH v2] 3/7] " Loh, Tien Hock
2019-05-03 12:06 ` Leif Lindholm
2019-05-03 3:27 ` [[PATCH v2] 4/7] " Loh, Tien Hock
2019-05-03 3:27 ` Loh, Tien Hock [this message]
2019-05-03 12:11 ` [[PATCH v2] 5/7] " Leif Lindholm
2019-05-09 3:40 ` Loh, Tien Hock
2019-05-03 3:27 ` [[PATCH v2] 6/7] " Loh, Tien Hock
2019-05-03 3:27 ` [[PATCH v2] 7/7] " Loh, Tien Hock
2019-05-03 12:19 ` Leif Lindholm
2019-05-09 6:54 ` Loh, Tien Hock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556854023-5486-6-git-send-email-tien.hock.loh@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox