From: "Marcin Wojtas" <mw@semihalf.com>
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org,
mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com,
kostap@marvell.com, Jici.Gao@arm.com
Subject: [edk2-platforms: PATCH v2 3/4] Marvell/Drivers: MvPhyDxe: Introduce 88E1112 initialization
Date: Mon, 6 May 2019 04:37:06 +0200 [thread overview]
Message-ID: <1557110227-31466-4-git-send-email-mw@semihalf.com> (raw)
In-Reply-To: <1557110227-31466-1-git-send-email-mw@semihalf.com>
This patch adds 88E1112 PHY support and updates PortingGuide
accordingly.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h | 17 ++++++++++-
Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 31 ++++++++++++++++++++
Silicon/Marvell/Documentation/PortingGuide.txt | 7 +++--
3 files changed, 51 insertions(+), 4 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h
index 66974bb..cd5a475 100644
--- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h
+++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.h
@@ -75,7 +75,8 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#define MIIM_88E1111_HWCFG_FIBER_COPPER_RES 0x2000
typedef enum {
- MV_PHY_DEVICE_1512
+ MV_PHY_DEVICE_1512,
+ MV_PHY_DEVICE_1112
} MV_PHY_DEVICE_ID;
typedef
@@ -97,4 +98,18 @@ MvPhyInit1512 (
IN OUT PHY_DEVICE *PhyDev
);
+/**
+ Initialize Marvell 88E1112 PHY.
+
+ @param[in] MvPhyProtocol Marvell PHY protocol instance.
+ @param[in out] *PhyDevice PHY device structure.
+
+**/
+STATIC
+EFI_STATUS
+MvPhyInit1112 (
+ IN CONST MARVELL_PHY_PROTOCOL *MvPhyProtocol,
+ IN OUT PHY_DEVICE *PhyDevice
+ );
+
#endif
diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
index 63af640..81f9c0f 100644
--- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
+++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
@@ -66,6 +66,7 @@ STATIC UINT8 * CONST PhySmiAddresses = PcdGetPtr (PcdPhySmiAddresses);
STATIC MV_PHY_DEVICE MvPhyDevices[] = {
{ MV_PHY_DEVICE_1512, MvPhyInit1512 },
+ { MV_PHY_DEVICE_1112, MvPhyInit1112 },
{ 0, NULL }
};
@@ -382,6 +383,36 @@ MvPhyInit1512 (
return EFI_SUCCESS;
}
+/**
+ Initialize Marvell 88E1112 PHY.
+
+ @param[in] MvPhyProtocol Marvell PHY protocol instance.
+ @param[in out] *PhyDevice PHY device structure.
+
+**/
+STATIC
+EFI_STATUS
+MvPhyInit1112 (
+ IN CONST MARVELL_PHY_PROTOCOL *MvPhyProtocol,
+ IN OUT PHY_DEVICE *PhyDevice
+ )
+{
+ EFI_STATUS Status;
+
+ MvPhyM88e1111sConfig (PhyDevice);
+
+ if (PcdGetBool (PcdPhyStartupAutoneg)) {
+ Status = MvPhyConfigureAutonegotiation (PhyDevice);
+ if (EFI_ERROR (Status)) {
+ return Status;
+ }
+
+ MvPhyParseStatus (PhyDevice);
+ }
+
+ return EFI_SUCCESS;
+}
+
EFI_STATUS
MvPhyInit (
IN CONST MARVELL_PHY_PROTOCOL *Snp,
diff --git a/Silicon/Marvell/Documentation/PortingGuide.txt b/Silicon/Marvell/Documentation/PortingGuide.txt
index 2603980..9dee5c8 100644
--- a/Silicon/Marvell/Documentation/PortingGuide.txt
+++ b/Silicon/Marvell/Documentation/PortingGuide.txt
@@ -146,7 +146,7 @@ Example
PHY Driver configuration
========================
MvPhyDxe provides basic initialization and status routines for Marvell PHYs.
-Currently only 1518 series PHYs are supported. Following PCDs are required:
+Currently only 1512 and 1112 series PHYs are supported. Following PCDs are required:
- gMarvellTokenSpaceGuid.PcdPhyStartupAutoneg
(boolean - if true, driver waits for autonegotiation on startup)
@@ -162,6 +162,7 @@ MV_PHY_DEVICE_ID:
typedef enum {
0 MV_PHY_DEVICE_1512,
+ 1 MV_PHY_DEVICE_1112,
} MV_PHY_DEVICE_ID;
It should be extended when adding support for other PHY models.
@@ -170,9 +171,9 @@ Disable autonegotiation:
gMarvellTokenSpaceGuid.PcdPhyStartupAutoneg|FALSE
-assuming, that PHY models are 1512:
+assuming, that PHY models are 1512 and 1112 for two consecutive ports:
- gMarvellTokenSpaceGuid.PcdPhyDeviceIds|{ 0x0, 0x0 }
+ gMarvellTokenSpaceGuid.PcdPhyDeviceIds|{ 0x0, 0x1 }
MDIO configuration
--
2.7.4
next prev parent reply other threads:[~2019-05-06 2:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 2:37 [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements Marcin Wojtas
2019-05-06 2:37 ` [edk2-platforms: PATCH v2 1/4] Marvel/Drivers: Pp2Dxe: Basic support for Adapter Information Protocol Marcin Wojtas
2019-05-06 2:37 ` [edk2-platforms: PATCH v2 2/4] Marvell/Drivers: MvPhyDxe: Refactor 88E1510 initialization Marcin Wojtas
2019-05-06 2:37 ` Marcin Wojtas [this message]
2019-05-06 2:37 ` [edk2-platforms: PATCH v2 4/4] Marvell/Drivers: MvPhyDxe: Reset PHY only once Marcin Wojtas
2019-05-08 17:52 ` [edk2-platforms: PATCH v2 0/4] Armada 7k8k network improvements Leif Lindholm
2019-05-08 23:26 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557110227-31466-4-git-send-email-mw@semihalf.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox