* [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error
@ 2019-05-08 23:24 Marcin Wojtas
2019-05-09 12:35 ` Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Wojtas @ 2019-05-08 23:24 UTC (permalink / raw)
To: devel; +Cc: leif.lindholm, ard.biesheuvel, mw, jsd, jaz, kostap, Jici.Gao
Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode)
introduced a compilation error, visible with certain toolchains.
Fix that.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
index b4fd29c..62f9e57 100644
--- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
+++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
@@ -1003,7 +1003,6 @@ MvFvbConfigureFlashInstance (
)
{
EFI_STATUS Status;
- UINTN *NumBytes;
UINTN DataOffset;
UINTN VariableSize, FtwWorkingSize, FtwSpareSize, MemorySize;
@@ -1080,10 +1079,9 @@ MvFvbConfigureFlashInstance (
DataOffset = GET_DATA_OFFSET (FlashInstance->FvbOffset,
FlashInstance->StartLba,
FlashInstance->Media.BlockSize);
- *NumBytes = FlashInstance->FvbSize;
Status = FlashInstance->SpiFlashProtocol->Read (&FlashInstance->SpiDevice,
DataOffset,
- *NumBytes,
+ FlashInstance->FvbSize,
(VOID *)FlashInstance->RegionBaseAddress);
if (EFI_ERROR (Status)) {
goto ErrorFreeAllocatedPages;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error
2019-05-08 23:24 [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error Marcin Wojtas
@ 2019-05-09 12:35 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2019-05-09 12:35 UTC (permalink / raw)
To: Marcin Wojtas; +Cc: devel, ard.biesheuvel, jsd, jaz, kostap, Jici.Gao
On Thu, May 09, 2019 at 01:24:21AM +0200, Marcin Wojtas wrote:
> Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode)
> introduced a compilation error, visible with certain toolchains.
> Fix that.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e284bb9226.
Thanks for quick turnaround.
> ---
> Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> index b4fd29c..62f9e57 100644
> --- a/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> +++ b/Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c
> @@ -1003,7 +1003,6 @@ MvFvbConfigureFlashInstance (
> )
> {
> EFI_STATUS Status;
> - UINTN *NumBytes;
> UINTN DataOffset;
> UINTN VariableSize, FtwWorkingSize, FtwSpareSize, MemorySize;
>
> @@ -1080,10 +1079,9 @@ MvFvbConfigureFlashInstance (
> DataOffset = GET_DATA_OFFSET (FlashInstance->FvbOffset,
> FlashInstance->StartLba,
> FlashInstance->Media.BlockSize);
> - *NumBytes = FlashInstance->FvbSize;
> Status = FlashInstance->SpiFlashProtocol->Read (&FlashInstance->SpiDevice,
> DataOffset,
> - *NumBytes,
> + FlashInstance->FvbSize,
> (VOID *)FlashInstance->RegionBaseAddress);
> if (EFI_ERROR (Status)) {
> goto ErrorFreeAllocatedPages;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-09 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-08 23:24 [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error Marcin Wojtas
2019-05-09 12:35 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox