From: "Marcin Wojtas" <mw@semihalf.com>
To: devel@edk2.groups.io
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org,
mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com,
kostap@marvell.com, Jici.Gao@arm.com, rebecca@bluestop.org,
kettenis@jive.eu
Subject: [edk2-platforms: PATCH v2 00/14] Armada7k8k PCIE support
Date: Mon, 20 May 2019 17:27:13 +0200 [thread overview]
Message-ID: <1558366047-15994-1-git-send-email-mw@semihalf.com> (raw)
Hi,
Thank you for thorough review of v1. I submit second
version of the Armada7k8k PCIE support. I addressed
all comments. There is no functional change to initial
patchset, but mostly clean-up and improvements - please
refer to the changelog below.
The patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/pcie-upstream-r20190520
I'm looking forward to your comments or remarks.
Best regards,
Marcin
Changelog:
v1->v2:
*All
- s/PcieBaseAddress/PcieDbiAdress/
*2/14
- fix alignment in comment
* 3/14
- add CONST** to library callback
* 4/14
- add missing reset GPIO to McBin description
* 5/15
- add CONST** to protocol callback
* 6/14
- cleanup all casting in file
- use MAX_UINTx macros
- add Linaro copyright
- use MmioWrite8 instead of volatile in PciExpressReadBuffer
- correct commient in IgnoreBusDeviceFunction ()
- fix typo in commit message
* 7/10
- correct line endings
- use temporary variable for memory description in PciHostBridgeResourceConflict
- use MAX_UINTx macros
- add comments around stalls and MemoryFence in GPIO reset
- keep the reset active for 150ms
- assign translation values instead of asserting
*8/14
- assign gArmTokenSpaceGuid.PcdPciIoTranslation value in .dsc
* 9-11/14
- correct line endings
- remove unused methods
- extend commit messages with 32k shift description
Ard Biesheuvel (1):
Marvell/Armada7k8k: Add PciExpressLib implementation
Marcin Wojtas (13):
Marvell/Library: MvGpioLib: Extend GPIO pin description
Marvell/Library: ArmadaSoCDescLib: Add PCIE information
Marvell/Library: ArmadaBoardDescLib: Add PCIE information
Marvell/Armada7k8k: Extend board description libraries with PCIE
Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support
Marvell/Armada7k8k: Implement PciHostBridgeLib
Marvell/Armada7k8k: Enable PCIE support
Marvell/Armada80x0McBin: Enable ACPI PCIE support
Marvell/Armada80x0Db: Enable ACPI PCIE support
Marvell/Armada70x0Db: Enable ACPI PCIE support
Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver
Marvell/Armada7k8k: Remove duplication in .dsc files
Marvell/Armada7k8: Add 'acpiview' shell command to build
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 19 +-
Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 +-
Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 +-
Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 4 +-
Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 5 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf | 1 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf | 1 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 +
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf | 42 +
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf | 52 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h | 26 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h | 26 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h | 26 +
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h | 95 ++
Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 +
Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 46 +
Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 20 +
Silicon/Marvell/Include/Library/MvGpioLib.h | 1 +
Silicon/Marvell/Include/Protocol/BoardDesc.h | 22 +
Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 48 +
Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 4 +
Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 48 +
Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 6 +
Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 54 +
Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 1 +
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c | 1531 ++++++++++++++++++++
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c | 265 ++++
Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c | 345 +++++
Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 44 +
Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 86 ++
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 108 ++
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc | 47 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 108 ++
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc | 47 +
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 108 ++
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc | 47 +
Silicon/Marvell/Armada7k8k/DeviceTree/armada-8040-mcbin.dts | 3 +
37 files changed, 3290 insertions(+), 11 deletions(-)
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c
create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc
create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc
--
2.7.4
next reply other threads:[~2019-05-20 15:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 15:27 Marcin Wojtas [this message]
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 01/14] Marvell/Library: MvGpioLib: Extend GPIO pin description Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 02/14] Marvell/Library: ArmadaSoCDescLib: Add PCIE information Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 03/14] Marvell/Library: ArmadaBoardDescLib: " Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 04/14] Marvell/Armada7k8k: Extend board description libraries with PCIE Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 05/14] Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 06/14] Marvell/Armada7k8k: Add PciExpressLib implementation Marcin Wojtas
2019-05-24 12:50 ` Ard Biesheuvel
2019-05-24 13:03 ` Marcin Wojtas
2019-05-24 13:08 ` Ard Biesheuvel
2019-05-24 14:28 ` Marcin Wojtas
2019-05-24 15:25 ` Ard Biesheuvel
2019-05-24 15:32 ` Leif Lindholm
2019-05-24 15:43 ` Marcin Wojtas
2019-05-24 15:46 ` Ard Biesheuvel
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 07/14] Marvell/Armada7k8k: Implement PciHostBridgeLib Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 08/14] Marvell/Armada7k8k: Enable PCIE support Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 09/14] Marvell/Armada80x0McBin: Enable ACPI " Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 10/14] Marvell/Armada80x0Db: " Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 11/14] Marvell/Armada70x0Db: " Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 12/14] Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 13/14] Marvell/Armada7k8k: Remove duplication in .dsc files Marcin Wojtas
2019-05-20 15:27 ` [edk2-platforms: PATCH v2 14/14] Marvell/Armada7k8: Add 'acpiview' shell command to build Marcin Wojtas
2019-05-23 13:27 ` [edk2-platforms: PATCH v2 00/14] Armada7k8k PCIE support Mark Kettenis
2019-05-23 14:14 ` Leif Lindholm
2019-05-23 18:01 ` kettenis
2019-05-23 18:13 ` Ard Biesheuvel
2019-05-23 20:11 ` Leif Lindholm
2019-05-23 20:24 ` Ard Biesheuvel
2019-05-24 13:08 ` Marcin Wojtas
2019-05-24 13:12 ` Ard Biesheuvel
2019-05-24 13:13 ` Marcin Wojtas
2019-05-24 22:16 ` mark.kettenis
2019-05-25 9:47 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558366047-15994-1-git-send-email-mw@semihalf.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox