From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=LXJM4Sa4; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.208.194, mailfrom: mw@semihalf.com) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by groups.io with SMTP; Mon, 20 May 2019 08:27:51 -0700 Received: by mail-lj1-f194.google.com with SMTP id z5so12863960lji.10 for ; Mon, 20 May 2019 08:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=agibrqR6379MgEXgJUDIL7GtwY//i5cSuX7Hb7ga7Hg=; b=LXJM4Sa498kou13B8ehoaA23ymymJDvQ7KQHpP6ApVHIt+AurJYP5jFPseoVy+kz4u 9OzuYMmDvnCPfjCli98IJ9cqhaQwK1yR+yFtM/8rE7GNgRNeSC84pT/OGKRw3bVgqB46 ZZ9AS+/kIDinpZvjS2vFFHdCN13ATTLVpUrZIbSxnH9bjNOXJr5KpaIhV0EBEQqZ3TdI PRCzT53MEpTYXlE5q5IkP1nV4py92NQhqgqJOXGFeJkko6ynzCv11cvGpaaco41WASr6 toSHrAivlhelc/aCC2sp5aJNJJ40QebWxuFZsaIVJeSLPUHsGnfVOlfeCDAAlgtK0esv MYmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=agibrqR6379MgEXgJUDIL7GtwY//i5cSuX7Hb7ga7Hg=; b=liiBu29Z8j1QD3n958I98zzIY6jl5BdM39Mva7mwz9OKMjJTUtdyFWLTWSXU/iWzpD Pv8+FmgMuTgRsqRdWfcnvDQ59AveDUhayd3T9x32o6q2SLE9S+d9nPl2jvRqv/ozGPSQ 9BDiOcqt1oLrCSQbLzGdN4aXF/EQfda24AV2Dn0SfiFlFppmMHGW4lLKDBK46eH6/b+q UIIPI9JXZD/SVsT2istufJiCoYl6G3FaXeHDoJF1K1gYiJmhtyf7XcB1J6WCaVQXKeQd 6GYCACze++HaJom+YEcepaRIcwELl6IcqlcF8p51V1rsWknkJ+eXJf6MQmvSm4LFYcYE LRoA== X-Gm-Message-State: APjAAAU+ceuwr33SUDRwGsq4ZdEmQ9CpqdBl2T684vqrocOzAj827qmQ 5WCiiyUVasKwfi4qCvRGld20zJVXWmo= X-Google-Smtp-Source: APXvYqwdSEZZ2aI3hmXRRMOP29BSETWVx7QsppBsUXhN8L55WjiuVqSErIWw+f8fX8cMaKEamtdn0w== X-Received: by 2002:a2e:91c6:: with SMTP id u6mr20170657ljg.143.1558366068940; Mon, 20 May 2019 08:27:48 -0700 (PDT) Return-Path: Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id d5sm3906205lji.85.2019.05.20.08.27.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 May 2019 08:27:48 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, Jici.Gao@arm.com, rebecca@bluestop.org, kettenis@jive.eu Subject: [edk2-platforms: PATCH v2 00/14] Armada7k8k PCIE support Date: Mon, 20 May 2019 17:27:13 +0200 Message-Id: <1558366047-15994-1-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 Hi, Thank you for thorough review of v1. I submit second version of the Armada7k8k PCIE support. I addressed all comments. There is no functional change to initial patchset, but mostly clean-up and improvements - please refer to the changelog below. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/pcie-upstream-r20190520 I'm looking forward to your comments or remarks. Best regards, Marcin Changelog: v1->v2: *All - s/PcieBaseAddress/PcieDbiAdress/ *2/14 - fix alignment in comment * 3/14 - add CONST** to library callback * 4/14 - add missing reset GPIO to McBin description * 5/15 - add CONST** to protocol callback * 6/14 - cleanup all casting in file - use MAX_UINTx macros - add Linaro copyright - use MmioWrite8 instead of volatile in PciExpressReadBuffer - correct commient in IgnoreBusDeviceFunction () - fix typo in commit message * 7/10 - correct line endings - use temporary variable for memory description in PciHostBridgeResourceConflict - use MAX_UINTx macros - add comments around stalls and MemoryFence in GPIO reset - keep the reset active for 150ms - assign translation values instead of asserting *8/14 - assign gArmTokenSpaceGuid.PcdPciIoTranslation value in .dsc * 9-11/14 - correct line endings - remove unused methods - extend commit messages with 32k shift description Ard Biesheuvel (1): Marvell/Armada7k8k: Add PciExpressLib implementation Marcin Wojtas (13): Marvell/Library: MvGpioLib: Extend GPIO pin description Marvell/Library: ArmadaSoCDescLib: Add PCIE information Marvell/Library: ArmadaBoardDescLib: Add PCIE information Marvell/Armada7k8k: Extend board description libraries with PCIE Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support Marvell/Armada7k8k: Implement PciHostBridgeLib Marvell/Armada7k8k: Enable PCIE support Marvell/Armada80x0McBin: Enable ACPI PCIE support Marvell/Armada80x0Db: Enable ACPI PCIE support Marvell/Armada70x0Db: Enable ACPI PCIE support Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver Marvell/Armada7k8k: Remove duplication in .dsc files Marvell/Armada7k8: Add 'acpiview' shell command to build Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 19 +- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 +- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 +- Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 4 +- Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 5 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf | 1 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf | 1 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf | 42 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf | 52 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h | 26 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h | 26 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h | 26 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h | 95 ++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 6 + Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 46 + Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 20 + Silicon/Marvell/Include/Library/MvGpioLib.h | 1 + Silicon/Marvell/Include/Protocol/BoardDesc.h | 22 + Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 48 + Platform/Marvell/Armada70x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 4 + Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 48 + Platform/Marvell/Armada80x0Db/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 6 + Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 54 + Platform/SolidRun/Armada80x0McBin/NonDiscoverableInitLib/NonDiscoverableInitLib.c | 1 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c | 1531 ++++++++++++++++++++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c | 265 ++++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c | 345 +++++ Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 44 + Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 86 ++ Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 108 ++ Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc | 47 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 108 ++ Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc | 47 + Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 108 ++ Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc | 47 + Silicon/Marvell/Armada7k8k/DeviceTree/armada-8040-mcbin.dts | 3 + 37 files changed, 3290 insertions(+), 11 deletions(-) create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.inf create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.inf create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Pcie.h create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Pcie.h create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Pcie.h create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.h create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciExpressLib/PciExpressLib.c create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLib.c create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kPciHostBridgeLib/PciHostBridgeLibConstructor.c create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Mcfg.aslc create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Mcfg.aslc create mode 100644 Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Mcfg.aslc -- 2.7.4