public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
@ 2019-06-03 12:33 Xiaoyu Lu
  2019-06-03 14:52 ` [edk2-devel] " Michael D Kinney
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Xiaoyu Lu @ 2019-06-03 12:33 UTC (permalink / raw)
  To: devel; +Cc: Xiaoyu Lu, Jian Wang, Liming Gao, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089

FmpDevicePkg use OpensslLib and when OpenSSL upgrade to 1.1.1b,
TimerLib is required by OpensslLib in CryptoPkg(commit 456dd8b99f,
CryptoPkg: Upgrade OpenSSL to 1.1.1b)

So add TimerLib to DSC file.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
---
 FmpDevicePkg/FmpDevicePkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc
index 3b40bf8e9cdc..c9513135cbd2 100644
--- a/FmpDevicePkg/FmpDevicePkg.dsc
+++ b/FmpDevicePkg/FmpDevicePkg.dsc
@@ -49,6 +49,7 @@ [LibraryClasses]
   CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
   FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLibV1.inf
   FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLibNull.inf
+  TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
 
 [LibraryClasses.ARM, LibraryClasses.AARCH64]
   #
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
  2019-06-03 12:33 [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file Xiaoyu Lu
@ 2019-06-03 14:52 ` Michael D Kinney
  2019-06-03 14:54 ` Liming Gao
       [not found] ` <15A4B80348A1023F.4964@groups.io>
  2 siblings, 0 replies; 4+ messages in thread
From: Michael D Kinney @ 2019-06-03 14:52 UTC (permalink / raw)
  To: devel@edk2.groups.io, Lu, XiaoyuX, Kinney, Michael D
  Cc: Wang, Jian J, Gao, Liming

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of Xiaoyu Lu
> Sent: Monday, June 3, 2019 5:34 AM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add
> TimerLib to DSC file
> 
> REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1089
> 
> FmpDevicePkg use OpensslLib and when OpenSSL upgrade to
> 1.1.1b,
> TimerLib is required by OpensslLib in CryptoPkg(commit
> 456dd8b99f,
> CryptoPkg: Upgrade OpenSSL to 1.1.1b)
> 
> So add TimerLib to DSC file.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> ---
>  FmpDevicePkg/FmpDevicePkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc
> b/FmpDevicePkg/FmpDevicePkg.dsc
> index 3b40bf8e9cdc..c9513135cbd2 100644
> --- a/FmpDevicePkg/FmpDevicePkg.dsc
> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> @@ -49,6 +49,7 @@ [LibraryClasses]
> 
> CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpda
> tePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
> 
> FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHead
> erLibV1/FmpPayloadHeaderLibV1.inf
> 
> FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpD
> eviceLibNull.inf
> +
> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTi
> merLibNullTemplate.inf
> 
>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>    #
> --
> 2.7.4
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
  2019-06-03 12:33 [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file Xiaoyu Lu
  2019-06-03 14:52 ` [edk2-devel] " Michael D Kinney
@ 2019-06-03 14:54 ` Liming Gao
       [not found] ` <15A4B80348A1023F.4964@groups.io>
  2 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-06-03 14:54 UTC (permalink / raw)
  To: devel@edk2.groups.io, Lu, XiaoyuX; +Cc: Wang, Jian J, Kinney, Michael D

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xiaoyu Lu
> Sent: Monday, June 3, 2019 8:34 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
> 
> FmpDevicePkg use OpensslLib and when OpenSSL upgrade to 1.1.1b,
> TimerLib is required by OpensslLib in CryptoPkg(commit 456dd8b99f,
> CryptoPkg: Upgrade OpenSSL to 1.1.1b)
> 
> So add TimerLib to DSC file.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> ---
>  FmpDevicePkg/FmpDevicePkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpDevicePkg.dsc
> index 3b40bf8e9cdc..c9513135cbd2 100644
> --- a/FmpDevicePkg/FmpDevicePkg.dsc
> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> @@ -49,6 +49,7 @@ [LibraryClasses]
>    CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
>    FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHeaderLibV1/FmpPayloadHeaderLibV1.inf
>    FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLibNull.inf
> +  TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
> 
>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>    #
> --
> 2.7.4
> 
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
       [not found] ` <15A4B80348A1023F.4964@groups.io>
@ 2019-06-04  0:12   ` Liming Gao
  0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-06-04  0:12 UTC (permalink / raw)
  To: devel@edk2.groups.io, Gao, Liming, Lu, XiaoyuX
  Cc: Wang, Jian J, Kinney, Michael D

Push @4ff8b6b1d8b74c72fecc7bedb4d791d537eb0310

>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent: Monday, June 03, 2019 10:55 PM
>To: devel@edk2.groups.io; Lu, XiaoyuX <xiaoyux.lu@intel.com>
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC
>file
>
>Reviewed-by: Liming Gao <liming.gao@intel.com>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Xiaoyu Lu
>> Sent: Monday, June 3, 2019 8:34 PM
>> To: devel@edk2.groups.io
>> Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Wang, Jian J
><jian.j.wang@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney,
>Michael D
>> <michael.d.kinney@intel.com>
>> Subject: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089
>>
>> FmpDevicePkg use OpensslLib and when OpenSSL upgrade to 1.1.1b,
>> TimerLib is required by OpensslLib in CryptoPkg(commit 456dd8b99f,
>> CryptoPkg: Upgrade OpenSSL to 1.1.1b)
>>
>> So add TimerLib to DSC file.
>>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Signed-off-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
>> ---
>>  FmpDevicePkg/FmpDevicePkg.dsc | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc
>b/FmpDevicePkg/FmpDevicePkg.dsc
>> index 3b40bf8e9cdc..c9513135cbd2 100644
>> --- a/FmpDevicePkg/FmpDevicePkg.dsc
>> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
>> @@ -49,6 +49,7 @@ [LibraryClasses]
>>
>CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpdatePolicyLibNull/
>CapsuleUpdatePolicyLibNull.inf
>>
>FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHeaderLibV1/Fmp
>PayloadHeaderLibV1.inf
>>
>FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLibNull.in
>f
>> +
>TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTempl
>ate.inf
>>
>>  [LibraryClasses.ARM, LibraryClasses.AARCH64]
>>    #
>> --
>> 2.7.4
>>
>>
>>
>
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-04  0:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-03 12:33 [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file Xiaoyu Lu
2019-06-03 14:52 ` [edk2-devel] " Michael D Kinney
2019-06-03 14:54 ` Liming Gao
     [not found] ` <15A4B80348A1023F.4964@groups.io>
2019-06-04  0:12   ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox