From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jordan.l.justen@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Tue, 11 Jun 2019 00:55:40 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 00:55:39 -0700
X-ExtLoop1: 1
Received: from leewonjo-mobl.amr.corp.intel.com (HELO localhost) ([10.251.129.208])
  by fmsmga004.fm.intel.com with ESMTP; 11 Jun 2019 00:55:39 -0700
MIME-Version: 1.0
In-Reply-To: <20190611073227.25892-1-zhiguang.liu@intel.com>
References: <20190611073227.25892-1-zhiguang.liu@intel.com>
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Subject: Re: [Patch V3] EmulatorPkg: don't display the cpu current speed
To: Zhiguang Liu <zhiguang.liu@intel.com>, devel@edk2.groups.io
Message-ID: <156023973936.769.10717532610496922876@jljusten-skl>
User-Agent: alot/0.8
Date: Tue, 11 Jun 2019 00:55:39 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-06-11 00:32:27, Zhiguang Liu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1686
>=20
> V3: I hope that changing the status of the mCpuSmbiosType4
>     wouldn't affect other features except showing CPU speed.
>         The value is zero in NT32Pkg.
>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  EmulatorPkg/CpuRuntimeDxe/Cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/EmulatorPkg/CpuRuntimeDxe/Cpu.c b/EmulatorPkg/CpuRuntimeDxe/=
Cpu.c
> index 00e93016af..a5e19b4181 100644
> --- a/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> +++ b/EmulatorPkg/CpuRuntimeDxe/Cpu.c
> @@ -104,7 +104,7 @@ SMBIOS_TABLE_TYPE4 mCpuSmbiosType4 =3D {
>    0,                      // ExternalClock;
>    0,                      // MaxSpeed;
>    0,                      // CurrentSpeed;
> -  0x41,                   // Status;
> +  0,                      // Status;

It looks like bit 6 means the process is populated, and bits[2:0]=3D=3D1
means the CPU is enabled.

So, it looks like this change will make SMBIOS indicate the the
processor socket is not populated, and bit2[2:0]=3D=3D0 means that the CPU
status is unknown.

I think the commit message for this patch should have been:

=3D=3D=3D

EmulatorPkg: Change SMBIOS processor to unpopulated

This change updates the SMBIOS processor information to indicate that
the processor is not populated, and that it's status is unknown.

With this change the processor speed will not be shown in setup.

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1686

=3D=3D=3D

But, I'm not sure I agree we should make this change to fix this bug.
I'm not particularly concerned with this bug, but I wonder if perhaps
the MdeModulePkg should just suppress the item if the speed is 0.

Or, alternately, perhaps we can investigate some methods to attempt to
determine the processor speed. I guess for all OS's, it might be
difficult, but we probably could support finding the processor speed
under the most common environments.

-Jordan