From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jordan.l.justen@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Thu, 13 Jun 2019 00:47:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 00:47:05 -0700 X-ExtLoop1: 1 Received: from leewonjo-mobl.amr.corp.intel.com (HELO localhost) ([10.251.129.208]) by fmsmga004.fm.intel.com with ESMTP; 13 Jun 2019 00:47:05 -0700 MIME-Version: 1.0 In-Reply-To: <12C615F56EBD0740AAC515819FA4CD356C1121@shsmsx102.ccr.corp.intel.com> References: <20190611073227.25892-1-zhiguang.liu@intel.com> <156023973936.769.10717532610496922876@jljusten-skl> <12C615F56EBD0740AAC515819FA4CD356C1121@shsmsx102.ccr.corp.intel.com> To: "Liu, Zhiguang" , "devel@edk2.groups.io" Subject: Re: [Patch V3] EmulatorPkg: don't display the cpu current speed Cc: Andrew Fish , "Ni, Ray" From: "Jordan Justen" Message-ID: <156041202486.1843.6030893249902368241@jljusten-skl> User-Agent: alot/0.8 Date: Thu, 13 Jun 2019 00:47:05 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-06-11 22:42:13, Liu, Zhiguang wrote: > Thanks for the comments. > I will change the commit message in the next version. > But I don't think this is a issue worth making a major change. > Given that the change is consistent with NT32, will you agree with this c= hange? Hmm. You are right that NT32 also does this. I don't agree enough to give you a Reviewed-by, but if Andrew or Ray give a Reviewed-by, then I'm ok for us to take the patch. -Jordan