From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: jordan.l.justen@intel.com)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by groups.io with SMTP; Thu, 20 Jun 2019 11:59:29 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
  by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 11:59:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,397,1557212400"; 
   d="scan'208";a="160758987"
Received: from gpturner-mobl4.amr.corp.intel.com (HELO localhost) ([10.252.198.101])
  by fmsmga008.fm.intel.com with ESMTP; 20 Jun 2019 11:59:27 -0700
MIME-Version: 1.0
In-Reply-To: <20190619165720.4452-1-stephano.cetola@linux.intel.com>
References: <20190619165720.4452-1-stephano.cetola@linux.intel.com>
Subject: Re: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5
To: afish@apple.com, Stephano Cetola <stephano.cetola@linux.intel.com>
Cc: ray.ni@intel.com, devel@edk2.groups.io
From: "Jordan Justen" <jordan.l.justen@intel.com>
Message-ID: <156105716729.32171.13356427451170805954@jljusten-skl>
User-Agent: alot/0.8
Date: Thu, 20 Jun 2019 11:59:27 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
>=20
> Also, fix a small typo.
>=20
> This fixes bug 447:
>=20
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D447
>=20
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
>  EmulatorPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
> index 558b65e88b..c5bf0bd655 100755
> --- a/EmulatorPkg/build.sh
> +++ b/EmulatorPkg/build.sh
> @@ -60,9 +60,9 @@ case `uname` in
>          CLANG_VER=3D$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 =
>/dev/null) || true
>          if [[ "$CLANG_VER" =3D=3D *-ccc-host-triple* ]]
>          then
> -        # only older versions of Xcode support -ccc-host-tripe, for newe=
r versions
> +        # only older versions of Xcode support -ccc-host-triple, for new=
er versions

I don't like to include multiple fixes in one patch, but this is a
pretty minor typo.

>          # it is -target
> -          HOST_TOOLS=3DXCODE32
> +          HOST_TOOLS=3DXCODE5

Based on the discussion in the bug, this seems right, so:

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>            TARGET_TOOLS=3DXCODE5
>          else
>            HOST_TOOLS=3DXCODE32
> --=20
> 2.17.1
>=20