public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Stephano Cetola <stephano.cetola@linux.intel.com>, devel@edk2.groups.io
Cc: afish@apple.com, ray.ni@intel.com,
	Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: Re: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5
Date: Sat, 13 Jul 2019 00:58:09 -0700	[thread overview]
Message-ID: <156300468921.5689.14426586658121142702@jljusten-skl> (raw)
In-Reply-To: <20190619165720.4452-1-stephano.cetola@linux.intel.com>

pushed as 55b9bbf40a1cf9788dd6a7b093851076851fc670

On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
> 
> Also, fix a small typo.
> 
> This fixes bug 447:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=447
> 
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
>  EmulatorPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
> index 558b65e88b..c5bf0bd655 100755
> --- a/EmulatorPkg/build.sh
> +++ b/EmulatorPkg/build.sh
> @@ -60,9 +60,9 @@ case `uname` in
>          CLANG_VER=$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 >/dev/null) || true
>          if [[ "$CLANG_VER" == *-ccc-host-triple* ]]
>          then
> -        # only older versions of Xcode support -ccc-host-tripe, for newer versions
> +        # only older versions of Xcode support -ccc-host-triple, for newer versions
>          # it is -target
> -          HOST_TOOLS=XCODE32
> +          HOST_TOOLS=XCODE5
>            TARGET_TOOLS=XCODE5
>          else
>            HOST_TOOLS=XCODE32
> -- 
> 2.17.1
> 

      parent reply	other threads:[~2019-07-13  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 16:57 [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5 Stephano Cetola
2019-06-20 18:59 ` Jordan Justen
2019-07-13  7:58 ` Jordan Justen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156300468921.5689.14426586658121142702@jljusten-skl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox