From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jordan.l.justen@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Sat, 13 Jul 2019 00:58:10 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2019 00:58:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,485,1557212400"; d="scan'208";a="169135483" Received: from abaradwa-mobl.amr.corp.intel.com (HELO localhost) ([10.254.104.4]) by orsmga003.jf.intel.com with ESMTP; 13 Jul 2019 00:58:09 -0700 MIME-Version: 1.0 In-Reply-To: <20190619165720.4452-1-stephano.cetola@linux.intel.com> References: <20190619165720.4452-1-stephano.cetola@linux.intel.com> From: "Jordan Justen" Subject: Re: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5 To: Stephano Cetola , devel@edk2.groups.io Cc: afish@apple.com, ray.ni@intel.com, Stephano Cetola Message-ID: <156300468921.5689.14426586658121142702@jljusten-skl> User-Agent: alot/0.8 Date: Sat, 13 Jul 2019 00:58:09 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable pushed as 55b9bbf40a1cf9788dd6a7b093851076851fc670 On 2019-06-19 09:57:20, Stephano Cetola wrote: > The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such > the HOST_TOOLS should be set to XCODE5. >=20 > Also, fix a small typo. >=20 > This fixes bug 447: >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D447 >=20 > Signed-off-by: Stephano Cetola > --- > EmulatorPkg/build.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh > index 558b65e88b..c5bf0bd655 100755 > --- a/EmulatorPkg/build.sh > +++ b/EmulatorPkg/build.sh > @@ -60,9 +60,9 @@ case `uname` in > CLANG_VER=3D$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 = >/dev/null) || true > if [[ "$CLANG_VER" =3D=3D *-ccc-host-triple* ]] > then > - # only older versions of Xcode support -ccc-host-tripe, for newe= r versions > + # only older versions of Xcode support -ccc-host-triple, for new= er versions > # it is -target > - HOST_TOOLS=3DXCODE32 > + HOST_TOOLS=3DXCODE5 > TARGET_TOOLS=3DXCODE5 > else > HOST_TOOLS=3DXCODE32 > --=20 > 2.17.1 >=20