From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jordan.l.justen@intel.com)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by groups.io with SMTP; Tue, 23 Jul 2019 00:55:57 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 00:47:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,298,1559545200"; 
   d="scan'208";a="197032178"
Received: from dannylex-mobl.amr.corp.intel.com (HELO localhost) ([10.254.50.219])
  by fmsmga002.fm.intel.com with ESMTP; 23 Jul 2019 00:47:57 -0700
MIME-Version: 1.0
In-Reply-To: <20190723003225.46171-1-rebecca@bsdio.com>
References: <20190723003225.46171-1-rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io, rebecca@bsdio.com
From: "Jordan Justen" <jordan.l.justen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Message-ID: <156386807742.18770.2693281149113511817@jljusten-skl>
User-Agent: alot/0.8
Date: Tue, 23 Jul 2019 00:47:57 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Laszlo, want me to add your r-b?

On 2019-07-22 17:32:25,  wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..bacab5e22a 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -40,7 +40,7 @@ ARCH_X64=3Dno
>  BUILDTARGET=3DDEBUG
>  BUILD_OPTIONS=3D
>  PLATFORMFILE=3D
> -THREADNUMBER=3D1
> +THREADNUMBER=3D0
>  LAST_ARG=3D
>  RUN_QEMU=3Dno
>  ENABLE_FLASH=3Dno
> --=20
> 2.22.0
>=20
>=20
>=20
>=20