From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jordan.l.justen@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Tue, 23 Jul 2019 19:40:56 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 19:40:55 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,300,1559545200"; 
   d="scan'208";a="163703171"
Received: from eegbewun-mobl.amr.corp.intel.com (HELO localhost) ([10.252.135.211])
  by orsmga008.jf.intel.com with ESMTP; 23 Jul 2019 19:40:55 -0700
MIME-Version: 1.0
In-Reply-To: <20190724012032.2614-1-rebecca@bsdio.com>
References: <20190724012032.2614-1-rebecca@bsdio.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/build.sh: run qemu _after_ building OvmfPkg
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io, rebecca@bsdio.com
Message-ID: <156393605397.9039.5419810294842622741@jljusten-skl>
User-Agent: alot/0.8
Date: Tue, 23 Jul 2019 19:40:54 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-07-23 18:20:31,  wrote:
> Running qemu before building the firmware image doesn't make much sense.
> Move things so qemu is run after building OvmfPkg.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 1c28e65404..a2c4eff2a5 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -256,6 +256,11 @@ else
>    echo using prebuilt tools
>  fi
> =20
> +#
> +# Build the edk2 OvmfPkg
> +#
> +echo Running edk2 build for OvmfPkg$Processor
> +build -p $PLATFORMFILE $BUILD_OPTIONS -b $BUILDTARGET -t $TARGET_TOOLS -=
n $THREADNUMBER
> =20
>  if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>    if [[ ! -d $QEMU_FIRMWARE_DIR ]]; then
> @@ -275,10 +280,4 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>    exit $?

We exit after running qemu. In other words, if qemu is present on the
command line, then we run qemu, but don't try to build OVMF.

One use case for running qemu multiple times without building is to
preserve non-volatile variables across multiple qemu boots.

-Jordan