From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io, rebecca@bsdio.com
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
Date: Tue, 23 Jul 2019 19:54:58 -0700 [thread overview]
Message-ID: <156393689849.9039.6940197421609488727@jljusten-skl> (raw)
In-Reply-To: <20190724015101.13044-1-rebecca@bsdio.com>
On 2019-07-23 18:51:00, wrote:
> Specify the firmware to use via the newer '-drive if=pflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index a2c4eff2a5..e2890ff762 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
> fi
> ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
> if [[ "$ENABLE_FLASH" == "yes" ]]; then
> - QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> + QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,readonly,file=$QEMU_FIRMWARE_DIR/bios.bin"
It looks like we set ENABLE_FLASH for qemu 1.6 and newer. Does this
work on 1.6?
Also, I don't think we want readonly. Read-write should allow
non-volatile variables to persist across multiple boot.
-Jordan
next prev parent reply other threads:[~2019-07-24 2:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 1:51 [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-24 1:51 ` [PATCH 2/2] OvmfPkg/build.sh: use $QEMU_FIRMWARE_DIR as QEMU fat root rebecca
2019-07-24 3:09 ` Jordan Justen
2019-07-24 21:31 ` rebecca
2019-07-24 2:54 ` Jordan Justen [this message]
2019-07-24 3:08 ` [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-24 12:27 ` Philippe Mathieu-Daudé
2019-07-24 17:26 ` Jordan Justen
2019-07-24 17:39 ` Philippe Mathieu-Daudé
2019-07-24 21:29 ` rebecca
2019-07-24 21:57 ` Jordan Justen
2019-07-25 2:10 ` rebecca
2019-07-24 16:53 ` Michael D Kinney
2019-07-25 15:46 ` rebecca
2019-07-26 0:14 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156393689849.9039.6940197421609488727@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox