From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jordan.l.justen@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Tue, 23 Jul 2019 19:55:00 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 19:54:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,300,1559545200"; 
   d="scan'208";a="369119782"
Received: from eegbewun-mobl.amr.corp.intel.com (HELO localhost) ([10.252.135.211])
  by fmsmga006.fm.intel.com with ESMTP; 23 Jul 2019 19:54:59 -0700
MIME-Version: 1.0
In-Reply-To: <20190724015101.13044-1-rebecca@bsdio.com>
References: <20190724015101.13044-1-rebecca@bsdio.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io, rebecca@bsdio.com
Message-ID: <156393689849.9039.6940197421609488727@jljusten-skl>
User-Agent: alot/0.8
Date: Tue, 23 Jul 2019 19:54:58 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-07-23 18:51:00,  wrote:
> Specify the firmware to use via the newer '-drive if=3Dpflash' syntax
> which allows specifying the raw format and readonly parameters. This
> avoids warnings with newer version of QEMU.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index a2c4eff2a5..e2890ff762 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>    fi
>    ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>    if [[ "$ENABLE_FLASH" =3D=3D "yes" ]]; then
> -    QEMU_COMMAND=3D"$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> +    QEMU_COMMAND=3D"$QEMU_COMMAND -drive if=3Dpflash,format=3Draw,readon=
ly,file=3D$QEMU_FIRMWARE_DIR/bios.bin"

It looks like we set ENABLE_FLASH for qemu 1.6 and newer. Does this
work on 1.6?

Also, I don't think we want readonly. Read-write should allow
non-volatile variables to persist across multiple boot.

-Jordan