public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [PATCH 2/2] OvmfPkg/build.sh: use $QEMU_FIRMWARE_DIR as QEMU fat root
Date: Tue, 23 Jul 2019 20:09:11 -0700	[thread overview]
Message-ID: <156393775131.9039.1656317156824170078@jljusten-skl> (raw)
In-Reply-To: <20190724015101.13044-2-rebecca@bsdio.com>

I'd kind of like to remove the ADD_QEMU_HDA support. I think, way, way
back qemu would not boot if no drives were added, so this kind of
helped. (OVMF can still load the shell with no drives.)

If qemu will still run the firmware without a drive, then maybe maybe
we can just dump ADD_QEMU_HDA.

-Jordan

On 2019-07-23 18:51:01, Rebecca Cran wrote:
> The $BUILD_ROOT_ARCH directory has too many files to
> work as a fat filesystem. QEMU fails with the message:
> 
> Too many entries in root directory
> 
> Use the $QEMU_FIRMWARE_DIR as the root directory instead.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index e2890ff762..b01de0fd55 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -273,7 +273,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
>    if [[ "$ADD_QEMU_HDA" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> +    QEMU_COMMAND="$QEMU_COMMAND -hda fat:$QEMU_FIRMWARE_DIR"
>    fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
> -- 
> 2.22.0
> 

  reply	other threads:[~2019-07-24  3:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  1:51 [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-24  1:51 ` [PATCH 2/2] OvmfPkg/build.sh: use $QEMU_FIRMWARE_DIR as QEMU fat root rebecca
2019-07-24  3:09   ` Jordan Justen [this message]
2019-07-24 21:31     ` rebecca
2019-07-24  2:54 ` [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu Jordan Justen
2019-07-24  3:08   ` rebecca
2019-07-24 12:27   ` Philippe Mathieu-Daudé
2019-07-24 17:26     ` Jordan Justen
2019-07-24 17:39       ` Philippe Mathieu-Daudé
2019-07-24 21:29         ` rebecca
2019-07-24 21:57         ` Jordan Justen
2019-07-25  2:10           ` rebecca
2019-07-24 16:53 ` Michael D Kinney
2019-07-25 15:46   ` rebecca
2019-07-26  0:14 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156393775131.9039.1656317156824170078@jljusten-skl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox