From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jordan.l.justen@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Tue, 23 Jul 2019 20:09:12 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 20:09:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,300,1559545200"; 
   d="scan'208";a="197350490"
Received: from eegbewun-mobl.amr.corp.intel.com (HELO localhost) ([10.252.135.211])
  by fmsmga002.fm.intel.com with ESMTP; 23 Jul 2019 20:09:11 -0700
MIME-Version: 1.0
In-Reply-To: <20190724015101.13044-2-rebecca@bsdio.com>
References: <20190724015101.13044-1-rebecca@bsdio.com> <20190724015101.13044-2-rebecca@bsdio.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Subject: Re: [PATCH 2/2] OvmfPkg/build.sh: use $QEMU_FIRMWARE_DIR as QEMU fat root
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Message-ID: <156393775131.9039.1656317156824170078@jljusten-skl>
User-Agent: alot/0.8
Date: Tue, 23 Jul 2019 20:09:11 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

I'd kind of like to remove the ADD_QEMU_HDA support. I think, way, way
back qemu would not boot if no drives were added, so this kind of
helped. (OVMF can still load the shell with no drives.)

If qemu will still run the firmware without a drive, then maybe maybe
we can just dump ADD_QEMU_HDA.

-Jordan

On 2019-07-23 18:51:01, Rebecca Cran wrote:
> The $BUILD_ROOT_ARCH directory has too many files to
> work as a fat filesystem. QEMU fails with the message:
>=20
> Too many entries in root directory
>=20
> Use the $QEMU_FIRMWARE_DIR as the root directory instead.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index e2890ff762..b01de0fd55 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -273,7 +273,7 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>      QEMU_COMMAND=3D"$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
>    if [[ "$ADD_QEMU_HDA" =3D=3D "yes" ]]; then
> -    QEMU_COMMAND=3D"$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> +    QEMU_COMMAND=3D"$QEMU_COMMAND -hda fat:$QEMU_FIRMWARE_DIR"
>    fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
> --=20
> 2.22.0
>=20