From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jordan.l.justen@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 24 Jul 2019 14:57:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 14:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; d="scan'208";a="181256479" Received: from jpolitsc-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.111.52]) by orsmga002.jf.intel.com with ESMTP; 24 Jul 2019 14:57:21 -0700 MIME-Version: 1.0 In-Reply-To: References: <20190724015101.13044-1-rebecca@bsdio.com> <156393689849.9039.6940197421609488727@jljusten-skl> <8c04a9e0-ac53-0bef-41df-9508b06b09cc@redhat.com> <156398919445.22585.9417541374118966045@jljusten-skl> To: Philippe Mathieu-Daudé , Ard Biesheuvel , Laszlo Ersek , devel@edk2.groups.io, rebecca@bsdio.com Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu From: "Jordan Justen" Message-ID: <156400544049.24070.11026234673983299620@jljusten-skl> User-Agent: alot/0.8 Date: Wed, 24 Jul 2019 14:57:20 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-07-24 10:39:20, Philippe Mathieu-Daud=C3=A9 wrote: > On 7/24/19 7:26 PM, Jordan Justen wrote: > > Hmm, it looks like qemu 2.0 is when the multiple flash device support > > was added: https://wiki.qemu.org/ChangeLog/2.0 > >=20 > > The build.sh script currently attempts to detect 1.6 and newer for > > flash support. pflash first appeared in 1.1, but kvm support was added > > in 1.6. I think it'd be reasonable to alter the script to not use > > flash for qemu < 2.0, to enable using separate code and vars binaries. >=20 > Where can I find the range of QEMU versions used by EDK2? > I'm trying to understand why it is important to still maintain scripts > for a such old version. OvmfPkg/README mentions as far back as qemu 0.10. It seems it was update from 0.9.1 to 0.10 in 2012. (Oh, cool! OVMF just passed 10 years of being released as open source. Since May of 2009! :) I think we've tried to keep the range of versions that it works with as wide as possible, but I think we could (and perhaps should) discuss raising the minimum supported version of qemu. qemu 2.0 is over 5 years old now. qemu 0.10.0 is over 10 years old. One thing that was originally problematic (for raising the qemu requirement) was finding windows builds of newer qemu releases. The main website seems to link to windows builds of the latest releases now: https://www.qemu.org/download/#windows -Jordan