From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Philippe Mathieu-Daudé <philmd@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
devel@edk2.groups.io, rebecca@bsdio.com
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
Date: Wed, 24 Jul 2019 15:04:04 -0700 [thread overview]
Message-ID: <156400584459.24070.2221587253012581445@jljusten-skl> (raw)
In-Reply-To: <c4f23e70-ee47-b576-6b9c-7b2defee3041@redhat.com>
On 2019-07-24 05:21:35, Philippe Mathieu-Daudé wrote:
> On 7/23/19 2:32 AM, rebecca@bsdio.com wrote:
> > Enable multithreaded builds by default when building OvmfPkg
> > using build.sh.
> > This can drastically reduce build times. For example, on a
> > modern ThreadRipper system the time required to build decreases
> > from 3 minutes to 1 minute.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> > OvmfPkg/build.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> > index 4fcbdd2bc9..bacab5e22a 100755
> > --- a/OvmfPkg/build.sh
> > +++ b/OvmfPkg/build.sh
> > @@ -40,7 +40,7 @@ ARCH_X64=no
> > BUILDTARGET=DEBUG
> > BUILD_OPTIONS=
> > PLATFORMFILE=
> > -THREADNUMBER=1
> > +THREADNUMBER=0
> > LAST_ARG=
> > RUN_QEMU=no
> > ENABLE_FLASH=no
> >
>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Whoops. Sorry, I pushed this a few days back, but I forgot to reply to
notify the list.
It's 83e7d5c75e7304aa5172c88eb24fa563445ce043.
-Jordan
prev parent reply other threads:[~2019-07-24 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
2019-07-23 12:13 ` Laszlo Ersek
2019-07-23 9:49 ` Laszlo Ersek
2019-07-24 12:21 ` Philippe Mathieu-Daudé
2019-07-24 22:04 ` Jordan Justen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156400584459.24070.2221587253012581445@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox