From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jordan.l.justen@intel.com)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by groups.io with SMTP; Wed, 24 Jul 2019 15:04:07 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
  by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 15:04:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; 
   d="scan'208";a="189184388"
Received: from jpolitsc-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.111.52])
  by fmsmga001.fm.intel.com with ESMTP; 24 Jul 2019 15:04:05 -0700
MIME-Version: 1.0
In-Reply-To: <c4f23e70-ee47-b576-6b9c-7b2defee3041@redhat.com>
References: <20190723003225.46171-1-rebecca@bsdio.com> <c4f23e70-ee47-b576-6b9c-7b2defee3041@redhat.com>
To: Philippe Mathieu-Daudé <philmd@redhat.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io, rebecca@bsdio.com
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
From: "Jordan Justen" <jordan.l.justen@intel.com>
Message-ID: <156400584459.24070.2221587253012581445@jljusten-skl>
User-Agent: alot/0.8
Date: Wed, 24 Jul 2019 15:04:04 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-07-24 05:21:35, Philippe Mathieu-Daud=C3=A9 wrote:
> On 7/23/19 2:32 AM, rebecca@bsdio.com wrote:
> > Enable multithreaded builds by default when building OvmfPkg
> > using build.sh.
> > This can drastically reduce build times. For example, on a
> > modern ThreadRipper system the time required to build decreases
> > from 3 minutes to 1 minute.
> >=20
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> >  OvmfPkg/build.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> > index 4fcbdd2bc9..bacab5e22a 100755
> > --- a/OvmfPkg/build.sh
> > +++ b/OvmfPkg/build.sh
> > @@ -40,7 +40,7 @@ ARCH_X64=3Dno
> >  BUILDTARGET=3DDEBUG
> >  BUILD_OPTIONS=3D
> >  PLATFORMFILE=3D
> > -THREADNUMBER=3D1
> > +THREADNUMBER=3D0
> >  LAST_ARG=3D
> >  RUN_QEMU=3Dno
> >  ENABLE_FLASH=3Dno
> >=20
>=20
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Whoops. Sorry, I pushed this a few days back, but I forgot to reply to
notify the list.

It's 83e7d5c75e7304aa5172c88eb24fa563445ce043.

-Jordan