* [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
@ 2019-07-23 0:32 rebecca
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: rebecca @ 2019-07-23 0:32 UTC (permalink / raw)
To: devel, Jordan Justen, Laszlo Ersek, Ard Biesheuvel; +Cc: Rebecca Cran
Enable multithreaded builds by default when building OvmfPkg
using build.sh.
This can drastically reduce build times. For example, on a
modern ThreadRipper system the time required to build decreases
from 3 minutes to 1 minute.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
OvmfPkg/build.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 4fcbdd2bc9..bacab5e22a 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -40,7 +40,7 @@ ARCH_X64=no
BUILDTARGET=DEBUG
BUILD_OPTIONS=
PLATFORMFILE=
-THREADNUMBER=1
+THREADNUMBER=0
LAST_ARG=
RUN_QEMU=no
ENABLE_FLASH=no
--
2.22.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
2019-07-23 0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
@ 2019-07-23 7:47 ` Jordan Justen
2019-07-23 12:13 ` Laszlo Ersek
2019-07-23 9:49 ` Laszlo Ersek
2019-07-24 12:21 ` Philippe Mathieu-Daudé
2 siblings, 1 reply; 6+ messages in thread
From: Jordan Justen @ 2019-07-23 7:47 UTC (permalink / raw)
To: Ard Biesheuvel, Laszlo Ersek, devel, rebecca; +Cc: Rebecca Cran
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Laszlo, want me to add your r-b?
On 2019-07-22 17:32:25, wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..bacab5e22a 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -40,7 +40,7 @@ ARCH_X64=no
> BUILDTARGET=DEBUG
> BUILD_OPTIONS=
> PLATFORMFILE=
> -THREADNUMBER=1
> +THREADNUMBER=0
> LAST_ARG=
> RUN_QEMU=no
> ENABLE_FLASH=no
> --
> 2.22.0
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
@ 2019-07-23 12:13 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2019-07-23 12:13 UTC (permalink / raw)
To: Jordan Justen, Ard Biesheuvel, devel, rebecca
On 07/23/19 09:47, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
> Laszlo, want me to add your r-b?
Yes, please:
http://mid.mail-archive.com/86503359-2f97-a602-b918-abb8cb3d6da2@redhat.com
https://edk2.groups.io/g/devel/message/44239
(At the time of writing my email, your R-b was already on the list, but
I hadn't seen it yet -- you sent your R-b between my prior IMAP sync and
my reading of the v2 patch.)
Thanks!
Laszlo
> On 2019-07-22 17:32:25, wrote:
>> Enable multithreaded builds by default when building OvmfPkg
>> using build.sh.
>> This can drastically reduce build times. For example, on a
>> modern ThreadRipper system the time required to build decreases
>> from 3 minutes to 1 minute.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index 4fcbdd2bc9..bacab5e22a 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -40,7 +40,7 @@ ARCH_X64=no
>> BUILDTARGET=DEBUG
>> BUILD_OPTIONS=
>> PLATFORMFILE=
>> -THREADNUMBER=1
>> +THREADNUMBER=0
>> LAST_ARG=
>> RUN_QEMU=no
>> ENABLE_FLASH=no
>> --
>> 2.22.0
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
2019-07-23 0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
@ 2019-07-23 9:49 ` Laszlo Ersek
2019-07-24 12:21 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2019-07-23 9:49 UTC (permalink / raw)
To: devel, rebecca, Jordan Justen, Ard Biesheuvel
On 07/23/19 02:32, rebecca@bsdio.com wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..bacab5e22a 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -40,7 +40,7 @@ ARCH_X64=no
> BUILDTARGET=DEBUG
> BUILD_OPTIONS=
> PLATFORMFILE=
> -THREADNUMBER=1
> +THREADNUMBER=0
> LAST_ARG=
> RUN_QEMU=no
> ENABLE_FLASH=no
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
I won't push this patch until Jordan approves it too.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
2019-07-23 0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
2019-07-23 9:49 ` Laszlo Ersek
@ 2019-07-24 12:21 ` Philippe Mathieu-Daudé
2019-07-24 22:04 ` Jordan Justen
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-24 12:21 UTC (permalink / raw)
To: devel, rebecca, Jordan Justen, Laszlo Ersek, Ard Biesheuvel
On 7/23/19 2:32 AM, rebecca@bsdio.com wrote:
> Enable multithreaded builds by default when building OvmfPkg
> using build.sh.
> This can drastically reduce build times. For example, on a
> modern ThreadRipper system the time required to build decreases
> from 3 minutes to 1 minute.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 4fcbdd2bc9..bacab5e22a 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -40,7 +40,7 @@ ARCH_X64=no
> BUILDTARGET=DEBUG
> BUILD_OPTIONS=
> PLATFORMFILE=
> -THREADNUMBER=1
> +THREADNUMBER=0
> LAST_ARG=
> RUN_QEMU=no
> ENABLE_FLASH=no
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default
2019-07-24 12:21 ` Philippe Mathieu-Daudé
@ 2019-07-24 22:04 ` Jordan Justen
0 siblings, 0 replies; 6+ messages in thread
From: Jordan Justen @ 2019-07-24 22:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Ard Biesheuvel, Laszlo Ersek, devel,
rebecca
On 2019-07-24 05:21:35, Philippe Mathieu-Daudé wrote:
> On 7/23/19 2:32 AM, rebecca@bsdio.com wrote:
> > Enable multithreaded builds by default when building OvmfPkg
> > using build.sh.
> > This can drastically reduce build times. For example, on a
> > modern ThreadRipper system the time required to build decreases
> > from 3 minutes to 1 minute.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> > OvmfPkg/build.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> > index 4fcbdd2bc9..bacab5e22a 100755
> > --- a/OvmfPkg/build.sh
> > +++ b/OvmfPkg/build.sh
> > @@ -40,7 +40,7 @@ ARCH_X64=no
> > BUILDTARGET=DEBUG
> > BUILD_OPTIONS=
> > PLATFORMFILE=
> > -THREADNUMBER=1
> > +THREADNUMBER=0
> > LAST_ARG=
> > RUN_QEMU=no
> > ENABLE_FLASH=no
> >
>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
Whoops. Sorry, I pushed this a few days back, but I forgot to reply to
notify the list.
It's 83e7d5c75e7304aa5172c88eb24fa563445ce043.
-Jordan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-24 22:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-23 0:32 [PATCH v2] OvmfPkg/build.sh: enable multitheaded build by default rebecca
2019-07-23 7:47 ` [edk2-devel] " Jordan Justen
2019-07-23 12:13 ` Laszlo Ersek
2019-07-23 9:49 ` Laszlo Ersek
2019-07-24 12:21 ` Philippe Mathieu-Daudé
2019-07-24 22:04 ` Jordan Justen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox