public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	Rebecca Cran <rebecca@bsdio.com>,
	devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA
Date: Wed, 24 Jul 2019 15:56:06 -0700	[thread overview]
Message-ID: <156400896627.27388.288023255462734128@jljusten-skl> (raw)
In-Reply-To: <20190724214405.16162-3-rebecca@bsdio.com>

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2019-07-24 14:44:05, Rebecca Cran wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 0219791aa8..960382f633 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -213,17 +213,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>        ENABLE_FLASH=yes
>        ;;
>    esac
> -
> -  ADD_QEMU_HDA=yes
> -  for arg in "$@"
> -  do
> -    case $arg in
> -      -hd[a-d]|-fd[ab]|-cdrom)
> -        ADD_QEMU_HDA=no
> -        break
> -        ;;
> -    esac
> -  done
>  fi
>  
>  #
> @@ -267,9 +256,6 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>    else
>      QEMU_COMMAND="$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> -  if [[ "$ADD_QEMU_HDA" == "yes" ]]; then
> -    QEMU_COMMAND="$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> -  fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
>    exit $?
> -- 
> 2.22.0
> 

  reply	other threads:[~2019-07-24 22:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 21:44 [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' rebecca
2019-07-24 21:44 ` [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-25  2:56   ` Jordan Justen
2019-07-25 11:07   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-24 21:44 ` [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA rebecca
2019-07-24 22:56   ` Jordan Justen [this message]
2019-07-30  2:24     ` [edk2-devel] " rebecca
2019-07-30  5:53       ` Jordan Justen
2019-07-25 11:08   ` Philippe Mathieu-Daudé
2019-07-25 11:07 ` [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' Philippe Mathieu-Daudé
2019-07-25 12:45   ` rebecca
2019-07-25 13:36     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156400896627.27388.288023255462734128@jljusten-skl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox