From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jordan.l.justen@intel.com)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by groups.io with SMTP; Wed, 24 Jul 2019 15:56:07 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 15:56:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,304,1559545200"; 
   d="scan'208";a="160721624"
Received: from jpolitsc-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.111.52])
  by orsmga007.jf.intel.com with ESMTP; 24 Jul 2019 15:56:06 -0700
MIME-Version: 1.0
In-Reply-To: <20190724214405.16162-3-rebecca@bsdio.com>
References: <20190724214405.16162-1-rebecca@bsdio.com> <20190724214405.16162-3-rebecca@bsdio.com>
Subject: Re: [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA
Cc: Rebecca Cran <rebecca@bsdio.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Message-ID: <156400896627.27388.288023255462734128@jljusten-skl>
User-Agent: alot/0.8
Date: Wed, 24 Jul 2019 15:56:06 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2019-07-24 14:44:05, Rebecca Cran wrote:
> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> disk. Since newer versions run without any disks, remove it.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 14 --------------
>  1 file changed, 14 deletions(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 0219791aa8..960382f633 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -213,17 +213,6 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>        ENABLE_FLASH=3Dyes
>        ;;
>    esac
> -
> -  ADD_QEMU_HDA=3Dyes
> -  for arg in "$@"
> -  do
> -    case $arg in
> -      -hd[a-d]|-fd[ab]|-cdrom)
> -        ADD_QEMU_HDA=3Dno
> -        break
> -        ;;
> -    esac
> -  done
>  fi
> =20
>  #
> @@ -267,9 +256,6 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>    else
>      QEMU_COMMAND=3D"$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> -  if [[ "$ADD_QEMU_HDA" =3D=3D "yes" ]]; then
> -    QEMU_COMMAND=3D"$QEMU_COMMAND -hda fat:$BUILD_ROOT_ARCH"
> -  fi
>    echo Running: $QEMU_COMMAND "$@"
>    $QEMU_COMMAND "$@"
>    exit $?
> --=20
> 2.22.0
>=20