From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: jordan.l.justen@intel.com)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by groups.io with SMTP; Wed, 24 Jul 2019 19:56:07 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2019 19:56:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,305,1559545200"; 
   d="scan'208";a="321534153"
Received: from jpolitsc-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.111.52])
  by orsmga004.jf.intel.com with ESMTP; 24 Jul 2019 19:56:06 -0700
MIME-Version: 1.0
In-Reply-To: <20190724214405.16162-2-rebecca@bsdio.com>
References: <20190724214405.16162-1-rebecca@bsdio.com> <20190724214405.16162-2-rebecca@bsdio.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laszlo Ersek <lersek@redhat.com>, Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Subject: Re: [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
Cc: Rebecca Cran <rebecca@bsdio.com>
Message-ID: <156402336574.30305.7316825351589746897@jljusten-skl>
User-Agent: alot/0.8
Date: Wed, 24 Jul 2019 19:56:05 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2019-07-24 14:44:04, Rebecca Cran wrote:
> Specify the firmware to use via the newer '-drive if=3Dpflash' syntax
> which allows specifying the raw format parameter. This
> avoids warnings with newer version of QEMU.
>=20
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  OvmfPkg/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> index 1c28e65404..0219791aa8 100755
> --- a/OvmfPkg/build.sh
> +++ b/OvmfPkg/build.sh
> @@ -263,7 +263,7 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>    fi
>    ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>    if [[ "$ENABLE_FLASH" =3D=3D "yes" ]]; then
> -    QEMU_COMMAND=3D"$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
> +    QEMU_COMMAND=3D"$QEMU_COMMAND -drive if=3Dpflash,format=3Draw,file=
=3D$QEMU_FIRMWARE_DIR/bios.bin"
>    else
>      QEMU_COMMAND=3D"$QEMU_COMMAND -L $QEMU_FIRMWARE_DIR"
>    fi
> --=20
> 2.22.0
>=20