public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	devel@edk2.groups.io, rebecca@bsdio.com
Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA
Date: Mon, 29 Jul 2019 22:53:43 -0700	[thread overview]
Message-ID: <156446602266.3012.9785803393596587267@jljusten-skl> (raw)
In-Reply-To: <ff2d2995-e305-16b9-8244-38f408fc7384@bsdio.com>

On 2019-07-29 19:24:00,  wrote:
> On 2019-07-24 16:56, Jordan Justen wrote:
> > Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> >
> > On 2019-07-24 14:44:05, Rebecca Cran wrote:
> >> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> >> disk. Since newer versions run without any disks, remove it.
> >>
> >> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> 
> Could someone push the series, please?
> 

I pushed 2 & 3 as:

4634fd429e G OvmfPkg/build.sh: remove $ADD_QEMU_HDA
8fed4e47d9 G (origin/master, origin/HEAD) OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

I still want to look closer at patch 1.

-Jordan

  reply	other threads:[~2019-07-30  5:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 21:44 [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' rebecca
2019-07-24 21:44 ` [PATCH v2 2/3] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu rebecca
2019-07-25  2:56   ` Jordan Justen
2019-07-25 11:07   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-07-24 21:44 ` [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA rebecca
2019-07-24 22:56   ` Jordan Justen
2019-07-30  2:24     ` [edk2-devel] " rebecca
2019-07-30  5:53       ` Jordan Justen [this message]
2019-07-25 11:08   ` Philippe Mathieu-Daudé
2019-07-25 11:07 ` [edk2-devel] [PATCH v2 1/3] OvmfPkg/build.sh: use POSIX 'command -v' instead of 'which' Philippe Mathieu-Daudé
2019-07-25 12:45   ` rebecca
2019-07-25 13:36     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156446602266.3012.9785803393596587267@jljusten-skl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox