From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jordan.l.justen@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Mon, 29 Jul 2019 22:53:44 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 22:53:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,325,1559545200"; d="scan'208";a="255505226" Received: from bmjomaa-mobl2.amr.corp.intel.com (HELO localhost) ([10.251.130.107]) by orsmga001.jf.intel.com with ESMTP; 29 Jul 2019 22:53:43 -0700 MIME-Version: 1.0 In-Reply-To: References: <20190724214405.16162-1-rebecca@bsdio.com> <20190724214405.16162-3-rebecca@bsdio.com> <156400896627.27388.288023255462734128@jljusten-skl> From: "Jordan Justen" To: Ard Biesheuvel , Laszlo Ersek , devel@edk2.groups.io, rebecca@bsdio.com Subject: Re: [edk2-devel] [PATCH v2 3/3] OvmfPkg/build.sh: remove $ADD_QEMU_HDA Message-ID: <156446602266.3012.9785803393596587267@jljusten-skl> User-Agent: alot/0.8 Date: Mon, 29 Jul 2019 22:53:43 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-07-29 19:24:00, wrote: > On 2019-07-24 16:56, Jordan Justen wrote: > > Reviewed-by: Jordan Justen > > > > On 2019-07-24 14:44:05, Rebecca Cran wrote: > >> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a > >> disk. Since newer versions run without any disks, remove it. > >> > >> Signed-off-by: Rebecca Cran >=20 > Could someone push the series, please? >=20 I pushed 2 & 3 as: 4634fd429e G OvmfPkg/build.sh: remove $ADD_QEMU_HDA 8fed4e47d9 G (origin/master, origin/HEAD) OvmfPkg/build.sh: use newer '-dri= ve if=3Dpflash' syntax when running qemu I still want to look closer at patch 1. -Jordan