From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jordan.l.justen@intel.com)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by groups.io with SMTP; Fri, 02 Aug 2019 11:30:46 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 11:30:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,339,1559545200"; 
   d="scan'208";a="184655132"
Received: from blwixom-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.138.75])
  by orsmga002.jf.intel.com with ESMTP; 02 Aug 2019 11:30:45 -0700
MIME-Version: 1.0
In-Reply-To: <20190802001314.25980-1-michael.d.kinney@intel.com>
References: <20190802001314.25980-1-michael.d.kinney@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives
From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Message-ID: <156477064505.20290.8743109124093550563@jljusten-skl>
User-Agent: alot/0.8
Date: Fri, 02 Aug 2019 11:30:45 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-08-01 17:13:11, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2044
>=20
> * Add '--no-textconv' to 'git show' command to disable binary->text conv=
ersion.
> * Ignore blank lines in patch
> * Ignore lines with 'copy from ' and 'copy to ' prefixes
>=20
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>=20
> Michael D Kinney (3):
>   BaseTools/PatchCheck: Ignore blank lines in diff
>   BaseTools/PatchCheck: Add copy from/to keywords

patches 1 and 2: Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>   BaseTools/PatchCheck: Disable text conversion in 'git show'
>=20
>  BaseTools/Scripts/PatchCheck.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> --=20
> 2.21.0.windows.1
>=20
>=20
>=20
>=20