From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jordan.l.justen@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Fri, 09 Aug 2019 16:08:09 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2019 16:08:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,367,1559545200"; d="scan'208";a="204069520" Received: from bquerbac-mobl.amr.corp.intel.com (HELO localhost) ([10.252.129.85]) by fmsmga002.fm.intel.com with ESMTP; 09 Aug 2019 16:08:08 -0700 MIME-Version: 1.0 In-Reply-To: <20190809224405.13536-1-michael.d.kinney@intel.com> References: <20190809224405.13536-1-michael.d.kinney@intel.com> Subject: Re: [Patch V3 0/4] EmulatorPkg: Fix VS20xx IA32 boot and simplify build config From: "Jordan Justen" To: Michael D Kinney , devel@edk2.groups.io Cc: Andrew Fish , Ray Ni Message-ID: <156539208757.28138.10778164143207338279@jljusten-skl> User-Agent: alot/0.8 Date: Fri, 09 Aug 2019 16:08:07 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-08-09 15:44:01, Michael D Kinney wrote: > New in V3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > * Fix size value used in call to AsciiStrCpyS() in PosixFileSystem.c > * Fix XCODE5 safe string function build failure in BerkleyPacketFilter.c > * Add NOOPT build target to DSC file. >=20 > New in V2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D > * Fix size values in safe string function calls. > * Update POSIX sources to use AsciiStrCpyS() and AsciiStrCatS(). > * Verify that no exceptions occur if EMU_MAGIC_PAGE() can not be mapped. = An > error message is generated and the host app exits normally. > * Update EmulatorPkg DEC file with a new PcdPeiServicesTablePage default = value > that works for Windows/POSIX hosts for both IA32 and X64. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D162 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2055 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2056 >=20 > * Fix VS20xx IA32 boot failure > * Remove UNIX_SEC_BUILD/WIN_SEC_BUILD > * Add -D DISABLE_NEW_DEPRECATED_INTERFACES >=20 > Cc: Jordan Justen > Cc: Andrew Fish > Cc: Ray Ni > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (4): > EmulatorPkg: Fix VS20xx IA32 boot failure Reviewed-by: Jordan Justen > EmulatorPkg: Remove UNIX_SEC_BUILD/WIN_SEC_BUILD Reviewed-by: Jordan Justen > EmulatorPkg: Add -D DISABLE_NEW_DEPRECATED_INTERFACES Acked-by: Jordan Justen > EmulatorPkg: Add support for NOOPT target Reviewed-by: Jordan Justen Were you able to test this still boots on Linux? -Jordan >=20 > EmulatorPkg/EmuBusDriverDxe/EmuBusDriverDxe.c | 9 +- > EmulatorPkg/EmulatorPkg.dec | 4 +- > EmulatorPkg/EmulatorPkg.dsc | 34 ++--- > EmulatorPkg/FlashMapPei/FlashMapPei.c | 8 +- > EmulatorPkg/Library/SmbiosLib/SmbiosLib.c | 4 +- > .../ThunkProtocolList/ThunkProtocolList.c | 11 +- > EmulatorPkg/Readme.md | 8 +- > EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 10 +- > EmulatorPkg/Unix/Host/PosixFileSystem.c | 80 ++++++++---- > EmulatorPkg/Unix/Host/X11GraphicsWindow.c | 4 +- > EmulatorPkg/Win/Host/WinFileSystem.c | 116 ++++++++++++------ > EmulatorPkg/Win/VS2017/BuildVS.bat | 2 +- > EmulatorPkg/build.sh | 8 +- > 13 files changed, 197 insertions(+), 101 deletions(-) >=20 > --=20 > 2.21.0.windows.1 >=20