Re: [Patch V4 07/10] EmulatorPkg/Unix/Host: Fix BerkeleyPacketFilter.c issues

["Jordan Justen" <jordan.l.justen@intel.com>]

On 2019-08-15 19:14:34, Michael D Kinney wrote:
> * Fix uninitialized Private->ReadBuffer.
> * Remove old debug code that generates an exception.

Bulleted lists in the commit message often makes me think they should
be separate patches. Maybe that could improve the commit message
subject line for the patches too. :)

-Jordan

> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Andrew Fish <afish@apple.com>
> ---
>  EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> index 8d0eb0d197..3013bbc86b 100644
> --- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> +++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> @@ -216,6 +216,7 @@ EmuSnpStart (
>    }
>  
>    Status = EFI_SUCCESS;
> +  Private->ReadBuffer = NULL;
>    if (Private->BpfFd == 0) {
>      Status = OpenBpfFileDescriptor (Private, &Private->BpfFd);
>      if (EFI_ERROR (Status)) {
> @@ -766,10 +767,6 @@ EmuSnpGetStatus (
>  
>    Private = EMU_SNP_PRIVATE_DATA_FROM_THIS (This);
>  
> -  if (TxBuf != NULL) {
> -    *((UINT8 **)TxBuf) =  (UINT8 *)1;
> -  }
> -
>    if ( InterruptStatus != NULL ) {
>      *InterruptStatus = EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT;
>    }
> -- 
> 2.21.0.windows.1
>