From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jordan.l.justen@intel.com)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by groups.io with SMTP; Fri, 16 Aug 2019 00:48:04 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2019 00:47:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; 
   d="scan'208";a="179611413"
Received: from adnanrez-mobl.amr.corp.intel.com (HELO localhost) ([10.255.228.102])
  by orsmga003.jf.intel.com with ESMTP; 16 Aug 2019 00:47:40 -0700
MIME-Version: 1.0
In-Reply-To: <20190816021437.7516-8-michael.d.kinney@intel.com>
References: <20190816021437.7516-1-michael.d.kinney@intel.com> <20190816021437.7516-8-michael.d.kinney@intel.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Subject: Re: [Patch V4 07/10] EmulatorPkg/Unix/Host: Fix BerkeleyPacketFilter.c issues
Cc: Ray Ni <ray.ni@intel.com>, Andrew Fish <afish@apple.com>
From: "Jordan Justen" <jordan.l.justen@intel.com>
Message-ID: <156594165971.32637.4311984030869202263@jljusten-skl>
User-Agent: alot/0.8
Date: Fri, 16 Aug 2019 00:47:39 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2019-08-15 19:14:34, Michael D Kinney wrote:
> * Fix uninitialized Private->ReadBuffer.
> * Remove old debug code that generates an exception.

Bulleted lists in the commit message often makes me think they should
be separate patches. Maybe that could improve the commit message
subject line for the patches too. :)

-Jordan

>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Andrew Fish <afish@apple.com>
> ---
>  EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c b/EmulatorPkg/U=
nix/Host/BerkeleyPacketFilter.c
> index 8d0eb0d197..3013bbc86b 100644
> --- a/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> +++ b/EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c
> @@ -216,6 +216,7 @@ EmuSnpStart (
>    }
> =20
>    Status =3D EFI_SUCCESS;
> +  Private->ReadBuffer =3D NULL;
>    if (Private->BpfFd =3D=3D 0) {
>      Status =3D OpenBpfFileDescriptor (Private, &Private->BpfFd);
>      if (EFI_ERROR (Status)) {
> @@ -766,10 +767,6 @@ EmuSnpGetStatus (
> =20
>    Private =3D EMU_SNP_PRIVATE_DATA_FROM_THIS (This);
> =20
> -  if (TxBuf !=3D NULL) {
> -    *((UINT8 **)TxBuf) =3D  (UINT8 *)1;
> -  }
> -
>    if ( InterruptStatus !=3D NULL ) {
>      *InterruptStatus =3D EFI_SIMPLE_NETWORK_TRANSMIT_INTERRUPT;
>    }
> --=20
> 2.21.0.windows.1
>=20