* [PATCH v1 0/1] DisplayLink GOP driver USB msg initialisation
@ 2019-09-11 7:42 Andy Hayes
2019-09-11 7:42 ` [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Andy Hayes
0 siblings, 1 reply; 4+ messages in thread
From: Andy Hayes @ 2019-09-11 7:42 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Andy Hayes, Leif Lindholm, Ard Biesheuvel
Corrected initialisation of one of data structures used to transmit USB
control messages. Mistake had no practical effects but fixing to be on safe
side.
https://github.com/andy-hayes/edk2-platforms
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Andy Hayes (1):
Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
2019-09-11 7:42 [PATCH v1 0/1] DisplayLink GOP driver USB msg initialisation Andy Hayes
@ 2019-09-11 7:42 ` Andy Hayes
2019-09-17 15:27 ` Leif Lindholm
0 siblings, 1 reply; 4+ messages in thread
From: Andy Hayes @ 2019-09-11 7:42 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Andy Hayes, Leif Lindholm, Ard Biesheuvel
Corrected initialisation of one of data structures used to transmit USB
control messages. Mistake had no practical effects but fixing to be on safe
side.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Andy Hayes <andy.hayes@displaylink.com>
---
Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
index 252293da39d4..9871ab0378ce 100644
--- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
+++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
@@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
UINT32 UsbStatus;
EFI_USB_DEVICE_REQUEST UsbRequest;
- ZeroMem (&Request, sizeof (Request));
+ ZeroMem (&UsbRequest, sizeof (UsbRequest));
UsbRequest.RequestType = USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;
UsbRequest.Index = Device->InterfaceDescriptor.InterfaceNumber;
UsbRequest.Request = Request;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
2019-09-11 7:42 ` [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Andy Hayes
@ 2019-09-17 15:27 ` Leif Lindholm
2019-09-17 15:32 ` [External] " Andy Hayes
0 siblings, 1 reply; 4+ messages in thread
From: Leif Lindholm @ 2019-09-17 15:27 UTC (permalink / raw)
To: Andy Hayes; +Cc: devel@edk2.groups.io, Ard Biesheuvel
On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy Hayes wrote:
> Corrected initialisation of one of data structures used to transmit USB
> control messages. Mistake had no practical effects but fixing to be on safe
> side.
So, was the only request used index 0? Or why didn't this cause an
issue? Nevertheless, a clear fix.
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 958aaf600728.
/
Leif
> ---
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> index 252293da39d4..9871ab0378ce 100644
> --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
> UINT32 UsbStatus;
> EFI_USB_DEVICE_REQUEST UsbRequest;
>
> - ZeroMem (&Request, sizeof (Request));
> + ZeroMem (&UsbRequest, sizeof (UsbRequest));
> UsbRequest.RequestType = USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;
> UsbRequest.Index = Device->InterfaceDescriptor.InterfaceNumber;
> UsbRequest.Request = Request;
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
2019-09-17 15:27 ` Leif Lindholm
@ 2019-09-17 15:32 ` Andy Hayes
0 siblings, 0 replies; 4+ messages in thread
From: Andy Hayes @ 2019-09-17 15:32 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel@edk2.groups.io, Ard Biesheuvel
[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]
That's right, the only (current) request was index 0 - that is why it didn't show up. It was a refactoring error.
It was picked up when we ported some of the changes back into our "closed source" version of the driver and the unit tests failed.
Thanks for pushing this.
From: Leif Lindholm <leif.lindholm@linaro.org>
Sent: 17 September 2019 16:28
To: Andy Hayes <andy.hayes@displaylink.com>
Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [External] Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy Hayes wrote:
> Corrected initialisation of one of data structures used to transmit USB
> control messages. Mistake had no practical effects but fixing to be on safe
> side.
So, was the only request used index 0? Or why didn't this cause an
issue? Nevertheless, a clear fix.
> Cc: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org<mailto:ard.biesheuvel@linaro.org>>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com<mailto:andy.hayes@displaylink.com>>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
Pushed as 958aaf600728.
/
Leif
> ---
> Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> index 252293da39d4..9871ab0378ce 100644
> --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
> UINT32 UsbStatus;
> EFI_USB_DEVICE_REQUEST UsbRequest;
>
> - ZeroMem (&Request, sizeof (Request));
> + ZeroMem (&UsbRequest, sizeof (UsbRequest));
> UsbRequest.RequestType = USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;
> UsbRequest.Index = Device->InterfaceDescriptor.InterfaceNumber;
> UsbRequest.Request = Request;
> --
> 1.8.3.1<http://1.8.3.1>
>
[-- Attachment #2: Type: text/html, Size: 4911 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-17 15:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-11 7:42 [PATCH v1 0/1] DisplayLink GOP driver USB msg initialisation Andy Hayes
2019-09-11 7:42 ` [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop Andy Hayes
2019-09-17 15:27 ` Leif Lindholm
2019-09-17 15:32 ` [External] " Andy Hayes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox