From: "Liming Gao" <liming.gao@intel.com>
To: devel@edk2.groups.io
Cc: Siyuan Fu <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>
Subject: [Patch 3/6] NetworkPkg: Add PcdTftpBlockSize in NetworkPkg.dec
Date: Tue, 17 Sep 2019 10:58:56 +0800 [thread overview]
Message-ID: <1568689139-10548-4-git-send-email-liming.gao@intel.com> (raw)
In-Reply-To: <1568689139-10548-1-git-send-email-liming.gao@intel.com>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195
PcdTftpBlockSize is network related PCD. It should be defined in NetworkPkg.dec.
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
NetworkPkg/NetworkPkg.dec | 7 +++++++
NetworkPkg/NetworkPkg.uni | 6 ++++++
2 files changed, 13 insertions(+)
diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec
index c39e7d692e..944b1d1501 100644
--- a/NetworkPkg/NetworkPkg.dec
+++ b/NetworkPkg/NetworkPkg.dec
@@ -102,6 +102,13 @@
# @Prompt PXE TFTP windowsize.
gEfiNetworkPkgTokenSpaceGuid.PcdPxeTftpWindowSize|0x4|UINT64|0x10000008
+
+ ## This setting can override the default TFTP block size. A value of 0 computes
+ # the default from MTU information. A non-zero value will be used as block size
+ # in bytes.
+ # @Prompt TFTP block size.
+ gEfiNetworkPkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x1000000B
+
[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355).
# 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT]
diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni
index ab9b4d21d3..19e57a4a60 100644
--- a/NetworkPkg/NetworkPkg.uni
+++ b/NetworkPkg/NetworkPkg.uni
@@ -92,3 +92,9 @@
#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIPv6PXESupport_HELP #language en-US "Indicates IPV6 PXE Function is enabled or not.\n"
"A value of 0 indicates the IPV6 PXE Function is disabled.\n"
"A value of 1 indicates the IPV6 PXE Function is enabled."
+
+#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdTftpBlockSize_PROMPT #language en-US "TFTP block size"
+
+#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdTftpBlockSize_HELP #language en-US "This setting can override the default TFTP block size. A value of 0 computes "
+ "the default from MTU information. A non-zero value will be used as block size "
+ "in bytes."
--
2.13.0.windows.1
next prev parent reply other threads:[~2019-09-17 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 2:58 [Patch 0/6] Clean up NetworkPkg Liming Gao
2019-09-17 2:58 ` [Patch 1/6] NetworkPkg: Move network related header files from MdeModulePkg to NetworkPkg Liming Gao
2019-09-17 2:58 ` [Patch 2/6] MdeModulePkg: Remove network related guid definitions from MdeModulePkg.dec Liming Gao
2019-09-17 3:02 ` [edk2-devel] " Wu, Hao A
2019-09-17 2:58 ` Liming Gao [this message]
2019-09-17 2:58 ` [Patch 4/6] NetworkPkg UefiPxeBcDxe: Consume PcdTftpBlockSize defined in NetworkPkg.dec Liming Gao
2019-09-17 2:58 ` [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize Liming Gao
2019-09-27 0:35 ` Wu, Hao A
2019-09-17 2:58 ` [Patch 6/6] NetworkPkg: Remove unnecessary MdeModulePkg/MdeModulePkg.dec dependency in INF Liming Gao
2019-09-17 3:15 ` [edk2-devel] [Patch 0/6] Clean up NetworkPkg Siyuan, Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568689139-10548-4-git-send-email-liming.gao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox