From: "Abner Chang" <abner.chang@hpe.com>
To: devel@edk2.groups.io
Cc: abner.chang@hpe.com, Jaben Carsey <jaben.carsey@intel.com>,
Ray Ni <ray.ni@intel.com>, Zhichao Gao <zhichao.gao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Gilbert Chen <gilbert.chen@hpe.com>
Subject: [PATCH v3 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support
Date: Fri, 20 Sep 2019 11:55:11 +0800 [thread overview]
Message-ID: <1568951711-4482-4-git-send-email-abner.chang@hpe.com> (raw)
In-Reply-To: <1568951711-4482-1-git-send-email-abner.chang@hpe.com>
Shell command smbiosview updates for SMBIOS 3.3.0 spec.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
.../SmbiosView/PrintInfo.c | 23 +-------
.../SmbiosView/PrintInfo.h | 13 +----
.../SmbiosView/QueryTable.c | 63 +---------------------
.../UefiShellDebug1CommandsLib.uni | 3 +-
4 files changed, 4 insertions(+), 98 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index ff0c1db..cfd7a2b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -3,7 +3,7 @@
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
(C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
- (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP<BR>
+ (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -1169,15 +1169,6 @@ SmbiosPrintStructure (
break;
//
- // Processor Additional Information (Type 44)
- //
- case 44:
- PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle);
- PRINT_STRUCT_VALUE_H (Struct, Type44, ProcessorSpecificBlock.ProcessorArchType);
- ProcessorArchitectureType (Struct->Type44->ProcessorSpecificBlock.ProcessorArchType, Option);
- break;
-
- //
// Inactive (Type 126)
//
case 126:
@@ -2359,18 +2350,6 @@ DisplayProcessorFamily2 (
Print (L"Video Processor\n");
break;
- case 0x200:
- Print (L"RISC-V RV32\n");
- break;
-
- case 0x201:
- Print (L"RISC-V RV64\n");
- break;
-
- case 0x202:
- Print (L"RISC-V RV128\n");
- break;
-
default:
ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
}
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
index 22f59d6..a8c32ab 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h
@@ -2,7 +2,7 @@
Module to clarify the element info of the smbios structure.
Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR>
- (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP<BR>
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -427,15 +427,4 @@ DisplayTpmDeviceCharacteristics (
IN UINT8 Option
);
-/**
- Display Processor Architecture Type (Type 44).
-
- @param[in] Type The key of the structure.
- @param[in] Option The optional information.
-**/
-VOID
-ProcessorArchitectureType (
- IN UINT8 Type,
- IN UINT8 Option
- );
#endif
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 54e9a52..bfb7c3b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -3,7 +3,7 @@
And give a interface of query a string out of a table.
Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR>
- (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR>
+ (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -620,10 +620,6 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = {
{
7,
L" Power/Performance Control"
- },
- {
- 8,
- L" 128-bit Capable"
}
};
@@ -3272,44 +3268,6 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = {
},
};
-TABLE_ITEM ProcessorArchitectureTypesTable[] = {
- {
- 0,
- L" Reserved "
- },
- {
- 1,
- L" IA32 (x86) "
- },
- {
- 2,
- L" x64 (x86-64, intel64, AMD64, EM64T) "
- },
- {
- 3,
- L" Intel Itanium architecture "
- },
- {
- 4,
- L" 32-bit ARM (Aarch32) "
- },
- {
- 5,
- L" 64-bit ARM (Aarch64) "
- },
- {
- 6,
- L" 32-bit RISC-V (RV32) "
- },
- {
- 7,
- L" 64-bit RISC-V (RV64) "
- },
- {
- 8,
- L" 128-bit RISC-V (RV128) "
- }
-};
TABLE_ITEM StructureTypeInfoTable[] = {
{
@@ -3489,10 +3447,6 @@ TABLE_ITEM StructureTypeInfoTable[] = {
L" TPM Device"
},
{
- 44,
- L" Processor Additional Information"
- },
- {
0x7E,
L" Inactive"
},
@@ -4743,21 +4697,6 @@ DisplayMCHostInterfaceType (
}
/**
- Display Processor Architecture Type (Type 44).
-
- @param[in] Type The key of the structure.
- @param[in] Option The optional information.
-**/
-VOID
-ProcessorArchitectureType (
- IN UINT8 Type,
- IN UINT8 Option
- )
-{
- PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type);
-}
-
-/**
Display the structure type information.
@param[in] Key The key of the structure.
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
index 6693be2..42a9295 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
@@ -2,7 +2,7 @@
//
// Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
// (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR>
-// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR>
+// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
// SPDX-License-Identifier: BSD-2-Clause-Patent
//
// Module Name:
@@ -976,7 +976,6 @@
" 41 - Onboard Devices Extended Information\r\n"
" 42 - Management Controller Host Interface\r\n"
" 43 - TPM Device\r\n"
-" 44 - Processor Additional Information\r\n"
" 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n"
" Do not use the '0x' prefix format for hexadecimal values.\r\n"
" 3. Internal commands:\r\n"
--
2.7.4
prev parent reply other threads:[~2019-09-20 4:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 3:55 [PATCH v3 0/3] Update to support SmBios 3.3.0 Abner Chang
2019-09-20 3:55 ` [PATCH v3 1/3] MdeModulePkg: " Abner Chang
2019-09-20 3:55 ` [PATCH v3 2/3] MdePkg/Include: " Abner Chang
2019-09-20 3:55 ` Abner Chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568951711-4482-4-git-send-email-abner.chang@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox