public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with
@ 2019-09-23  3:40 Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 01/13] U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg Abner Chang
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang

This set of patches is updated to incorporate with patches sent for
edk2-staging/RISC-V-V2 PATCH v2.

Abner Chang (13):
  U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg
  U500Pkg/Sec: Remove unnecessary PCD reference
  U500Pkg/Sec: Add information to header file references
  U500Pkg/SerialIoLib: Header file reference change
  U500Pkg: Update DEC revision
  RiscV :Update INF revision
  Silicon/SiFive: Update INF revision
  Silicon/SiFive :Update DEC revision
  U500Pkg/riscVPlatformTimerLib: Change source code to *.S
  RiscV/Sec: Change source code to *.S
  U500Pkg/SerialIoLib: Add copyrights
  RiscV: Update DEC revision
  U500Pkg: Leverage EmbeddedPkg modules

 .../FirmwareContextProcessorSpecificLib.inf        |   2 +-
 .../RealTimeClockLibNull/RealTimeClockLibNull.inf  |   2 +-
 Platform/RiscV/RiscVPlatformPkg.dec                |   2 +-
 .../OpenSbiPlatformLib/OpenSbiPlatformLib.inf      |  10 +-
 .../U500Pkg/Library/OpenSbiPlatformLib/platform.c  | 242 +++++++++++----------
 .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
 .../PlatformBootManagerLib.inf                     |   2 +-
 .../RiscVPlatformTimerLib.inf                      |   6 +-
 .../U500Pkg/Library/SerialIoLib/SerialIoLib.inf    |   2 +-
 .../U500Pkg/Library/SerialIoLib/SerialPortLib.c    |   3 +-
 Platform/RiscV/SiFive/U500Pkg/U500.dec             |   2 +-
 Platform/RiscV/SiFive/U500Pkg/U500.dsc             |   5 +-
 Platform/RiscV/SiFive/U500Pkg/U500.fdf             |   2 +-
 .../FvbServicesRuntimeDxe.inf                      |   2 +-
 .../U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf    |   2 +-
 .../Universal/Pei/PlatformPei/PlatformPei.inf      |   2 +-
 Platform/RiscV/Universal/Sec/SecMain.c             |  12 +-
 Platform/RiscV/Universal/Sec/SecMain.inf           |   7 +-
 .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
 Silicon/SiFive/SiFive.dec                          |   2 +-
 .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
 .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
 22 files changed, 158 insertions(+), 157 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 01/13] U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 02/13] U500Pkg/Sec: Remove unnecessary PCD reference Abner Chang
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Use Fdtlib in EmbeddedPkg instead of using OpenSbi one.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 .../OpenSbiPlatformLib/OpenSbiPlatformLib.inf      |   8 +-
 .../U500Pkg/Library/OpenSbiPlatformLib/platform.c  | 242 +++++++++++----------
 2 files changed, 127 insertions(+), 123 deletions(-)

diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
index 473386d..1b20b89 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
@@ -30,16 +30,18 @@
   MdePkg/MdePkg.dec
   MdeModulePkg/MdeModulePkg.dec
   RiscVPkg/RiscVPkg.dec
+  EmbeddedPkg/EmbeddedPkg.dec
   Platform/RiscV/RiscVPlatformPkg.dec
 
 [LibraryClasses]
   BaseLib
-  DebugLib
   BaseMemoryLib
-  PcdLib
+  DebugLib
   DebugAgentLib
-  RiscVCpuLib
+  FdtLib
+  PcdLib
   PrintLib
+  RiscVCpuLib
 
 [FixedPcd]
   gUefiRiscVPlatformPkgTokenSpaceGuid.PcdHartCount
diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/platform.c b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/platform.c
index 4dca75f..eaaa2d5 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/platform.c
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/platform.c
@@ -1,7 +1,9 @@
 /*
- * SPDX-License-Identifier: BSD-2-Clause
  *
  * Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ *
  * Copyright (c) 2019 Western Digital Corporation or its affiliates.
  *
  * Authors:
@@ -22,193 +24,193 @@
 
 
 #define U500_HART_COUNT         FixedPcdGet32(PcdHartCount)
-#define U500_HART_STACK_SIZE   FixedPcdGet32(PcdOpenSbiStackSize)
+#define U500_HART_STACK_SIZE    FixedPcdGet32(PcdOpenSbiStackSize)
 #define U500_BOOT_HART_ID       FixedPcdGet32(PcdBootHartId)
 
-#define U500_SYS_CLK         100000000
+#define U500_SYS_CLK            100000000
 
 #define U500_CLINT_ADDR         0x2000000
 
-#define U500_PLIC_ADDR            0xc000000
-#define U500_PLIC_NUM_SOURCES      0x35
-#define U500_PLIC_NUM_PRIORITIES   7
+#define U500_PLIC_ADDR              0xc000000
+#define U500_PLIC_NUM_SOURCES       0x35
+#define U500_PLIC_NUM_PRIORITIES    7
 
-#define U500_UART_ADDR            0x54000000
+#define U500_UART_ADDR              0x54000000
 
-#define U500_UART_BAUDRATE         115200
+#define U500_UART_BAUDRATE          115200
 
 /**
  * The U500 SoC has 8 HARTs but HART ID 0 doesn't have S mode.
  * HARTs 1 is selected as boot HART
  */
 #ifndef U500_ENABLED_HART_MASK
-#define U500_ENABLED_HART_MASK   (1 << U500_BOOT_HART_ID)
+#define U500_ENABLED_HART_MASK  (1 << U500_BOOT_HART_ID)
 #endif
 
-#define U500_HARTID_DISABLED   ~(U500_ENABLED_HART_MASK)
+#define U500_HARTID_DISABLED    ~(U500_ENABLED_HART_MASK)
 
 /* PRCI clock related macros */
 //TODO: Do we need a separate driver for this ?
 #define U500_PRCI_BASE_ADDR         0x10000000
 #define U500_PRCI_CLKMUXSTATUSREG   0x002C
-#define U500_PRCI_CLKMUX_STATUS_TLCLKSEL   (0x1 << 1)
+#define U500_PRCI_CLKMUX_STATUS_TLCLKSEL    (0x1 << 1)
 
 static void U500_modify_dt(void *fdt)
 {
-   u32 i, size;
-   int chosen_offset, err;
-   int cpu_offset;
-   char cpu_node[32] = "";
-   const char *mmu_type;
-
-   for (i = 0; i < U500_HART_COUNT; i++) {
-      sbi_sprintf(cpu_node, "/cpus/cpu@%d", i);
-      cpu_offset = fdt_path_offset(fdt, cpu_node);
-      mmu_type = fdt_getprop(fdt, cpu_offset, "mmu-type", NULL);
-      if (mmu_type && (!strcmp(mmu_type, "riscv,sv39") ||
-          !strcmp(mmu_type,"riscv,sv48")))
-         continue;
-      else
-         fdt_setprop_string(fdt, cpu_offset, "status", "masked");
-      memset(cpu_node, 0, sizeof(cpu_node));
-   }
-   size = fdt_totalsize(fdt);
-   err = fdt_open_into(fdt, fdt, size + 256);
-   if (err < 0)
-      sbi_printf("Device Tree can't be expanded to accmodate new node");
-
-   chosen_offset = fdt_path_offset(fdt, "/chosen");
-   fdt_setprop_string(fdt, chosen_offset, "stdout-path",
-            "/soc/serial@10010000:115200");
-
-   plic_fdt_fixup(fdt, "riscv,plic0");
+    u32 i, size;
+    int chosen_offset, err;
+    int cpu_offset;
+    char cpu_node[32] = "";
+    const char *mmu_type;
+
+    for (i = 0; i < U500_HART_COUNT; i++) {
+        sbi_sprintf(cpu_node, "/cpus/cpu@%d", i);
+        cpu_offset = fdt_path_offset(fdt, cpu_node);
+        mmu_type = fdt_getprop(fdt, cpu_offset, "mmu-type", NULL);
+        if (mmu_type && (!sbi_strcmp(mmu_type, "riscv,sv39") ||
+            !sbi_strcmp(mmu_type,"riscv,sv48")))
+            continue;
+        else
+            fdt_setprop_string(fdt, cpu_offset, "status", "masked");
+        sbi_memset(cpu_node, 0, sizeof(cpu_node));
+    }
+    size = fdt_totalsize(fdt);
+    err = fdt_open_into(fdt, fdt, size + 256);
+    if (err < 0)
+        sbi_printf("Device Tree can't be expanded to accmodate new node");
+
+    chosen_offset = fdt_path_offset(fdt, "/chosen");
+    fdt_setprop_string(fdt, chosen_offset, "stdout-path",
+               "/soc/serial@10010000:115200");
+
+    plic_fdt_fixup(fdt, "riscv,plic0");
 }
 
 static int U500_final_init(bool cold_boot)
 {
-   void *fdt;
+    void *fdt;
 
-   if (!cold_boot)
-      return 0;
+    if (!cold_boot)
+        return 0;
 
-   fdt = sbi_scratch_thishart_arg1_ptr();
-   U500_modify_dt(fdt);
+    fdt = sbi_scratch_thishart_arg1_ptr();
+    U500_modify_dt(fdt);
 
-   return 0;
+    return 0;
 }
 
 static u32 U500_pmp_region_count(u32 hartid)
 {
-   return 1;
+    return 1;
 }
 
 static int U500_pmp_region_info(u32 hartid, u32 index,
-             ulong *prot, ulong *addr, ulong *log2size)
+                 ulong *prot, ulong *addr, ulong *log2size)
 {
-   int ret = 0;
-
-   switch (index) {
-   case 0:
-      *prot = PMP_R | PMP_W | PMP_X;
-      *addr = 0;
-      *log2size = __riscv_xlen;
-      break;
-   default:
-      ret = -1;
-      break;
-   };
-
-   return ret;
+    int ret = 0;
+
+    switch (index) {
+    case 0:
+        *prot = PMP_R | PMP_W | PMP_X;
+        *addr = 0;
+        *log2size = __riscv_xlen;
+        break;
+    default:
+        ret = -1;
+        break;
+    };
+
+    return ret;
 }
 
 static int U500_console_init(void)
 {
-   unsigned long peri_in_freq;
+    unsigned long peri_in_freq;
 
-   peri_in_freq = U500_SYS_CLK/2;
-   return sifive_uart_init(U500_UART_ADDR, peri_in_freq, U500_UART_BAUDRATE);
+    peri_in_freq = U500_SYS_CLK/2;
+    return sifive_uart_init(U500_UART_ADDR, peri_in_freq, U500_UART_BAUDRATE);
 }
 
 static int U500_irqchip_init(bool cold_boot)
 {
-   int rc;
-   u32 hartid = sbi_current_hartid();
-
-   if (cold_boot) {
-      rc = plic_cold_irqchip_init(U500_PLIC_ADDR,
-                   U500_PLIC_NUM_SOURCES,
-                   U500_HART_COUNT);
-      if (rc)
-         return rc;
-   }
-
-   return plic_warm_irqchip_init(hartid,
-         (hartid) ? (2 * hartid - 1) : 0,
-         (hartid) ? (2 * hartid) : -1);
+    int rc;
+    u32 hartid = sbi_current_hartid();
+
+    if (cold_boot) {
+        rc = plic_cold_irqchip_init(U500_PLIC_ADDR,
+                        U500_PLIC_NUM_SOURCES,
+                        U500_HART_COUNT);
+        if (rc)
+            return rc;
+    }
+
+    return plic_warm_irqchip_init(hartid,
+            (hartid) ? (2 * hartid - 1) : 0,
+            (hartid) ? (2 * hartid) : -1);
 }
 
 static int U500_ipi_init(bool cold_boot)
 {
-   int rc;
+    int rc;
 
-   if (cold_boot) {
-      rc = clint_cold_ipi_init(U500_CLINT_ADDR,
-                U500_HART_COUNT);
-      if (rc)
-         return rc;
+    if (cold_boot) {
+        rc = clint_cold_ipi_init(U500_CLINT_ADDR,
+                     U500_HART_COUNT);
+        if (rc)
+            return rc;
 
-   }
+    }
 
-   return clint_warm_ipi_init();
+    return clint_warm_ipi_init();
 }
 
 static int U500_timer_init(bool cold_boot)
 {
-   int rc;
+    int rc;
 
-   if (cold_boot) {
-      rc = clint_cold_timer_init(U500_CLINT_ADDR,
-                  U500_HART_COUNT);
-      if (rc)
-         return rc;
-   }
+    if (cold_boot) {
+        rc = clint_cold_timer_init(U500_CLINT_ADDR,
+                       U500_HART_COUNT);
+        if (rc)
+            return rc;
+    }
 
-   return clint_warm_timer_init();
+    return clint_warm_timer_init();
 }
 
 static int U500_system_down(u32 type)
 {
-   /* For now nothing to do. */
-   return 0;
+    /* For now nothing to do. */
+    return 0;
 }
 
 const struct sbi_platform_operations platform_ops = {
-   .pmp_region_count = U500_pmp_region_count,
-   .pmp_region_info = U500_pmp_region_info,
-   .final_init = U500_final_init,
-   .console_putc = sifive_uart_putc,
-   .console_getc = sifive_uart_getc,
-   .console_init = U500_console_init,
-   .irqchip_init = U500_irqchip_init,
-   .ipi_send = clint_ipi_send,
-   .ipi_sync = clint_ipi_sync,
-   .ipi_clear = clint_ipi_clear,
-   .ipi_init = U500_ipi_init,
-   .timer_value = clint_timer_value,
-   .timer_event_stop = clint_timer_event_stop,
-   .timer_event_start = clint_timer_event_start,
-   .timer_init = U500_timer_init,
-   .system_reboot = U500_system_down,
-   .system_shutdown = U500_system_down
+    .pmp_region_count = U500_pmp_region_count,
+    .pmp_region_info = U500_pmp_region_info,
+    .final_init = U500_final_init,
+    .console_putc = sifive_uart_putc,
+    .console_getc = sifive_uart_getc,
+    .console_init = U500_console_init,
+    .irqchip_init = U500_irqchip_init,
+    .ipi_send = clint_ipi_send,
+    .ipi_sync = clint_ipi_sync,
+    .ipi_clear = clint_ipi_clear,
+    .ipi_init = U500_ipi_init,
+    .timer_value = clint_timer_value,
+    .timer_event_stop = clint_timer_event_stop,
+    .timer_event_start = clint_timer_event_start,
+    .timer_init = U500_timer_init,
+    .system_reboot = U500_system_down,
+    .system_shutdown = U500_system_down
 };
 
 const struct sbi_platform platform = {
-   .opensbi_version   = OPENSBI_VERSION,                  // The OpenSBI version this platform table is built bassed on.
-   .platform_version   = SBI_PLATFORM_VERSION(0x0001, 0x0000),   // SBI Platform version 1.0
-   .name               = "SiFive Freedom U500",
-   .features      = SBI_PLATFORM_DEFAULT_FEATURES,
-   .hart_count      = U500_HART_COUNT,
-   .hart_stack_size   = U500_HART_STACK_SIZE,
-   .disabled_hart_mask   = U500_HARTID_DISABLED,
-   .platform_ops_addr   = (unsigned long)&platform_ops
+    .opensbi_version    = OPENSBI_VERSION,                      // The OpenSBI version this platform table is built bassed on.
+    .platform_version   = SBI_PLATFORM_VERSION(0x0001, 0x0000), // SBI Platform version 1.0
+    .name                   = "SiFive Freedom U500",
+    .features       = SBI_PLATFORM_DEFAULT_FEATURES,
+    .hart_count     = U500_HART_COUNT,
+    .hart_stack_size    = U500_HART_STACK_SIZE,
+    .disabled_hart_mask = U500_HARTID_DISABLED,
+    .platform_ops_addr  = (unsigned long)&platform_ops
 };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 02/13] U500Pkg/Sec: Remove unnecessary PCD reference
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 01/13] U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 03/13] U500Pkg/Sec: Add information to header file references Abner Chang
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Remove unnecessary PCD reference.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/Universal/Sec/SecMain.inf | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/Platform/RiscV/Universal/Sec/SecMain.inf b/Platform/RiscV/Universal/Sec/SecMain.inf
index c408fc8..2c048ff 100644
--- a/Platform/RiscV/Universal/Sec/SecMain.inf
+++ b/Platform/RiscV/Universal/Sec/SecMain.inf
@@ -56,9 +56,6 @@
   gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED
   gEfiTemporaryRamDonePpiGuid    # PPI ALWAYS_PRODUCED
 
-[Guids]
-  gUefiRiscVMachineContextGuid
-
 [FixedPcd]
   gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVPeiFvBase
   gUefiRiscVPlatformPkgTokenSpaceGuid.PcdRiscVPeiFvSize
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 03/13] U500Pkg/Sec: Add information to header file references
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 01/13] U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 02/13] U500Pkg/Sec: Remove unnecessary PCD reference Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 04/13] U500Pkg/SerialIoLib: Header file reference change Abner Chang
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Add more information to header file references.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/Universal/Sec/SecMain.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Platform/RiscV/Universal/Sec/SecMain.c b/Platform/RiscV/Universal/Sec/SecMain.c
index 40b351c..222c7cc 100644
--- a/Platform/RiscV/Universal/Sec/SecMain.c
+++ b/Platform/RiscV/Universal/Sec/SecMain.c
@@ -11,12 +11,12 @@
 #include <Library/SerialPortLib.h>
 #include <Library/PrintLib.h>
 #include <Library/DebugPrintErrorLevelLib.h>
-#include <sbi/sbi_hart.h>
-#include <sbi/sbi_scratch.h>
-#include <sbi/sbi_platform.h>
-#include <sbi/sbi.h>
-#include <sbi/sbi_init.h>
-#include <sbi/SbiFirmwareContext.h>
+#include <sbi/sbi_hart.h>     // Reference to header file in opensbi
+#include <sbi/sbi_scratch.h>  // Reference to header file in opensbi
+#include <sbi/sbi_platform.h> // Reference to header file in opensbi
+#include <sbi/sbi.h>          // Reference to header file in Include/sbi
+#include <sbi/sbi_init.h>     // Reference to header file in opensbi
+#include <sbi/SbiFirmwareContext.h> // Reference to header file in Include/sbi
 
 int HartsIn = 0;
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 04/13] U500Pkg/SerialIoLib: Header file reference change
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (2 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 03/13] U500Pkg/Sec: Add information to header file references Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 05/13] U500Pkg: Update DEC revision Abner Chang
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Change header file reference.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
index e51bf9c..5ed3593 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
@@ -1,9 +1,6 @@
 /** @file
   UART Serial Port library functions
 
-  Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
-  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
-
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -11,7 +8,7 @@
 #include <Base.h>
 #include <Library/IoLib.h>
 #include <Library/SerialPortLib.h>
-#include <sbi_utils/serial/sifive-uart.h>
+#include <include/sbi_utils/serial/sifive-uart.h> // Reference to header file in opensbi
 
 #define REG32(p, i) ((p)[(i) >> 2])
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 05/13] U500Pkg: Update DEC revision
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (3 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 04/13] U500Pkg/SerialIoLib: Header file reference change Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 06/13] RiscV :Update INF revision Abner Chang
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Change DEC revision.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/SiFive/U500Pkg/U500.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RiscV/SiFive/U500Pkg/U500.dec b/Platform/RiscV/SiFive/U500Pkg/U500.dec
index 4ecca89..ad92c28 100644
--- a/Platform/RiscV/SiFive/U500Pkg/U500.dec
+++ b/Platform/RiscV/SiFive/U500Pkg/U500.dec
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  DEC_SPECIFICATION              = 0x00010005
+  DEC_SPECIFICATION              = 0x0001001b
   PACKAGE_NAME                   = U500
   PACKAGE_UNI_FILE               = U500.uni
   PACKAGE_GUID                   = D11E9DB9-5940-4642-979D-2114342140D2
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 06/13] RiscV :Update INF revision
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (4 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 05/13] U500Pkg: Update DEC revision Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 07/13] Silicon/SiFive: Update " Abner Chang
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Update INF revision.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 .../FirmwareContextProcessorSpecificLib.inf                             | 2 +-
 Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf    | 2 +-
 .../SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf    | 2 +-
 .../SiFive/U500Pkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf      | 2 +-
 .../U500Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf   | 2 +-
 Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialIoLib.inf       | 2 +-
 .../Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf    | 2 +-
 Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf       | 2 +-
 Platform/RiscV/SiFive/U500Pkg/Universal/Pei/PlatformPei/PlatformPei.inf | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Platform/RiscV/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf b/Platform/RiscV/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf
index ff841c3..da04d5d 100644
--- a/Platform/RiscV/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf
+++ b/Platform/RiscV/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.inf
@@ -7,7 +7,7 @@
 #**/
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = FirmwareContextProcessorSpecificLib
   FILE_GUID                      = 8BEC9FD7-C554-403A-94F1-0EBBFD81A242
   MODULE_TYPE                    = PEIM
diff --git a/Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf b/Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf
index 21b2e43..b9bffa1 100644
--- a/Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf
+++ b/Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf
@@ -7,7 +7,7 @@
 #**/
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = RealTimeClockLibNull
   FILE_GUID                      = BFC3E25A-8AD0-4201-8A75-F00DE7964370
   MODULE_TYPE                    = BASE
diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
index 1b20b89..d292966 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/OpenSbiPlatformLib/OpenSbiPlatformLib.inf
@@ -10,7 +10,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = OpenSbiPlatformLib
   FILE_GUID                      = 9424ED54-EBDA-4FB5-8FF6-8291B07BB151
   MODULE_TYPE                    = SEC
diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
index 915021f..418536e 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = SiliconSiFiveU5MCCoreplexInfoLib
   FILE_GUID                      = 4E397A71-5164-4E69-9884-70CBE2740AAB
   MODULE_TYPE                    = PEIM
diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
index 92c31db..8890891 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -9,7 +9,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = PlatformBootManagerLib
   FILE_GUID                      = 7DDA7916-6139-4D46-A415-30E854AF3BC7
   MODULE_TYPE                    = DXE_DRIVER
diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialIoLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialIoLib.inf
index 85af1fb..c80405d 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialIoLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialIoLib.inf
@@ -9,7 +9,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = U500SerialPortLib
   MODULE_UNI_FILE                = U500SerialPortLib.uni
   FILE_GUID                      = FCC4FD2B-2FF6-4FFA-B363-7C1111E5DCE9
diff --git a/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf b/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
index 1e8aa59..b234d05 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
@@ -13,7 +13,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = FvbServicesRuntimeDxe
   FILE_GUID                      = B04036D3-4C60-43D6-9850-0FCC090FF054
   MODULE_TYPE                    = DXE_RUNTIME_DRIVER
diff --git a/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf b/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf
index f8af688..f9a3cd7 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = Timer
   MODULE_UNI_FILE                = Timer.uni
   FILE_GUID                      = 3F75D495-23FF-46B6-9D19-0DECC8A4EA91
diff --git a/Platform/RiscV/SiFive/U500Pkg/Universal/Pei/PlatformPei/PlatformPei.inf b/Platform/RiscV/SiFive/U500Pkg/Universal/Pei/PlatformPei/PlatformPei.inf
index 420b070..447bfdc 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Universal/Pei/PlatformPei/PlatformPei.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Universal/Pei/PlatformPei/PlatformPei.inf
@@ -11,7 +11,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = PlatformPei
   FILE_GUID                      = 222c386d-5abc-4fb4-b124-fbb82488acf4
   MODULE_TYPE                    = PEIM
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 07/13] Silicon/SiFive: Update INF revision
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (5 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 06/13] RiscV :Update INF revision Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 08/13] Silicon/SiFive :Update DEC revision Abner Chang
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Update INF revision.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf      | 2 +-
 Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf      | 2 +-
 .../U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf b/Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
index 003ad5a..17e2d1a 100644
--- a/Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
+++ b/Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = SiliconSiFiveE51CoreInfoLib
   FILE_GUID                      = 80A59B85-1245-4309-AC58-2CFA4199B46C
   MODULE_TYPE                    = PEIM
diff --git a/Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf b/Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
index 8efee93..f04a188 100644
--- a/Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
+++ b/Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = SiliconSiFiveU54CoreInfoLib
   FILE_GUID                      = 483DE090-267E-4278-A0A1-15D9836780EA
   MODULE_TYPE                    = PEIM
diff --git a/Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf b/Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
index a5714a2..695740a 100644
--- a/Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
+++ b/Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = SiliconSiFiveU54MCCoreplexInfoLib
   FILE_GUID                      = 483DE090-267E-4278-A0A1-15D9836780EA
   MODULE_TYPE                    = PEIM
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 08/13] Silicon/SiFive :Update DEC revision
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (6 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 07/13] Silicon/SiFive: Update " Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 09/13] U500Pkg/riscVPlatformTimerLib: Change source code to *.S Abner Chang
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Update DEC revision.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Silicon/SiFive/SiFive.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/SiFive/SiFive.dec b/Silicon/SiFive/SiFive.dec
index 7aca3e7..d76458f 100644
--- a/Silicon/SiFive/SiFive.dec
+++ b/Silicon/SiFive/SiFive.dec
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  DEC_SPECIFICATION              = 0x00010005
+  DEC_SPECIFICATION              = 0x0001001b
   PACKAGE_NAME                   = SiFiveSiliconPkg
   PACKAGE_GUID                   = 576912B2-7077-4B78-A934-4C133FEB20BB
   PACKAGE_VERSION                = 1.0
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 09/13] U500Pkg/riscVPlatformTimerLib: Change source code to *.S
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (7 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 08/13] Silicon/SiFive :Update DEC revision Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 10/13] RiscV/Sec: " Abner Chang
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Change *s to *.S.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 .../U500Pkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf b/Platform/RiscV/SiFive/U500Pkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf
index 62771b6..e613c15 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/RiscVPlatformTimerLib/RiscVPlatformTimerLib.inf
@@ -9,7 +9,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = RiscVPlatformTimerLib
   FILE_GUID                      = AFA75BBD-DE9D-4E77-BD88-1EA401BE931D
   MODULE_TYPE                    = BASE
@@ -25,10 +25,10 @@
 [Sources]
 
 [Sources.RISCV32]
-  RiscVPlatformTimerLib.s
+  RiscVPlatformTimerLib.S
 
 [Sources.RISCV64]
-  RiscVPlatformTimerLib.s
+  RiscVPlatformTimerLib.S
 
 [Packages]
   MdePkg/MdePkg.dec
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 10/13] RiscV/Sec: Change source code to *.S
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (8 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 09/13] U500Pkg/riscVPlatformTimerLib: Change source code to *.S Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 11/13] U500Pkg/SerialIoLib: Add copyrights Abner Chang
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Change *s to *.S.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/Universal/Sec/SecMain.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RiscV/Universal/Sec/SecMain.inf b/Platform/RiscV/Universal/Sec/SecMain.inf
index 2c048ff..ddbfe35 100644
--- a/Platform/RiscV/Universal/Sec/SecMain.inf
+++ b/Platform/RiscV/Universal/Sec/SecMain.inf
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  INF_VERSION                    = 0x00010005
+  INF_VERSION                    = 0x0001001b
   BASE_NAME                      = SecMain
   FILE_GUID                      = df1ccef6-f301-4a63-9661-fc6030dcc880
   MODULE_TYPE                    = SEC
@@ -25,7 +25,7 @@
   SecMain.c
 
 [Sources.RISCV64]
-  Riscv64/SecEntry.s
+  Riscv64/SecEntry.S
 
 [Packages]
   MdePkg/MdePkg.dec
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 11/13] U500Pkg/SerialIoLib: Add copyrights
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (9 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 10/13] RiscV/Sec: " Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 12/13] RiscV: Update DEC revision Abner Chang
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Add HPE copyrights.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
index 5ed3593..9e5ae33 100644
--- a/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
+++ b/Platform/RiscV/SiFive/U500Pkg/Library/SerialIoLib/SerialPortLib.c
@@ -1,6 +1,8 @@
 /** @file
   UART Serial Port library functions
 
+  Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
+
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 12/13] RiscV: Update DEC revision
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (10 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 11/13] U500Pkg/SerialIoLib: Add copyrights Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 13/13] U500Pkg: Leverage EmbeddedPkg modules Abner Chang
  2019-10-03 17:55 ` [edk2-devel] [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Leif Lindholm
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Update DEC revision.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/RiscVPlatformPkg.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/RiscV/RiscVPlatformPkg.dec b/Platform/RiscV/RiscVPlatformPkg.dec
index 3ce16bf..5b8c157 100644
--- a/Platform/RiscV/RiscVPlatformPkg.dec
+++ b/Platform/RiscV/RiscVPlatformPkg.dec
@@ -8,7 +8,7 @@
 ##
 
 [Defines]
-  DEC_SPECIFICATION              = 0x00010005
+  DEC_SPECIFICATION              = 0x0001001b
   PACKAGE_NAME                   = RiscPlatformPkg
   PACKAGE_UNI_FILE               = RiscPlatformPkg.uni
   PACKAGE_GUID                   = 6A67AF99-4592-40F8-B6BE-62BCA10DA1EC
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [platforms/devel-riscv-v2 PATCHv3 13/13] U500Pkg: Leverage EmbeddedPkg modules
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (11 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 12/13] RiscV: Update DEC revision Abner Chang
@ 2019-09-23  3:40 ` Abner Chang
  2019-10-03 17:55 ` [edk2-devel] [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Leif Lindholm
  13 siblings, 0 replies; 15+ messages in thread
From: Abner Chang @ 2019-09-23  3:40 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, Leif Lindholm, Gilbert Chen

Use Fdtlib and RealTimeClockDxe from EmbeddedPkg.

Signed-off-by: Abner Chang <abner.chang@hpe.com>

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gilbert Chen <gilbert.chen@hpe.com>
---
 Platform/RiscV/SiFive/U500Pkg/U500.dsc | 5 +++--
 Platform/RiscV/SiFive/U500Pkg/U500.fdf | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Platform/RiscV/SiFive/U500Pkg/U500.dsc b/Platform/RiscV/SiFive/U500Pkg/U500.dsc
index edcd951..4355db4 100644
--- a/Platform/RiscV/SiFive/U500Pkg/U500.dsc
+++ b/Platform/RiscV/SiFive/U500Pkg/U500.dsc
@@ -16,7 +16,7 @@
   PLATFORM_NAME                  = U500
   PLATFORM_GUID                  = 0955581C-2A6A-48F7-8690-9D275AE884F8
   PLATFORM_VERSION               = 0.1
-  DSC_SPECIFICATION              = 0x00010005
+  DSC_SPECIFICATION              = 0x0001001c
   OUTPUT_DIRECTORY               = Build/U500Pkg
   SUPPORTED_ARCHITECTURES        = RISCV64
   BUILD_TARGETS                  = DEBUG|RELEASE
@@ -94,6 +94,7 @@
   CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
   SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+  FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
 
 # RISC-V Platform Library
   RealTimeClockLib|Platform/RiscV/Library/RealTimeClockLibNull/RealTimeClockLibNull.inf
@@ -443,6 +444,7 @@
     <LibraryClasses>
       ResetSystemLib|MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.inf
   }
+  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
 
   #
   # RISC-V Platform module
@@ -454,7 +456,6 @@
   # RISC-V Core module
   #
   RiscVPkg/Universal/CpuDxe/CpuDxe.inf
-  RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
   RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.inf
 
   MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
diff --git a/Platform/RiscV/SiFive/U500Pkg/U500.fdf b/Platform/RiscV/SiFive/U500Pkg/U500.fdf
index 5ca84be..cbf41d0 100644
--- a/Platform/RiscV/SiFive/U500Pkg/U500.fdf
+++ b/Platform/RiscV/SiFive/U500Pkg/U500.fdf
@@ -143,12 +143,12 @@ INF  MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
 INF  UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf
 INF  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
 INF  MdeModulePkg/Universal/Metronome/Metronome.inf
+INF  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
 
 # RISC-V Platform Drivers
 INF  Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
 
 # RISC-V Core Drivers
-INF  RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf
 INF  Platform/RiscV/SiFive/U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf
 INF  RiscVPkg/Universal/CpuDxe/CpuDxe.inf
 INF  RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.inf
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [edk2-devel] [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with
  2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
                   ` (12 preceding siblings ...)
  2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 13/13] U500Pkg: Leverage EmbeddedPkg modules Abner Chang
@ 2019-10-03 17:55 ` Leif Lindholm
  13 siblings, 0 replies; 15+ messages in thread
From: Leif Lindholm @ 2019-10-03 17:55 UTC (permalink / raw)
  To: devel, abner.chang; +Cc: Palmer Dabbelt

On Mon, Sep 23, 2019 at 11:40:24AM +0800, Abner Chang wrote:
> This set of patches is updated to incorporate with patches sent for
> edk2-staging/RISC-V-V2 PATCH v2.
> 
> Abner Chang (13):
>   U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg
>   U500Pkg/Sec: Remove unnecessary PCD reference
>   U500Pkg/Sec: Add information to header file references
>   U500Pkg/SerialIoLib: Header file reference change
>   U500Pkg: Update DEC revision
>   RiscV :Update INF revision
>   Silicon/SiFive: Update INF revision
>   Silicon/SiFive :Update DEC revision
>   U500Pkg/riscVPlatformTimerLib: Change source code to *.S
>   RiscV/Sec: Change source code to *.S
>   U500Pkg/SerialIoLib: Add copyrights
>   RiscV: Update DEC revision
>   U500Pkg: Leverage EmbeddedPkg modules

Thanks for these. I won't review these individually, but they all look
like things I have commented on either for the edk2 set or the v2 set
out of the edk2-platforms one.

Please merge these into the v4 submission.

Best Regards,

Leif

>  .../FirmwareContextProcessorSpecificLib.inf        |   2 +-
>  .../RealTimeClockLibNull/RealTimeClockLibNull.inf  |   2 +-
>  Platform/RiscV/RiscVPlatformPkg.dec                |   2 +-
>  .../OpenSbiPlatformLib/OpenSbiPlatformLib.inf      |  10 +-
>  .../U500Pkg/Library/OpenSbiPlatformLib/platform.c  | 242 +++++++++++----------
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
>  .../PlatformBootManagerLib.inf                     |   2 +-
>  .../RiscVPlatformTimerLib.inf                      |   6 +-
>  .../U500Pkg/Library/SerialIoLib/SerialIoLib.inf    |   2 +-
>  .../U500Pkg/Library/SerialIoLib/SerialPortLib.c    |   3 +-
>  Platform/RiscV/SiFive/U500Pkg/U500.dec             |   2 +-
>  Platform/RiscV/SiFive/U500Pkg/U500.dsc             |   5 +-
>  Platform/RiscV/SiFive/U500Pkg/U500.fdf             |   2 +-
>  .../FvbServicesRuntimeDxe.inf                      |   2 +-
>  .../U500Pkg/Universal/Dxe/TimerDxe/TimerDxe.inf    |   2 +-
>  .../Universal/Pei/PlatformPei/PlatformPei.inf      |   2 +-
>  Platform/RiscV/Universal/Sec/SecMain.c             |  12 +-
>  Platform/RiscV/Universal/Sec/SecMain.inf           |   7 +-
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
>  Silicon/SiFive/SiFive.dec                          |   2 +-
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
>  .../PeiCoreInfoHobLib/PeiCoreInfoHobLib.inf        |   2 +-
>  22 files changed, 158 insertions(+), 157 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2019-10-03 17:55 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-23  3:40 [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 01/13] U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 02/13] U500Pkg/Sec: Remove unnecessary PCD reference Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 03/13] U500Pkg/Sec: Add information to header file references Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 04/13] U500Pkg/SerialIoLib: Header file reference change Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 05/13] U500Pkg: Update DEC revision Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 06/13] RiscV :Update INF revision Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 07/13] Silicon/SiFive: Update " Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 08/13] Silicon/SiFive :Update DEC revision Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 09/13] U500Pkg/riscVPlatformTimerLib: Change source code to *.S Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 10/13] RiscV/Sec: " Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 11/13] U500Pkg/SerialIoLib: Add copyrights Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 12/13] RiscV: Update DEC revision Abner Chang
2019-09-23  3:40 ` [platforms/devel-riscv-v2 PATCHv3 13/13] U500Pkg: Leverage EmbeddedPkg modules Abner Chang
2019-10-03 17:55 ` [edk2-devel] [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox