* [PATCH v5 0/3] Update to support SmBios 3.3.0 @ 2019-10-08 8:04 Abner Chang 2019-10-08 8:04 ` [PATCH v5 1/3] MdeModulePkg: " Abner Chang ` (3 more replies) 0 siblings, 4 replies; 9+ messages in thread From: Abner Chang @ 2019-10-08 8:04 UTC (permalink / raw) To: devel; +Cc: abner.chang Codes changes for SMBIOS spec 3.3.0 (Already public on DMTF). Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Abner Chang (3): MdeModulePkg: Update to support SmBios 3.3.0 MdePkg/Include: Update to support SmBios 3.3.0 ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 MdeModulePkg/MdeModulePkg.dec | 4 +- MdePkg/Include/IndustryStandard/SmBios.h | 76 +++++++++++++++++++++- .../SmbiosView/PrintInfo.c | 23 ++++++- .../SmbiosView/PrintInfo.h | 13 +++- .../SmbiosView/QueryTable.c | 63 +++++++++++++++++- .../UefiShellDebug1CommandsLib.uni | 3 +- 6 files changed, 173 insertions(+), 9 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5 1/3] MdeModulePkg: Update to support SmBios 3.3.0 2019-10-08 8:04 [PATCH v5 0/3] Update to support SmBios 3.3.0 Abner Chang @ 2019-10-08 8:04 ` Abner Chang 2019-10-17 2:46 ` [edk2-devel] " Wu, Hao A 2019-10-08 8:04 ` [PATCH v5 2/3] MdePkg/Include: " Abner Chang ` (2 subsequent siblings) 3 siblings, 1 reply; 9+ messages in thread From: Abner Chang @ 2019-10-08 8:04 UTC (permalink / raw) To: devel; +Cc: abner.chang, Hao A Wu, Jian J Wang, Leif Lindholm, Gilbert Chen This commit update the revision of SMBIOS spec reported in PCDs. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang <abner.chang@hpe.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Gilbert Chen <gilbert.chen@hpe.com> --- MdeModulePkg/MdeModulePkg.dec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 19935c8..6b40021 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -5,7 +5,7 @@ # # Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR> -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> +# (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR> # Copyright (c) 2016, Microsoft Corporation<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -1792,7 +1792,7 @@ ## SMBIOS version. # @Prompt SMBIOS version. - gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302|UINT16|0x00010055 + gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0303|UINT16|0x00010055 ## SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point Structure. # @Prompt SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point Structure. -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v5 1/3] MdeModulePkg: Update to support SmBios 3.3.0 2019-10-08 8:04 ` [PATCH v5 1/3] MdeModulePkg: " Abner Chang @ 2019-10-17 2:46 ` Wu, Hao A 0 siblings, 0 replies; 9+ messages in thread From: Wu, Hao A @ 2019-10-17 2:46 UTC (permalink / raw) To: devel@edk2.groups.io, abner.chang@hpe.com, Gao, Liming Cc: Wang, Jian J, Leif Lindholm, Gilbert Chen > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Tuesday, October 08, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Wu, Hao A; Wang, Jian J; Leif Lindholm; Gilbert > Chen > Subject: [edk2-devel] [PATCH v5 1/3] MdeModulePkg: Update to support > SmBios 3.3.0 > > This commit update the revision of SMBIOS spec reported in PCDs. > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Gilbert Chen <gilbert.chen@hpe.com> > --- > MdeModulePkg/MdeModulePkg.dec | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 19935c8..6b40021 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -5,7 +5,7 @@ > # > # Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR> > # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR> > -# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > +# (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR> > # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR> > # Copyright (c) 2016, Microsoft Corporation<BR> > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -1792,7 +1792,7 @@ > > ## SMBIOS version. > # @Prompt SMBIOS version. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0302|UINT16|0x0 > 0010055 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSmbiosVersion|0x0303|UINT16|0x0 > 0010055 Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > > ## SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point Structure. > # @Prompt SMBIOS Docrev field in SMBIOS 3.0 (64-bit) Entry Point > Structure. > -- > 2.7.4 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v5 2/3] MdePkg/Include: Update to support SmBios 3.3.0 2019-10-08 8:04 [PATCH v5 0/3] Update to support SmBios 3.3.0 Abner Chang 2019-10-08 8:04 ` [PATCH v5 1/3] MdeModulePkg: " Abner Chang @ 2019-10-08 8:04 ` Abner Chang 2019-10-08 8:04 ` [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: " Abner Chang 2019-10-08 13:17 ` [edk2-devel] [PATCH v5 0/3] " Liming Gao 3 siblings, 0 replies; 9+ messages in thread From: Abner Chang @ 2019-10-08 8:04 UTC (permalink / raw) To: devel Cc: abner.chang, Michael D Kinney, Liming Gao, Leif Lindholm, Gilbert Chen Update SmBios.h to support SMBIOS 3.3.0 spec. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang <abner.chang@hpe.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <liming.gao@intel.com> Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Gilbert Chen <gilbert.chen@hpe.com> --- MdePkg/Include/IndustryStandard/SmBios.h | 76 ++++++++++++++++++++++++++++++-- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h index f3b6f18..f504cc8 100644 --- a/MdePkg/Include/IndustryStandard/SmBios.h +++ b/MdePkg/Include/IndustryStandard/SmBios.h @@ -1,8 +1,9 @@ /** @file - Industry Standard Definitions of SMBIOS Table Specification v3.2.0. + Industry Standard Definitions of SMBIOS Table Specification v3.3.0. Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR> (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR> +(C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -46,7 +47,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SMBIOS_3_0_TABLE_MAX_LENGTH 0xFFFFFFFF // -// SMBIOS type macros which is according to SMBIOS 2.7 specification. +// SMBIOS type macros which is according to SMBIOS 3.3.0 specification. // #define SMBIOS_TYPE_BIOS_INFORMATION 0 #define SMBIOS_TYPE_SYSTEM_INFORMATION 1 @@ -92,6 +93,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define SMBIOS_TYPE_ONBOARD_DEVICES_EXTENDED_INFORMATION 41 #define SMBIOS_TYPE_MANAGEMENT_CONTROLLER_HOST_INTERFACE 42 #define SMBIOS_TYPE_TPM_DEVICE 43 +#define SMBIOS_TYPE_PROCESSOR_ADDITIONAL_INFORMATION 44 /// /// Inactive type is added from SMBIOS 2.2. Reference SMBIOS 2.6, chapter 3.3.43. @@ -727,7 +729,10 @@ typedef enum { ProcessorFamilyMII = 0x012E, ProcessorFamilyWinChip = 0x0140, ProcessorFamilyDSP = 0x015E, - ProcessorFamilyVideoProcessor = 0x01F4 + ProcessorFamilyVideoProcessor = 0x01F4, + ProcessorFamilyRiscvRV32 = 0x0200, + ProcessorFamilyRiscVRV64 = 0x0201, + ProcessorFamilyRiscVRV128 = 0x0202 } PROCESSOR_FAMILY2_DATA; /// @@ -857,6 +862,19 @@ typedef struct { } PROCESSOR_FEATURE_FLAGS; typedef struct { + UINT32 ProcessorReserved1 :1; + UINT32 ProcessorUnknown :1; + UINT32 Processor64BitCapble :1; + UINT32 ProcessorMultiCore :1; + UINT32 ProcessorHardwareThread :1; + UINT32 ProcessorExecuteProtection :1; + UINT32 ProcessorEnhancedVirtulization :1; + UINT32 ProcessorPowerPerformanceCtrl :1; + UINT32 Processor128bitCapble :1; + UINT32 ProcessorReserved2 :7; +} PROCESSOR_CHARACTERISTIC_FLAGS; + +typedef struct { PROCESSOR_SIGNATURE Signature; PROCESSOR_FEATURE_FLAGS FeatureFlags; } PROCESSOR_ID_DATA; @@ -2508,6 +2526,57 @@ typedef struct { UINT8 InterfaceTypeSpecificData[4]; ///< This field has a minimum of four bytes } SMBIOS_TABLE_TYPE42; + +/// +/// Processor Specific Block - Processor Architecture Type +/// +typedef enum{ + ProcessorSpecificBlockArchTypeReserved = 0x00, + ProcessorSpecificBlockArchTypeIa32 = 0x01, + ProcessorSpecificBlockArchTypeX64 = 0x02, + ProcessorSpecificBlockArchTypeItanium = 0x03, + ProcessorSpecificBlockArchTypeAarch32 = 0x04, + ProcessorSpecificBlockArchTypeAarch64 = 0x05, + ProcessorSpecificBlockArchTypeRiscVRV32 = 0x06, + ProcessorSpecificBlockArchTypeRiscVRV64 = 0x07, + ProcessorSpecificBlockArchTypeRiscVRV128 = 0x08 +} PROCESSOR_SPECIFIC_BLOCK_ARCH_TYPE; + +/// +/// Processor Specific Block is the standard container of processor-specific data. +/// +typedef struct { + UINT8 Length; + UINT8 ProcessorArchType; + /// + /// Below followed by Processor-specific data + /// + /// +} PROCESSOR_SPECIFIC_BLOCK; + +/// +/// Processor Additional Information(Type 44). +/// +/// The information in this structure defines the processor additional information in case +/// SMBIOS type 4 is not sufficient to describe processor characteristics. +/// The SMBIOS type 44 structure has a reference handle field to link back to the related +/// SMBIOS type 4 structure. There may be multiple SMBIOS type 44 structures linked to the +/// same SMBIOS type 4 structure. For example, when cores are not identical in a processor, +/// SMBIOS type 44 structures describe different core-specific information. +/// +/// SMBIOS type 44 defines the standard header for the processor-specific block, while the +/// contents of processor-specific data are maintained by processor +/// architecture workgroups or vendors in separate documents. +/// +typedef struct { + SMBIOS_STRUCTURE Hdr; + SMBIOS_HANDLE RefHandle; ///< This field refer to associated SMBIOS type 4 + /// + /// Below followed by Processor-specific block + /// + PROCESSOR_SPECIFIC_BLOCK ProcessorSpecificBlock; +} SMBIOS_TABLE_TYPE44; + /// /// TPM Device (Type 43). /// @@ -2586,6 +2655,7 @@ typedef union { SMBIOS_TABLE_TYPE41 *Type41; SMBIOS_TABLE_TYPE42 *Type42; SMBIOS_TABLE_TYPE43 *Type43; + SMBIOS_TABLE_TYPE44 *Type44; SMBIOS_TABLE_TYPE126 *Type126; SMBIOS_TABLE_TYPE127 *Type127; UINT8 *Raw; -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 2019-10-08 8:04 [PATCH v5 0/3] Update to support SmBios 3.3.0 Abner Chang 2019-10-08 8:04 ` [PATCH v5 1/3] MdeModulePkg: " Abner Chang 2019-10-08 8:04 ` [PATCH v5 2/3] MdePkg/Include: " Abner Chang @ 2019-10-08 8:04 ` Abner Chang 2019-10-08 14:52 ` Carsey, Jaben 2019-10-09 2:57 ` [edk2-devel] " Gao, Zhichao 2019-10-08 13:17 ` [edk2-devel] [PATCH v5 0/3] " Liming Gao 3 siblings, 2 replies; 9+ messages in thread From: Abner Chang @ 2019-10-08 8:04 UTC (permalink / raw) To: devel Cc: abner.chang, Jaben Carsey, Ray Ni, Zhichao Gao, Leif Lindholm, Gilbert Chen Shell command smbiosview updates for SMBIOS 3.3.0 spec. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang <abner.chang@hpe.com> Cc: Jaben Carsey <jaben.carsey@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Gilbert Chen <gilbert.chen@hpe.com> --- .../SmbiosView/PrintInfo.c | 23 +++++++- .../SmbiosView/PrintInfo.h | 13 ++++- .../SmbiosView/QueryTable.c | 63 +++++++++++++++++++++- .../UefiShellDebug1CommandsLib.uni | 3 +- 4 files changed, 98 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index cfd7a2b..ff0c1db 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -3,7 +3,7 @@ Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR> - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR> + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( break; // + // Processor Additional Information (Type 44) + // + case 44: + PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); + PRINT_STRUCT_VALUE_H (Struct, Type44, ProcessorSpecificBlock.ProcessorArchType); + ProcessorArchitectureType (Struct->Type44->ProcessorSpecificBlock.ProcessorArchType, Option); + break; + + // // Inactive (Type 126) // case 126: @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( Print (L"Video Processor\n"); break; + case 0x200: + Print (L"RISC-V RV32\n"); + break; + + case 0x201: + Print (L"RISC-V RV64\n"); + break; + + case 0x202: + Print (L"RISC-V RV128\n"); + break; + default: ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle); } diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h index a8c32ab..22f59d6 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h @@ -2,7 +2,7 @@ Module to clarify the element info of the smbios structure. Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR> - (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( IN UINT8 Option ); +/** + Display Processor Architecture Type (Type 44). + + @param[in] Type The key of the structure. + @param[in] Option The optional information. +**/ +VOID +ProcessorArchitectureType ( + IN UINT8 Type, + IN UINT8 Option + ); #endif diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c index bfb7c3b..54e9a52 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c @@ -3,7 +3,7 @@ And give a interface of query a string out of a table. Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR> + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { { 7, L" Power/Performance Control" + }, + { + 8, + L" 128-bit Capable" } }; @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { }, }; +TABLE_ITEM ProcessorArchitectureTypesTable[] = { + { + 0, + L" Reserved " + }, + { + 1, + L" IA32 (x86) " + }, + { + 2, + L" x64 (x86-64, intel64, AMD64, EM64T) " + }, + { + 3, + L" Intel Itanium architecture " + }, + { + 4, + L" 32-bit ARM (Aarch32) " + }, + { + 5, + L" 64-bit ARM (Aarch64) " + }, + { + 6, + L" 32-bit RISC-V (RV32) " + }, + { + 7, + L" 64-bit RISC-V (RV64) " + }, + { + 8, + L" 128-bit RISC-V (RV128) " + } +}; TABLE_ITEM StructureTypeInfoTable[] = { { @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] = { L" TPM Device" }, { + 44, + L" Processor Additional Information" + }, + { 0x7E, L" Inactive" }, @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } /** + Display Processor Architecture Type (Type 44). + + @param[in] Type The key of the structure. + @param[in] Option The optional information. +**/ +VOID +ProcessorArchitectureType ( + IN UINT8 Type, + IN UINT8 Option + ) +{ + PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); +} + +/** Display the structure type information. @param[in] Key The key of the structure. diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni index 42a9295..6693be2 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni @@ -2,7 +2,7 @@ // // Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR> // (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> +// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR> // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: @@ -976,6 +976,7 @@ " 41 - Onboard Devices Extended Information\r\n" " 42 - Management Controller Host Interface\r\n" " 43 - TPM Device\r\n" +" 44 - Processor Additional Information\r\n" " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" " Do not use the '0x' prefix format for hexadecimal values.\r\n" " 3. Internal commands:\r\n" -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 2019-10-08 8:04 ` [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: " Abner Chang @ 2019-10-08 14:52 ` Carsey, Jaben 2019-10-09 2:57 ` [edk2-devel] " Gao, Zhichao 1 sibling, 0 replies; 9+ messages in thread From: Carsey, Jaben @ 2019-10-08 14:52 UTC (permalink / raw) To: Abner Chang, devel@edk2.groups.io Cc: Ni, Ray, Gao, Zhichao, Leif Lindholm, Gilbert Chen Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> Thanks -Jaben > -----Original Message----- > From: Abner Chang [mailto:abner.chang@hpe.com] > Sent: Tuesday, October 08, 2019 1:04 AM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Carsey, Jaben <jaben.carsey@intel.com>; Ni, > Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Leif > Lindholm <leif.lindholm@linaro.org>; Gilbert Chen <gilbert.chen@hpe.com> > Subject: [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to > support SmBios 3.3.0 > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Jaben Carsey <jaben.carsey@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Gilbert Chen <gilbert.chen@hpe.com> > --- > .../SmbiosView/PrintInfo.c | 23 +++++++- > .../SmbiosView/PrintInfo.h | 13 ++++- > .../SmbiosView/QueryTable.c | 63 +++++++++++++++++++++- > .../UefiShellDebug1CommandsLib.uni | 3 +- > 4 files changed, 98 insertions(+), 4 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index cfd7a2b..ff0c1db 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3,7 +3,7 @@ > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR> > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > break; > > // > + // Processor Additional Information (Type 44) > + // > + case 44: > + PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > + PRINT_STRUCT_VALUE_H (Struct, Type44, > ProcessorSpecificBlock.ProcessorArchType); > + ProcessorArchitectureType (Struct->Type44- > >ProcessorSpecificBlock.ProcessorArchType, Option); > + break; > + > + // > // Inactive (Type 126) > // > case 126: > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > Print (L"Video Processor\n"); > break; > > + case 0x200: > + Print (L"RISC-V RV32\n"); > + break; > + > + case 0x201: > + Print (L"RISC-V RV64\n"); > + break; > + > + case 0x202: > + Print (L"RISC-V RV128\n"); > + break; > + > default: > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > gShellDebug1HiiHandle); > } > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > index a8c32ab..22f59d6 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > @@ -2,7 +2,7 @@ > Module to clarify the element info of the smbios structure. > > Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR> > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( > IN UINT8 Option > ); > > +/** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ); > #endif > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index bfb7c3b..54e9a52 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > @@ -3,7 +3,7 @@ > And give a interface of query a string out of a table. > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> > - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { > { > 7, > L" Power/Performance Control" > + }, > + { > + 8, > + L" 128-bit Capable" > } > }; > > @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { > }, > }; > > +TABLE_ITEM ProcessorArchitectureTypesTable[] = { > + { > + 0, > + L" Reserved " > + }, > + { > + 1, > + L" IA32 (x86) " > + }, > + { > + 2, > + L" x64 (x86-64, intel64, AMD64, EM64T) " > + }, > + { > + 3, > + L" Intel Itanium architecture " > + }, > + { > + 4, > + L" 32-bit ARM (Aarch32) " > + }, > + { > + 5, > + L" 64-bit ARM (Aarch64) " > + }, > + { > + 6, > + L" 32-bit RISC-V (RV32) " > + }, > + { > + 7, > + L" 64-bit RISC-V (RV64) " > + }, > + { > + 8, > + L" 128-bit RISC-V (RV128) " > + } > +}; > > TABLE_ITEM StructureTypeInfoTable[] = { > { > @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] = { > L" TPM Device" > }, > { > + 44, > + L" Processor Additional Information" > + }, > + { > 0x7E, > L" Inactive" > }, > @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( > } > > /** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ) > +{ > + PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); > +} > + > +/** > Display the structure type information. > > @param[in] Key The key of the structure. > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > index 42a9295..6693be2 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > @@ -2,7 +2,7 @@ > // > // Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR> > // (C) Copyright 2013-2015 Hewlett-Packard Development Company, > L.P.<BR> > -// (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > +// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development > LP<BR> > // SPDX-License-Identifier: BSD-2-Clause-Patent > // > // Module Name: > @@ -976,6 +976,7 @@ > " 41 - Onboard Devices Extended Information\r\n" > " 42 - Management Controller Host Interface\r\n" > " 43 - TPM Device\r\n" > +" 44 - Processor Additional Information\r\n" > " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" > " Do not use the '0x' prefix format for hexadecimal values.\r\n" > " 3. Internal commands:\r\n" > -- > 2.7.4 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 2019-10-08 8:04 ` [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: " Abner Chang 2019-10-08 14:52 ` Carsey, Jaben @ 2019-10-09 2:57 ` Gao, Zhichao 2019-10-09 7:20 ` Abner Chang 1 sibling, 1 reply; 9+ messages in thread From: Gao, Zhichao @ 2019-10-09 2:57 UTC (permalink / raw) To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Carsey, Jaben, Ni, Ray, Leif Lindholm, Gilbert Chen How about change the function name from ProcessorArchitectureType to DisplayProcessorArchitectureType? And why separate the processor arch type display into two section: i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thru PRINT_STRUCT_VALUE_H, second display the value's meaning thru ProcessorArchitectureType, such as " 128-bit RISC-V (RV128)". I suggest to put them into one function DisplayProcessorArchitectureType like other functions did. Such as the blowing format: VOID DisplayMCHostInterfaceType ( IN UINT8 Key, IN UINT8 Option ) { ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), gShellDebug1HiiHandle); PRINT_INFO_OPTION (Key, Option); PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Tuesday, October 8, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Carsey, Jaben <jaben.carsey@intel.com>; Ni, > Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Leif > Lindholm <leif.lindholm@linaro.org>; Gilbert Chen <gilbert.chen@hpe.com> > Subject: [edk2-devel] [PATCH v5 3/3] > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Jaben Carsey <jaben.carsey@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Gilbert Chen <gilbert.chen@hpe.com> > --- > .../SmbiosView/PrintInfo.c | 23 +++++++- > .../SmbiosView/PrintInfo.h | 13 ++++- > .../SmbiosView/QueryTable.c | 63 +++++++++++++++++++++- > .../UefiShellDebug1CommandsLib.uni | 3 +- > 4 files changed, 98 insertions(+), 4 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index cfd7a2b..ff0c1db 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3,7 +3,7 @@ > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR> > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > break; > > // > + // Processor Additional Information (Type 44) // case 44: > + PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > + PRINT_STRUCT_VALUE_H (Struct, Type44, > ProcessorSpecificBlock.ProcessorArchType); > + ProcessorArchitectureType (Struct->Type44- > >ProcessorSpecificBlock.ProcessorArchType, Option); > + break; > + > + // > // Inactive (Type 126) > // > case 126: > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > Print (L"Video Processor\n"); > break; > > + case 0x200: > + Print (L"RISC-V RV32\n"); > + break; > + > + case 0x201: > + Print (L"RISC-V RV64\n"); > + break; > + > + case 0x202: > + Print (L"RISC-V RV128\n"); > + break; > + > default: > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > gShellDebug1HiiHandle); > } > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > index a8c32ab..22f59d6 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > @@ -2,7 +2,7 @@ > Module to clarify the element info of the smbios structure. > > Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR> > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development > + LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( > IN UINT8 Option > ); > > +/** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ); > #endif > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index bfb7c3b..54e9a52 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -3,7 +3,7 @@ > And give a interface of query a string out of a table. > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> > - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { > { > 7, > L" Power/Performance Control" > + }, > + { > + 8, > + L" 128-bit Capable" > } > }; > > @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { > }, > }; > > +TABLE_ITEM ProcessorArchitectureTypesTable[] = { > + { > + 0, > + L" Reserved " > + }, > + { > + 1, > + L" IA32 (x86) " > + }, > + { > + 2, > + L" x64 (x86-64, intel64, AMD64, EM64T) " > + }, > + { > + 3, > + L" Intel Itanium architecture " > + }, > + { > + 4, > + L" 32-bit ARM (Aarch32) " > + }, > + { > + 5, > + L" 64-bit ARM (Aarch64) " > + }, > + { > + 6, > + L" 32-bit RISC-V (RV32) " > + }, > + { > + 7, > + L" 64-bit RISC-V (RV64) " > + }, > + { > + 8, > + L" 128-bit RISC-V (RV128) " > + } > +}; > > TABLE_ITEM StructureTypeInfoTable[] = { > { > @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] = { > L" TPM Device" > }, > { > + 44, > + L" Processor Additional Information" > + }, > + { > 0x7E, > L" Inactive" > }, > @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } > > /** > + Display Processor Architecture Type (Type 44). > + > + @param[in] Type The key of the structure. > + @param[in] Option The optional information. > +**/ > +VOID > +ProcessorArchitectureType ( > + IN UINT8 Type, > + IN UINT8 Option > + ) > +{ > + PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); } > + > +/** > Display the structure type information. > > @param[in] Key The key of the structure. > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > index 42a9295..6693be2 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > d > +++ sLib.uni > @@ -2,7 +2,7 @@ > // > // Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR> // (C) > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.<BR> -// > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > +// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development > +LP<BR> > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > @@ -976,6 +976,7 @@ > " 41 - Onboard Devices Extended Information\r\n" > " 42 - Management Controller Host Interface\r\n" > " 43 - TPM Device\r\n" > +" 44 - Processor Additional Information\r\n" > " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" > " Do not use the '0x' prefix format for hexadecimal values.\r\n" > " 3. Internal commands:\r\n" > -- > 2.7.4 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 2019-10-09 2:57 ` [edk2-devel] " Gao, Zhichao @ 2019-10-09 7:20 ` Abner Chang 0 siblings, 0 replies; 9+ messages in thread From: Abner Chang @ 2019-10-09 7:20 UTC (permalink / raw) To: Gao, Zhichao, devel@edk2.groups.io Cc: Carsey, Jaben, Ni, Ray, Leif Lindholm, Chen, Gilbert HI Zhichao, I revise it as your suggestion. [PATCH v6] for the third patch (rebased) was just sent. Thanks Abner > -----Original Message----- > From: Gao, Zhichao [mailto:zhichao.gao@intel.com] > Sent: Wednesday, October 9, 2019 10:58 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.chang@hpe.com> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > Leif Lindholm <leif.lindholm@linaro.org>; Chen, Gilbert > <gilbert.chen@hpe.com> > Subject: RE: [edk2-devel] [PATCH v5 3/3] > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > How about change the function name from ProcessorArchitectureType to > DisplayProcessorArchitectureType? > > And why separate the processor arch type display into two section: > i.e. first display " ProcessorSpecificBlock.ProcessorArchType: 0xXX" thru > PRINT_STRUCT_VALUE_H, second display the value's meaning thru > ProcessorArchitectureType, such as " 128-bit RISC-V (RV128)". > I suggest to put them into one function DisplayProcessorArchitectureType > like other functions did. Such as the blowing format: > VOID > DisplayMCHostInterfaceType ( > IN UINT8 Key, > IN UINT8 Option > ) > { > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > (STR_SMBIOSVIEW_QUERYTABLE_MC_HOST_INTERFACE_TYPE), > gShellDebug1HiiHandle); > PRINT_INFO_OPTION (Key, Option); > PRINT_TABLE_ITEM (MCHostInterfaceTypeTable, Key); } > > Thanks, > Zhichao > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Tuesday, October 8, 2019 4:04 PM > > To: devel@edk2.groups.io > > Cc: abner.chang@hpe.com; Carsey, Jaben <jaben.carsey@intel.com>; Ni, > > Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Leif > > Lindholm <leif.lindholm@linaro.org>; Gilbert Chen > > <gilbert.chen@hpe.com> > > Subject: [edk2-devel] [PATCH v5 3/3] > > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > > > Shell command smbiosview updates for SMBIOS 3.3.0 spec. > > > > Bugzilla link, > > INVALID URI REMOVED > > e.org_show-5Fbug.cgi-3Fid- > 3D2202&d=DwIFAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_ > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=iZPRGBE2YqYcm2VO > KgWvwrtGD > > P3Gn- > 0WwIs5VAkpqao&s=SidItX73peVBmSm4Ws1A5kr8hOtp2MBpWKg4zdb4Jeg& > e= > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > > > Cc: Jaben Carsey <jaben.carsey@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Zhichao Gao <zhichao.gao@intel.com> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Cc: Gilbert Chen <gilbert.chen@hpe.com> > > --- > > .../SmbiosView/PrintInfo.c | 23 +++++++- > > .../SmbiosView/PrintInfo.h | 13 ++++- > > .../SmbiosView/QueryTable.c | 63 +++++++++++++++++++++- > > .../UefiShellDebug1CommandsLib.uni | 3 +- > > 4 files changed, 98 insertions(+), 4 deletions(-) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > index cfd7a2b..ff0c1db 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > > @@ -3,7 +3,7 @@ > > > > Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.<BR> > > (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR> > > - (C) Copyright 2015-2017 Hewlett Packard Enterprise Development > > LP<BR> > > + (C) Copyright 2015-2019 Hewlett Packard Enterprise Development > > + LP<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -1169,6 +1169,15 @@ SmbiosPrintStructure ( > > break; > > > > // > > + // Processor Additional Information (Type 44) // case 44: > > + PRINT_STRUCT_VALUE_H (Struct, Type44, RefHandle); > > + PRINT_STRUCT_VALUE_H (Struct, Type44, > > ProcessorSpecificBlock.ProcessorArchType); > > + ProcessorArchitectureType (Struct->Type44- > > >ProcessorSpecificBlock.ProcessorArchType, Option); > > + break; > > + > > + // > > // Inactive (Type 126) > > // > > case 126: > > @@ -2350,6 +2359,18 @@ DisplayProcessorFamily2 ( > > Print (L"Video Processor\n"); > > break; > > > > + case 0x200: > > + Print (L"RISC-V RV32\n"); > > + break; > > + > > + case 0x201: > > + Print (L"RISC-V RV64\n"); > > + break; > > + > > + case 0x202: > > + Print (L"RISC-V RV128\n"); > > + break; > > + > > default: > > ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN > > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), > > gShellDebug1HiiHandle); > > } > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > index a8c32ab..22f59d6 100644 > > --- > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > +++ > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.h > > @@ -2,7 +2,7 @@ > > Module to clarify the element info of the smbios structure. > > > > Copyright (c) 2005 - 2015, Intel Corporation. All rights > > reserved.<BR> > > - (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR> > > + (C) Copyright 2017 - 2019 Hewlett Packard Enterprise Development > > + LP<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -427,4 +427,15 @@ DisplayTpmDeviceCharacteristics ( > > IN UINT8 Option > > ); > > > > +/** > > + Display Processor Architecture Type (Type 44). > > + > > + @param[in] Type The key of the structure. > > + @param[in] Option The optional information. > > +**/ > > +VOID > > +ProcessorArchitectureType ( > > + IN UINT8 Type, > > + IN UINT8 Option > > + ); > > #endif > > diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > index bfb7c3b..54e9a52 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > c > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > > +++ c > > @@ -3,7 +3,7 @@ > > And give a interface of query a string out of a table. > > > > Copyright (c) 2005 - 2018, Intel Corporation. All rights > > reserved.<BR> > > - (C) Copyright 2016-2017 Hewlett Packard Enterprise Development > > LP<BR> > > + (C) Copyright 2016-2019 Hewlett Packard Enterprise Development > > + LP<BR> > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -620,6 +620,10 @@ TABLE_ITEM ProcessorCharacteristicsTable[] = { > > { > > 7, > > L" Power/Performance Control" > > + }, > > + { > > + 8, > > + L" 128-bit Capable" > > } > > }; > > > > @@ -3268,6 +3272,44 @@ TABLE_ITEM MCHostInterfaceTypeTable[] = { > > }, > > }; > > > > +TABLE_ITEM ProcessorArchitectureTypesTable[] = { > > + { > > + 0, > > + L" Reserved " > > + }, > > + { > > + 1, > > + L" IA32 (x86) " > > + }, > > + { > > + 2, > > + L" x64 (x86-64, intel64, AMD64, EM64T) " > > + }, > > + { > > + 3, > > + L" Intel Itanium architecture " > > + }, > > + { > > + 4, > > + L" 32-bit ARM (Aarch32) " > > + }, > > + { > > + 5, > > + L" 64-bit ARM (Aarch64) " > > + }, > > + { > > + 6, > > + L" 32-bit RISC-V (RV32) " > > + }, > > + { > > + 7, > > + L" 64-bit RISC-V (RV64) " > > + }, > > + { > > + 8, > > + L" 128-bit RISC-V (RV128) " > > + } > > +}; > > > > TABLE_ITEM StructureTypeInfoTable[] = { > > { > > @@ -3447,6 +3489,10 @@ TABLE_ITEM StructureTypeInfoTable[] = { > > L" TPM Device" > > }, > > { > > + 44, > > + L" Processor Additional Information" > > + }, > > + { > > 0x7E, > > L" Inactive" > > }, > > @@ -4697,6 +4743,21 @@ DisplayMCHostInterfaceType ( } > > > > /** > > + Display Processor Architecture Type (Type 44). > > + > > + @param[in] Type The key of the structure. > > + @param[in] Option The optional information. > > +**/ > > +VOID > > +ProcessorArchitectureType ( > > + IN UINT8 Type, > > + IN UINT8 Option > > + ) > > +{ > > + PRINT_TABLE_ITEM (ProcessorArchitectureTypesTable, Type); } > > + > > +/** > > Display the structure type information. > > > > @param[in] Key The key of the structure. > > diff --git > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > index 42a9295..6693be2 100644 > > --- > > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > dsLib.uni > > +++ > > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > > d > > +++ sLib.uni > > @@ -2,7 +2,7 @@ > > // > > // Copyright (c) 2010 - 2018, Intel Corporation. All rights > > reserved.<BR> // (C) Copyright 2013-2015 Hewlett-Packard Development > > Company, L.P.<BR> -// > > (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR> > > +// (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development > > +LP<BR> > > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module Name: > > @@ -976,6 +976,7 @@ > > " 41 - Onboard Devices Extended Information\r\n" > > " 42 - Management Controller Host Interface\r\n" > > " 43 - TPM Device\r\n" > > +" 44 - Processor Additional Information\r\n" > > " 2. Enter the SmbiosHandle parameter in hexadecimal format.\r\n" > > " Do not use the '0x' prefix format for hexadecimal values.\r\n" > > " 3. Internal commands:\r\n" > > -- > > 2.7.4 > > > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0 2019-10-08 8:04 [PATCH v5 0/3] Update to support SmBios 3.3.0 Abner Chang ` (2 preceding siblings ...) 2019-10-08 8:04 ` [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: " Abner Chang @ 2019-10-08 13:17 ` Liming Gao 3 siblings, 0 replies; 9+ messages in thread From: Liming Gao @ 2019-10-08 13:17 UTC (permalink / raw) To: devel@edk2.groups.io, abner.chang@hpe.com Reviewed-by: Liming Gao <liming.gao@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang > Sent: Tuesday, October 8, 2019 4:04 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com > Subject: [edk2-devel] [PATCH v5 0/3] Update to support SmBios 3.3.0 > > Codes changes for SMBIOS spec 3.3.0 (Already public on DMTF). > > Bugzilla link, > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > Abner Chang (3): > MdeModulePkg: Update to support SmBios 3.3.0 > MdePkg/Include: Update to support SmBios 3.3.0 > ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0 > > MdeModulePkg/MdeModulePkg.dec | 4 +- > MdePkg/Include/IndustryStandard/SmBios.h | 76 +++++++++++++++++++++- > .../SmbiosView/PrintInfo.c | 23 ++++++- > .../SmbiosView/PrintInfo.h | 13 +++- > .../SmbiosView/QueryTable.c | 63 +++++++++++++++++- > .../UefiShellDebug1CommandsLib.uni | 3 +- > 6 files changed, 173 insertions(+), 9 deletions(-) > > -- > 2.7.4 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-17 2:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-10-08 8:04 [PATCH v5 0/3] Update to support SmBios 3.3.0 Abner Chang 2019-10-08 8:04 ` [PATCH v5 1/3] MdeModulePkg: " Abner Chang 2019-10-17 2:46 ` [edk2-devel] " Wu, Hao A 2019-10-08 8:04 ` [PATCH v5 2/3] MdePkg/Include: " Abner Chang 2019-10-08 8:04 ` [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: " Abner Chang 2019-10-08 14:52 ` Carsey, Jaben 2019-10-09 2:57 ` [edk2-devel] " Gao, Zhichao 2019-10-09 7:20 ` Abner Chang 2019-10-08 13:17 ` [edk2-devel] [PATCH v5 0/3] " Liming Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox