[PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

[PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

The NOOPT build target is used for host-based unit tests. This
change adds the NOOPT target for all packages to ensure that tests
are executed if present.

If the host-based DSC is not specified in the packages CI YAML file,
the host-based compiler plugin will be reported as a skipped test.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 69e4c50afdbb..0e4ad019bf03 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -35,10 +35,10 @@ jobs:
         Build.Targets: 'RELEASE,NO-TARGET'
       TARGET_NETWORK:
         Build.Pkgs: 'NetworkPkg,RedfishPkg'
-        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_OTHER:
         Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
-        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_FMP_FAT_TEST:
         Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
@@ -47,15 +47,15 @@ jobs:
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
-        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_UEFIPAYLOAD:
         Build.Pkgs: 'UefiPayloadPkg'
-        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
         Build.Pkgs: 'ArmVirtPkg,EmulatorPkg,OvmfPkg'
-        Build.Targets: 'NO-TARGET'
+        Build.Targets: 'NO-TARGET,NOOPT'
 
   workspace:
     clean: all
-- 
2.28.0.windows.1

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

[Sean]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>

[-- Attachment #2: Type: text/html, Size: 60 bytes --]

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

[Michael Kubacki]

PR with R-b tag is ready to push:

https://github.com/tianocore/edk2/pull/2818

On 4/21/2022 5:07 PM, Sean wrote:
> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
> 

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

[Michael Kubacki]

Here's a PR with this change that has an additional temp commit to 
trigger builds:

https://github.com/tianocore/edk2/pull/2806

Ignore the patch check failure, that is related to the temp commit.

Regards,
Michael

On 4/19/2022 9:43 PM, Michael Kubacki wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> The NOOPT build target is used for host-based unit tests. This
> change adds the NOOPT target for all packages to ensure that tests
> are executed if present.
> 
> If the host-based DSC is not specified in the packages CI YAML file,
> the host-based compiler plugin will be reported as a skipped test.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 69e4c50afdbb..0e4ad019bf03 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -35,10 +35,10 @@ jobs:
>           Build.Targets: 'RELEASE,NO-TARGET'
>         TARGET_NETWORK:
>           Build.Pkgs: 'NetworkPkg,RedfishPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_OTHER:
>           Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_FMP_FAT_TEST:
>           Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTablesPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
> @@ -47,15 +47,15 @@ jobs:
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_SECURITY:
>           Build.Pkgs: 'SecurityPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_UEFIPAYLOAD:
>           Build.Pkgs: 'UefiPayloadPkg'
> -        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
>         TARGET_PLATFORMS:
>           # For Platforms only check code. Leave it to Platform CI
>           # to build them.
>           Build.Pkgs: 'ArmVirtPkg,EmulatorPkg,OvmfPkg'
> -        Build.Targets: 'NO-TARGET'
> +        Build.Targets: 'NO-TARGET,NOOPT'
>   
>     workspace:
>       clean: all