From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: eric.xing@amd.com,devel@edk2.groups.io
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries
Date: Thu, 28 Sep 2023 08:22:53 -0700 [thread overview]
Message-ID: <15790.1695914573221503552@groups.io> (raw)
In-Reply-To: <20230928143054.4039-2-eric.xing@amd.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
Hi Eric,
As the file naming is defined in the edk2 C coding standard, the AMD terminology used in the file name should follow edk2 C coding standard. Such as APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could you please review all of the files in this patch?
Thanks
Abner
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109151): https://edk2.groups.io/g/devel/message/109151
Mute This Topic: https://groups.io/mt/101638925/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1175 bytes --]
next prev parent reply other threads:[~2023-09-28 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 14:30 [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh eric.xing via groups.io
2023-09-28 14:30 ` [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries eric.xing via groups.io
2023-09-28 15:22 ` Chang, Abner via groups.io [this message]
2023-09-28 16:18 ` Xing, Eric via groups.io
2023-09-28 15:18 ` [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh Chang, Abner via groups.io
2023-09-28 16:20 ` Xing, Eric via groups.io
2023-09-28 16:15 ` Leif Lindholm
2023-09-28 17:13 ` Xing, Eric via groups.io
2023-09-28 17:39 ` Leif Lindholm
2023-09-29 9:09 ` Chang, Abner via groups.io
2023-09-29 10:48 ` Leif Lindholm
2023-09-29 14:52 ` Chang, Abner via groups.io
2023-09-29 15:30 ` Leif Lindholm
2023-09-29 16:17 ` Chang, Abner via groups.io
2023-09-30 17:35 ` Zhai, MingXin (Duke) via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15790.1695914573221503552@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox