From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 25720941A76 for ; Thu, 28 Sep 2023 15:22:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BM/t9eoOxoqC0WO3dfndP7jtJ5z3n9EcG87PQfQrE5w=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695914573; v=1; b=PRexiq9Kgw+sfB5qTJ7dYblcnE6Vn5kFN+EFQurwNlbt6A04WPHlXZX+BtjeX5vly3SP3iNb oYFurjEbGSyogNmeNNl3CHXRRJocxVa9DNriFLIeeAsbIPbH5EwUyBmLZtFJc/WYC3uUdHKBIag YWUz/D9YP6LDUvrip7pF0acs= X-Received: by 127.0.0.2 with SMTP id g0I8YY7687511xy3i5zwcIXi; Thu, 28 Sep 2023 08:22:53 -0700 Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries To: eric.xing@amd.com,devel@edk2.groups.io From: "Chang, Abner via groups.io" X-Originating-Location: US (161.69.54.47) X-Originating-Platform: Windows Chrome 116 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 28 Sep 2023 08:22:53 -0700 References: <20230928143054.4039-2-eric.xing@amd.com> In-Reply-To: <20230928143054.4039-2-eric.xing@amd.com> Message-ID: <15790.1695914573221503552@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7IU5ohYnouX32PCYwNQAJv9Px7686176AA= Content-Type: multipart/alternative; boundary="yPj4LlDt7mm8V9kO15Ph" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PRexiq9K; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --yPj4LlDt7mm8V9kO15Ph Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Eric, As the file naming is defined in the edk2 C coding standard, the AMD termin= ology used in the file name should follow edk2 C coding standard. Such as A= PCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei. Could you please review all of the files in this patch? Thanks Abner -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109151): https://edk2.groups.io/g/devel/message/109151 Mute This Topic: https://groups.io/mt/101638925/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --yPj4LlDt7mm8V9kO15Ph Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi Eric,
As the file naming is defined in the edk2 C coding standar= d, the AMD terminology used in the file name should follow edk2 C coding st= andard. Such as APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could y= ou please review all of the files in this patch?
Thanks
Abner

 

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#109151) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--yPj4LlDt7mm8V9kO15Ph--