From: Leo Duran <leo.duran@amd.com>
To: devel@edk2.groups.io
Cc: Leo Duran <leo.duran@amd.com>
Subject: [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib
Date: Tue, 25 Feb 2020 13:39:24 -0600 [thread overview]
Message-ID: <1582659566-9893-1-git-send-email-leo.duran@amd.com> (raw)
This patch set fixes an issue introduced recently in MpInitLib, where we read
a PlatformId MSR that is not implemented on AMD processors.
The proposed solution is to export the StandardSignatureIsAuthenticAMD function
from LocalApicLib, so that it may be used by MpInitLib or any other module that
consumes LocalApicLib.
Alternatively, we considered creating a new library, but opted against it as
that would incur quite a bit of churning across modules that consume MpInitLib.
BTW, reading the PlatformId MSR was already being done by MicrocodeDetect(),
but it never affected AMD-based platforms as the flow never gets that far, since
the Detect routine bails out early when it finds the size of the patch is zero.
Leo Duran (2):
UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD
function
UefiCpuPkg: MpInitLib: Exclude code no pertinent to AMD processors.
UefiCpuPkg/Include/Library/LocalApicLib.h | 15 +++++++
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 47 +++++++++++-----------
.../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 47 +++++++++++-----------
UefiCpuPkg/Library/MpInitLib/Microcode.c | 17 +++++++-
UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++-
5 files changed, 87 insertions(+), 50 deletions(-)
--
2.7.4
next reply other threads:[~2020-02-25 19:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 19:39 Leo Duran [this message]
2020-02-25 19:39 ` [PATCH 1/2] UefiCpuPkg: LocalApicLib: Export StandardSignatureIsAuthenticAMD function Leo Duran
2020-02-26 1:13 ` Dong, Eric
2020-02-26 2:41 ` Duran, Leo
2020-02-26 5:05 ` Dong, Eric
2020-02-26 10:13 ` [edk2-devel] " Laszlo Ersek
2020-02-26 15:03 ` Duran, Leo
2020-02-26 16:19 ` Laszlo Ersek
2020-02-26 15:59 ` Duran, Leo
2020-02-25 19:39 ` [PATCH 2/2] UefiCpuPkg: MpInitLib: Exclude code no pertinent to AMD processors Leo Duran
2020-02-26 7:45 ` Ni, Ray
2020-02-26 7:56 ` Siyuan, Fu
2020-02-26 0:54 ` [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib Laszlo Ersek
2020-02-26 7:57 ` Ni, Ray
2020-02-26 8:56 ` Liming Gao
2020-02-26 15:11 ` Duran, Leo
2020-02-26 16:24 ` Laszlo Ersek
2020-02-26 16:35 ` Duran, Leo
2020-02-26 15:25 ` Duran, Leo
2020-02-26 15:46 ` Duran, Leo
2020-02-26 16:20 ` Laszlo Ersek
2020-02-26 16:39 ` Duran, Leo
2020-02-26 16:46 ` Duran, Leo
2020-02-26 17:45 ` Laszlo Ersek
2020-02-26 17:51 ` Duran, Leo
2020-02-27 5:55 ` Ni, Ray
2020-02-27 18:17 ` Duran, Leo
2020-02-28 6:47 ` Ni, Ray
2020-02-28 16:38 ` Duran, Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582659566-9893-1-git-send-email-leo.duran@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox