public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Marcin Wojtas" <mw@semihalf.com>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, mw@semihalf.com,
	jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com
Subject: [edk2-platforms: PATCH v2 3/3] Marvell/Library: UtmiLib: Fix USB mux configuration
Date: Fri, 15 May 2020 23:05:58 +0200	[thread overview]
Message-ID: <1589576758-28501-4-git-send-email-mw@semihalf.com> (raw)
In-Reply-To: <1589576758-28501-1-git-send-email-mw@semihalf.com>

If UTMI connected to USB Device, the MUX must be configured
prior to the PHY init. Add missing register update in the
relevant code.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
 Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
index ceea74a..8ea666b 100644
--- a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
+++ b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c
@@ -79,6 +79,7 @@ UtmiPhyPowerDown (
   } else {
     Data = 0x0 << UTMI_USB_CFG_DEVICE_EN_OFFSET;
   }
+  RegSet (UsbCfgAddr, Data, Mask);
 
   /* Set Test suspendm mode */
   Mask = UTMI_CTRL_STATUS0_SUSPENDM_MASK;
-- 
2.7.4


      parent reply	other threads:[~2020-05-15 21:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 21:05 [edk2-platforms: PATCH v2 0/3] Marvell UTMI fixes Marcin Wojtas
2020-05-15 21:05 ` [edk2-platforms: PATCH v2 1/3] Marvell/Library: UtmiLib: update USB2.0 analog settings Marcin Wojtas
2020-05-18 17:12   ` Leif Lindholm
2020-05-18 18:11     ` Marcin Wojtas
2020-05-18 18:16       ` Leif Lindholm
2020-05-18 23:09         ` Marcin Wojtas
2020-05-19 15:26           ` Leif Lindholm
2020-05-15 21:05 ` [edk2-platforms: PATCH v2 2/3] Marvell/Library: UtmiLib: Fix pll initialization for the second port Marcin Wojtas
2020-05-15 21:05 ` Marcin Wojtas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589576758-28501-4-git-send-email-mw@semihalf.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox