From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by mx.groups.io with SMTP id smtpd.web10.844.1589576794739759909 for ; Fri, 15 May 2020 14:06:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=ztwWZ7QP; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.167.66, mailfrom: mw@semihalf.com) Received: by mail-lf1-f66.google.com with SMTP id 82so2995799lfh.2 for ; Fri, 15 May 2020 14:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rrcjw6Kof1ZpOMFZc81d93azpnn6l+fNxutedw3uD2U=; b=ztwWZ7QPbznrnpPrRs+USTfgN+ULO2hxkKa6BteNQtcvaDMyj9RT08S+59vaEtObG2 y51NLVF9EfbIkcWPfIAQ3lbHOkMr+tVO/2ytB+zlRIvqZEhYo9yyGDOtFhhp1+rlukRk rdhBPZjGrjs6TDq2L/tGmCu/hd4uPrjN9RsSHYmSashIt7rnJgsaFzXSerlJR5OCcKmc 9NP7CO5vNErFPgI+UvX2Cs4lU4L4yVYF1/FKFxOLUiO7qb7T2+fs5DBQ2+lb2178/4eb 6syMUK/bxyj+6Ga3rbJKhNduYnXrzEwm87V7kYSbKP32O5Y/En4x4JYrRbhYyHyL8C3A vAnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rrcjw6Kof1ZpOMFZc81d93azpnn6l+fNxutedw3uD2U=; b=tOX+ZgNcOgxkbqPaO/p4I1cSRt2c0KNO/DAyZMJ9EbJIdIaQ463fpnyDwpr5f4ZLE0 oqzh2+TVnyU6Gw9hm4zv25q0N4REWItBWhnZjAwfCVWmKt6i0dRI4Av/2k5sFf0caIIu PBn1dnVXeLqvvyXKJd0o5bh5ksJlQ66pySKnmhwhXrEcrw7RzyXkMbBVv//y02ttVuPF rELBrPwcN5spbUp8GIfXp8Q+fbbe1Hp/SI0mqJqo4uKX9rf4toq71vQaGEzetsY48D0B kdMyh7kdYqc6SGFUil/oLWrQ2Op8CyAxVgWuSH2i6gYRQ+HGSXye6dx1TQDlasb5+X// 6lGw== X-Gm-Message-State: AOAM5339uGmMEBItFn5psWKW1gT1O1KNdUcFc1pHRElcvljcF7T2fQK9 5nnFz4lTyjlvqH3O0m7yLgwvJlTSy7k= X-Google-Smtp-Source: ABdhPJxlTG6CQqntxTELaJl7Ev7kuY5gBC5WFZlnWGMcdrGdsWQOc5EWPECw/gvNlshVPfatuYca6w== X-Received: by 2002:a19:7104:: with SMTP id m4mr3619277lfc.75.1589576792469; Fri, 15 May 2020 14:06:32 -0700 (PDT) Return-Path: Received: from gilgamesh.semihalf.com (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id z64sm1924818lfa.50.2020.05.15.14.06.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 May 2020 14:06:31 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Subject: [edk2-platforms: PATCH v2 3/3] Marvell/Library: UtmiLib: Fix USB mux configuration Date: Fri, 15 May 2020 23:05:58 +0200 Message-Id: <1589576758-28501-4-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1589576758-28501-1-git-send-email-mw@semihalf.com> References: <1589576758-28501-1-git-send-email-mw@semihalf.com> If UTMI connected to USB Device, the MUX must be configured prior to the PHY init. Add missing register update in the relevant code. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c index ceea74a..8ea666b 100644 --- a/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c +++ b/Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c @@ -79,6 +79,7 @@ UtmiPhyPowerDown ( } else { Data = 0x0 << UTMI_USB_CFG_DEVICE_EN_OFFSET; } + RegSet (UsbCfgAddr, Data, Mask); /* Set Test suspendm mode */ Mask = UTMI_CTRL_STATUS0_SUSPENDM_MASK; -- 2.7.4