public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, afish@apple.com,
	Rebecca Cran <quic_rcran@quicinc.com>
Subject: Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout
Date: Tue, 29 Nov 2022 16:05:36 -0700	[thread overview]
Message-ID: <1592010b-700d-865d-41be-a2100f8203f2@bsdio.com> (raw)
In-Reply-To: <FCA9033F-807B-4C45-B419-1F45E8647F10@apple.com>

On 11/29/22 13:51, Andrew Fish via groups.io wrote:

>> On Nov 29, 2022, at 11:47 AM, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>>
>> On 11/29/22 12:43, Andrew Fish via groups.io wrote:
>>>> On Nov 29, 2022, at 11:12 AM, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>>>>
>>>> I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One problem I've run into is that since we poll for bulk requests, most of the time they will timeout - and currently both EHCI and XHCI drivers log errors when that happens, which results in log spam and makes interacting with the system very difficult (e.g. using UiApp).
>>>>
>>>> I was wondering if we might consider adding some mechanism to omit those messages if the user desires, perhaps on a per-build basis?
>>>>
>>> Are those DEBUG prints or report status code?
>> They're DEBUG prints.
> If they happen a lot maybe they should be DEBUG_VERBOSE?

I think the UsbNetworkPkg drivers are probably unique in that the network stack polls for packets every 10ms, which will cause them to issue a bulk transfer request with a timeout of 1ms.

So as long as there aren't packets being sent, the timeout messages will occur continuously. Putting them under DEBUG_VERBOSE would certainly work.

-- 

Rebecca Cran


  reply	other threads:[~2022-11-29 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29 19:12 USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout Rebecca Cran
2022-11-29 19:43 ` [edk2-devel] " Andrew Fish
2022-11-29 19:47   ` Rebecca Cran
2022-11-29 20:51     ` Andrew Fish
2022-11-29 23:05       ` Rebecca Cran [this message]
2022-11-30  7:48         ` Chang, Abner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592010b-700d-865d-41be-a2100f8203f2@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox