* [PATCH EDK2 v1 0/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
@ 2020-09-11 1:49 wenyi,xie
2020-09-11 1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
0 siblings, 1 reply; 5+ messages in thread
From: wenyi,xie @ 2020-09-11 1:49 UTC (permalink / raw)
To: devel, jordan.l.justen, afish, ray.ni; +Cc: lersek, songdongkuang, xiewenyi2
Main Changes:
Change DEC_VERSION to DEC_SPECIFICATION
Wenyi Xie (1):
EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
EmulatorPkg/EmulatorPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
2020-09-11 1:49 [PATCH EDK2 v1 0/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION wenyi,xie
@ 2020-09-11 1:49 ` wenyi,xie
2020-09-11 2:18 ` Ni, Ray
2020-09-11 7:03 ` Laszlo Ersek
0 siblings, 2 replies; 5+ messages in thread
From: wenyi,xie @ 2020-09-11 1:49 UTC (permalink / raw)
To: devel, jordan.l.justen, afish, ray.ni; +Cc: lersek, songdongkuang, xiewenyi2
edk2 DEC specification document only knows about DEC_SPECIFICATION,
so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
correct.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
---
EmulatorPkg/EmulatorPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
index 90a8d2a8681a..064f963c72c6 100644
--- a/EmulatorPkg/EmulatorPkg.dec
+++ b/EmulatorPkg/EmulatorPkg.dec
@@ -11,7 +11,7 @@
##
[Defines]
- DEC_VERSION = 0x00010005
+ DEC_SPECIFICATION = 0x00010005
PACKAGE_NAME = EmulatorPkg
PACKAGE_GUID = 36E48BD7-7D92-5A47-A2CD-513F072E3300
PACKAGE_VERSION = 0.1
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
2020-09-11 1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
@ 2020-09-11 2:18 ` Ni, Ray
2020-09-14 2:57 ` 回复: [edk2-devel] " gaoliming
2020-09-11 7:03 ` Laszlo Ersek
1 sibling, 1 reply; 5+ messages in thread
From: Ni, Ray @ 2020-09-11 2:18 UTC (permalink / raw)
To: Wenyi Xie, devel@edk2.groups.io, Justen, Jordan L,
afish@apple.com, gaoliming
Cc: lersek@redhat.com, songdongkuang@huawei.com
+ Liming who is expert on the EDK II Build spec.
> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Friday, September 11, 2020 9:49 AM
> To: devel@edk2.groups.io; Justen, Jordan L <jordan.l.justen@intel.com>; afish@apple.com; Ni, Ray <ray.ni@intel.com>
> Cc: lersek@redhat.com; songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
>
> edk2 DEC specification document only knows about DEC_SPECIFICATION,
> so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> correct.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> EmulatorPkg/EmulatorPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> index 90a8d2a8681a..064f963c72c6 100644
> --- a/EmulatorPkg/EmulatorPkg.dec
> +++ b/EmulatorPkg/EmulatorPkg.dec
> @@ -11,7 +11,7 @@
> ##
>
> [Defines]
> - DEC_VERSION = 0x00010005
> + DEC_SPECIFICATION = 0x00010005
> PACKAGE_NAME = EmulatorPkg
> PACKAGE_GUID = 36E48BD7-7D92-5A47-A2CD-513F072E3300
> PACKAGE_VERSION = 0.1
> --
> 2.20.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
2020-09-11 1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2020-09-11 2:18 ` Ni, Ray
@ 2020-09-11 7:03 ` Laszlo Ersek
1 sibling, 0 replies; 5+ messages in thread
From: Laszlo Ersek @ 2020-09-11 7:03 UTC (permalink / raw)
To: Wenyi Xie, devel, jordan.l.justen, afish, ray.ni; +Cc: songdongkuang
On 09/11/20 03:49, Wenyi Xie wrote:
> edk2 DEC specification document only knows about DEC_SPECIFICATION,
> so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> correct.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
> EmulatorPkg/EmulatorPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> index 90a8d2a8681a..064f963c72c6 100644
> --- a/EmulatorPkg/EmulatorPkg.dec
> +++ b/EmulatorPkg/EmulatorPkg.dec
> @@ -11,7 +11,7 @@
> ##
>
> [Defines]
> - DEC_VERSION = 0x00010005
> + DEC_SPECIFICATION = 0x00010005
> PACKAGE_NAME = EmulatorPkg
> PACKAGE_GUID = 36E48BD7-7D92-5A47-A2CD-513F072E3300
> PACKAGE_VERSION = 0.1
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* 回复: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION
2020-09-11 2:18 ` Ni, Ray
@ 2020-09-14 2:57 ` gaoliming
0 siblings, 0 replies; 5+ messages in thread
From: gaoliming @ 2020-09-14 2:57 UTC (permalink / raw)
To: devel, ray.ni, 'Wenyi Xie', 'Justen, Jordan L',
afish
Cc: lersek, songdongkuang
Yes. This change is correct. Reviewed-by: Liming Gao <gaoliming@byosoft.com.
cn>
> -----邮件原件-----
> 发件人: bounce+27952+65182+4905953+8761045@groups.io
> <bounce+27952+65182+4905953+8761045@groups.io> 代表 Ni, Ray
> 发送时间: 2020年9月11日 10:19
> 收件人: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io; Justen,
> Jordan L <jordan.l.justen@intel.com>; afish@apple.com; gaoliming
> <gaoliming@byosoft.com.cn>
> 抄送: lersek@redhat.com; songdongkuang@huawei.com
> 主题: Re: [edk2-devel] [PATCH EDK2 v1 1/1] EmulatorPkg:Change
> DEC_VERSION to DEC_SPECIFICATION
>
> + Liming who is expert on the EDK II Build spec.
>
> > -----Original Message-----
> > From: Wenyi Xie <xiewenyi2@huawei.com>
> > Sent: Friday, September 11, 2020 9:49 AM
> > To: devel@edk2.groups.io; Justen, Jordan L <jordan.l.justen@intel.com>;
> afish@apple.com; Ni, Ray <ray.ni@intel.com>
> > Cc: lersek@redhat.com; songdongkuang@huawei.com;
> xiewenyi2@huawei.com
> > Subject: [PATCH EDK2 v1 1/1] EmulatorPkg:Change DEC_VERSION to
> DEC_SPECIFICATION
> >
> > edk2 DEC specification document only knows about DEC_SPECIFICATION,
> > so using DEC_VERSION in [Defines] section in EmulatorPkg.dec is not
> > correct.
> >
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> > ---
> > EmulatorPkg/EmulatorPkg.dec | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
> > index 90a8d2a8681a..064f963c72c6 100644
> > --- a/EmulatorPkg/EmulatorPkg.dec
> > +++ b/EmulatorPkg/EmulatorPkg.dec
> > @@ -11,7 +11,7 @@
> > ##
> >
> > [Defines]
> > - DEC_VERSION = 0x00010005
> > + DEC_SPECIFICATION = 0x00010005
> > PACKAGE_NAME = EmulatorPkg
> > PACKAGE_GUID =
> 36E48BD7-7D92-5A47-A2CD-513F072E3300
> > PACKAGE_VERSION = 0.1
> > --
> > 2.20.1.windows.1
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-14 2:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-11 1:49 [PATCH EDK2 v1 0/1] EmulatorPkg:Change DEC_VERSION to DEC_SPECIFICATION wenyi,xie
2020-09-11 1:49 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2020-09-11 2:18 ` Ni, Ray
2020-09-14 2:57 ` 回复: [edk2-devel] " gaoliming
2020-09-11 7:03 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox