public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chao Li" <lichao@loongson.cn>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"michael.d.kinney@intel.com" <michael.d.kinney@intel.com>
Cc: "\"devel@edk2.groups.io\"" <devel@edk2.groups.io>,
	"\"Gao, Liming\"" <gaoliming@byosoft.com.cn>,
	"\"Liu, Zhiguang\"" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.
Date: Tue, 13 Sep 2022 12:45:12 +0800	[thread overview]
Message-ID: <15FA39BB-8658-49E4-9D3E-5028D4AA64C9@getmailspring.com> (raw)
In-Reply-To: <CO1PR11MB4929E477E7D99A4CC285A8D6D2449@CO1PR11MB4929.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 7983 bytes --]

Ok, I will change it in the V2.

--------
Thanks,
Chao
--------

On 9月 13 2022, at 12:32 凌晨, "Michael D Kinney" <michael.d.kinney@intel.com> wrote:
> Thanks! It looks like the link in the comment in the C file is out of date.
>
> Can you update patch to change
> /// http://www.ietf.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml
> to
> /// https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xhtml
> Thanks,
> Mike
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chao Li
> > Sent: Saturday, September 10, 2022 8:58 PM
> > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> > Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Subject: Re: [edk2-devel] [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.
> >
> >
> > Hi Mike,
> > Seeing the following URL section "Processor Architecture Types" for the LOONGARCH values:
> > https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xhtml#ieee-80221-service-type
> >
> > Thanks,
> > Chao
> >
> > > -----原始邮件-----
> > > 发件人: "Michael D Kinney" <michael.d.kinney@intel.com>
> > > 发送时间:2022-09-10 01:09:47 (星期六)
> > > 收件人: "Chao Li" <lichao@loongson.cn>, "devel@edk2.groups.io" <devel@edk2.groups.io>, "Kinney, Michael D"
> > <michael.d.kinney@intel.com>
> > > 抄送: "Gao, Liming" <gaoliming@byosoft.com.cn>, "Liu, Zhiguang" <zhiguang.liu@intel.com>
> > > 主题: Re: [edk2-devel] [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.
> > >
> > > Can you provide the link to the RFC that defines the LOONGARCH values?
> > >
> > > Mike
> > >
> > > > -----Original Message-----
> > > > From: Chao Li <lichao@loongson.cn>
> > > > Sent: Wednesday, September 7, 2022 9:48 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>
> > > > Subject: [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.
> > > >
> > > > HTTP/PXE boot LOONGARCH64 related definitions for EDK2 CI.
> > > >
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > >
> > > > Signed-off-by: Chao Li <lichao@loongson.cn>
> > > > ---
> > > > MdePkg/Include/IndustryStandard/Dhcp.h | 41 +++++++++++++++-----------
> > > > 1 file changed, 23 insertions(+), 18 deletions(-)
> > > >
> > > > diff --git a/MdePkg/Include/IndustryStandard/Dhcp.h b/MdePkg/Include/IndustryStandard/Dhcp.h
> > > > index f209f1b2eb..845d6e4fed 100644
> > > > --- a/MdePkg/Include/IndustryStandard/Dhcp.h
> > > > +++ b/MdePkg/Include/IndustryStandard/Dhcp.h
> > > > @@ -4,6 +4,7 @@
> > > >
> > > >
> > > > Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> > > >
> > > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> > > >
> > > > + Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
> > > >
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > > >
> > > > **/
> > > >
> > > >
> > > >
> > > > @@ -259,24 +260,28 @@ typedef enum {
> > > > /// These identifiers are defined by IETF:
> > > >
> > > > /// http://www.ietf.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml
> > > >
> > > > ///
> > > >
> > > > -#define PXE_CLIENT_ARCH_X86_BIOS 0x0000 /// x86 BIOS for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_IPF 0x0002 /// Itanium for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_IA32 0x0006 /// x86 uefi for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_X64 0x0007 /// x64 uefi for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_EBC 0x0009 /// EBC for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_ARM 0x000A /// Arm uefi 32 for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_AARCH64 0x000B /// Arm uefi 64 for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_RISCV32 0x0019 /// RISC-V uefi 32 for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_RISCV64 0x001B /// RISC-V uefi 64 for PXE
> > > >
> > > > -#define PXE_CLIENT_ARCH_RISCV128 0x001D /// RISC-V uefi 128 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_X86_BIOS 0x0000 /// x86 BIOS for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_IPF 0x0002 /// Itanium for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_IA32 0x0006 /// x86 uefi for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_X64 0x0007 /// x64 uefi for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_EBC 0x0009 /// EBC for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_ARM 0x000A /// Arm uefi 32 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_AARCH64 0x000B /// Arm uefi 64 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_RISCV32 0x0019 /// RISC-V uefi 32 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_RISCV64 0x001B /// RISC-V uefi 64 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_RISCV128 0x001D /// RISC-V uefi 128 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_LOONGARCH32 0x0025 /// LoongArch uefi 32 for PXE
> > > >
> > > > +#define PXE_CLIENT_ARCH_LOONGARCH64 0x0027 /// LoongArch uefi 64 for PXE
> > > >
> > > >
> > > >
> > > > -#define HTTP_CLIENT_ARCH_IA32 0x000F /// x86 uefi boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_X64 0x0010 /// x64 uefi boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_EBC 0x0011 /// EBC boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_ARM 0x0012 /// Arm uefi 32 boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_AARCH64 0x0013 /// Arm uefi 64 boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_RISCV32 0x001A /// RISC-V uefi 32 boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_RISCV64 0x001C /// RISC-V uefi 64 boot from http
> > > >
> > > > -#define HTTP_CLIENT_ARCH_RISCV128 0x001E /// RISC-V uefi 128 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_IA32 0x000F /// x86 uefi boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_X64 0x0010 /// x64 uefi boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_EBC 0x0011 /// EBC boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_ARM 0x0012 /// Arm uefi 32 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_AARCH64 0x0013 /// Arm uefi 64 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_RISCV32 0x001A /// RISC-V uefi 32 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_RISCV64 0x001C /// RISC-V uefi 64 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_RISCV128 0x001E /// RISC-V uefi 128 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_LOONGARCH32 0x0026 /// LoongArch uefi 32 boot from http
> > > >
> > > > +#define HTTP_CLIENT_ARCH_LOONGARCH64 0x0028 /// LoongArch uefi 64 boot from http
> > > >
> > > >
> > > >
> > > > #endif
> > > >
> > > > --
> > > > 2.27.0
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> > 本邮件及其附件含有龙芯中科的商业秘密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分
> > 地泄露、复制或散发)本邮件及其附件中的信息。如果您错收本邮件,请您立即电话或邮件通知发件人并删除本邮件。
> > This email and its attachments contain confidential information from Loongson Technology , which is intended only for the
> > person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not
> > limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is
> > prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
> >
> >
> >
>
>
>
> 
>


[-- Attachment #2: Type: text/html, Size: 11270 bytes --]

  reply	other threads:[~2022-09-13  4:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  4:47 [PATCH v1 00/34] Add a new architecture called LoongArch in EDK II Chao Li
2022-09-08  4:47 ` [PATCH v1 01/34] MdePkg: Added file of DebugSupport.h to MdePkg.ci.yaml Chao Li
2022-09-08  4:47 ` [PATCH v1 02/34] MdePkg: Added LoongArch jump buffer register definition " Chao Li
2022-09-08  4:47 ` [PATCH v1 03/34] FatPkg: Add LOONGARCH64 architecture for EDK2 CI Chao Li
2022-09-09 16:52   ` [edk2-devel] " Michael D Kinney
2022-09-08  4:47 ` [PATCH v1 04/34] FmpDevicePkg: " Chao Li
2022-09-09 17:10   ` [edk2-devel] " Michael D Kinney
2022-09-08  4:47 ` [PATCH v1 05/34] NetworkPkg: " Chao Li
2022-09-09 17:11   ` [edk2-devel] " Michael D Kinney
2022-09-23  8:06   ` Wu, Jiaxin
2022-09-08  4:47 ` [PATCH v1 06/34] NetworkPkg/HttpBootDxe: " Chao Li
2022-09-08  4:47 ` [PATCH v1 07/34] CryptoPkg: " Chao Li
2022-09-08  4:47 ` [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions " Chao Li
2022-09-09 17:09   ` Michael D Kinney
2022-09-11  3:58     ` [edk2-devel] " Chao Li
2022-09-12 16:32       ` Michael D Kinney
2022-09-13  4:45         ` Chao Li [this message]
2022-09-08  4:47 ` [PATCH v1 09/34] SecurityPkg: Add LOONGARCH64 architecture for " Chao Li
2022-09-09 17:11   ` [edk2-devel] " Michael D Kinney
2022-09-08  4:47 ` [PATCH v1 10/34] ShellPkg: " Chao Li
2022-09-09 17:26   ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15FA39BB-8658-49E4-9D3E-5028D4AA64C9@getmailspring.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox