public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Taylor Beebe" <t@taylorbeebe.com>
To: "Marvin Häuser" <mhaeuser@posteo.de>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol
Date: Mon, 6 Feb 2023 17:18:40 -0800	[thread overview]
Message-ID: <15a314d3-2549-5ed3-b920-2a71b1ba518a@taylorbeebe.com> (raw)
In-Reply-To: <17027.1675454285173437530@groups.io>

I can't see the Bugzilla you referenced so I requested security Bugzilla 
access. But, yes, that's the bug to which I was referring :)

Once Ard's change to add Memory Attribute Protocol support to ARM 
platforms is in, the change you linked may be palatable for the 
upstream. However, ARM platforms could run into the infinite loop I 
outlined if that change is pushed upstream because of the lack of 
per-allocated page tables and a software semaphore to prevent looping.

I implemented pre-allocated pages for ARM a while back in a private repo 
but never committed it to Mu. Maybe that would also be worth committing 
and pushing upstream.

-Taylor

On 2/3/2023 11:58 AM, Marvin Häuser wrote:
> Hi Taylor,
> 
> Do you by any chance mean this bug? 
> https://github.com/microsoft/mu_basecore/blob/release/202208/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c#L1544 <https://github.com/microsoft/mu_basecore/blob/release/202208/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c#L1544>
> 
> I reported this a while ago at 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3316 
> <https://bugzilla.tianocore.org/show_bug.cgi?id=3316>
> 
> The Mu fix is by no means a workaround and actually fixes this issue in 
> a sane way. It should have been fixed upstream ages ago.
> 
> Best regards,
> Marvin
> 


  reply	other threads:[~2023-02-07  1:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31 22:35 [PATCH 0/4] ArmPkg: implement EFI memory attributes protocol Ard Biesheuvel
2023-01-31 22:35 ` [PATCH 1/4] MdePkg: Add Memory Attribute Protocol definition Ard Biesheuvel
2023-02-02  3:19   ` 回复: " gaoliming
2023-02-02  9:25     ` [edk2-devel] " Ard Biesheuvel
2023-01-31 22:35 ` [PATCH 2/4] MdePkg: Bump implemented UEFI version to v2.10 Ard Biesheuvel
2023-02-01  0:10   ` Michael D Kinney
2023-02-01  7:54     ` Ard Biesheuvel
2023-01-31 22:35 ` [PATCH 3/4] ArmPkg/CpuDxe: Unify PageAttributeToGcdAttribute helper Ard Biesheuvel
2023-01-31 22:35 ` [PATCH 4/4] ArmPkg/CpuDxe: Implement EFI memory attributes protocol Ard Biesheuvel
2023-02-01 18:41   ` [edk2-devel] " Taylor Beebe
2023-02-02  9:43     ` Ard Biesheuvel
2023-02-03 19:08       ` Taylor Beebe
2023-02-03 19:58         ` Marvin Häuser
2023-02-07  1:18           ` Taylor Beebe [this message]
2023-02-07  8:29             ` Ard Biesheuvel
2023-02-07  8:56               ` Marvin Häuser
2023-02-07  9:16                 ` Ard Biesheuvel
2023-02-07 10:00                   ` Marvin Häuser
2023-02-07 10:01                   ` Ard Biesheuvel
2023-02-07 10:13                     ` Marvin Häuser
2023-02-07 17:56                       ` Ard Biesheuvel
2023-02-07 18:19                         ` Taylor Beebe
2023-02-07 18:50                           ` Marvin Häuser
2023-02-07 18:19                         ` Marvin Häuser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15a314d3-2549-5ed3-b920-2a71b1ba518a@taylorbeebe.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox