From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mx.groups.io with SMTP id smtpd.web10.2195.1657759147713456835 for ; Wed, 13 Jul 2022 17:39:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eLAZwQih; spf=pass (domain: gmail.com, ip: 209.85.216.43, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f43.google.com with SMTP id z12-20020a17090a7b8c00b001ef84000b8bso6474220pjc.1 for ; Wed, 13 Jul 2022 17:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YyOJM0R2R8Zk6Tth3O3N8dICgbykDTBgGk+GI38QqIw=; b=eLAZwQihR8oQwNiVKRRjHmblSAWmAlSYf8dfCVa/Grx21ZWoM68dCQ0HT0Ej2hnof4 zDOxmsv/NcFEQuiom8g2aAuo4hP+tj+WGnvnFoMqVi/wGhrhqCnxK0AP9uCZk78lj5H4 uK/n8kiNavQZ6hAmpmJYeyJHuJv8604Nm1oxvXYkEknTVZjRpCFA315hRM2rqAjKo5XY Ym+Dq+mHmL4pkIttgKjO6A5+cppHZdYi4C2ueJ/XDeUnlS/jm9NZKr7mxy/J8A0/uLk7 FmqvTmezdKdQJWBDBDgVkNnqQ8+w78X//+EsLqtHoaNQQeilcDvYvOz7U039yLQuBs0d VITA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YyOJM0R2R8Zk6Tth3O3N8dICgbykDTBgGk+GI38QqIw=; b=AHQRmGI3yNpAWTEToSyoEfr8CBe/dT/vMCPjjl7j0j1v1FagyL3GzRMy+dAnji4PcM I+oL3/jo0YTJlkCkPtnRNmGjvgLn3ut/tGWzSIoyMDMbQd0S01yzKc6rtUi9QKYAEQE4 9u4gnA1Yi4vY4v9YDVU6G6an14SLDMemfa7ZvPX51Tv8XAMkehbLD+H5mjzB+c0G/cLd sPtvabzEXOc0CvJlXZaNS0WOrspsl+3X019Pbu7LcXYvD8+QxrguiaaL8Ds5pSDG++Tm kKNoCXZ7uCghyfVU6vxCqVcoZtTNrlN6Pr2hJFSEmF7FX2SFW6z74gww34mejTF5zFEq 7w6g== X-Gm-Message-State: AJIora8ii4sXDiNnqDkDRYaOFtJKyU2v7ybbFPy98ug37JP8++gghf59 BH/dnVwRWA1VcygfQIGZp7ZSJ5EKJ84= X-Google-Smtp-Source: AGRyM1s2/5oCqtBMIjWe4CkawjCGRrgM+QdQ6BwpOcsFElEtjeCtiKHS9kudjD66bSwPEEe29VnSfg== X-Received: by 2002:a17:90b:507:b0:1ef:9344:e1b9 with SMTP id r7-20020a17090b050700b001ef9344e1b9mr13281956pjz.160.1657759147016; Wed, 13 Jul 2022 17:39:07 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:b964:c1e8:26aa:4c24? ([2001:4898:80e8:9:397e:c1e8:26aa:4c24]) by smtp.gmail.com with ESMTPSA id p12-20020a63e64c000000b004160a23f971sm5972496pgj.9.2022.07.13.17.39.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 17:39:06 -0700 (PDT) Message-ID: <15c96a4b-1920-96f4-4410-29049519de52@gmail.com> Date: Wed, 13 Jul 2022 17:39:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Yao, Jiewen" , "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" , Andrew Fish , Leif Lindholm , "Gao, Liming" , "Liu, Zhiguang" References: <16FF20526D0669CC.28163@groups.io> <75d7d4ba-e930-1f97-7dc9-a2b85d8b66ed@gmail.com> From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Mike, The intention was to encourage the usage of new definition in .H file once the definition is updated. The PCD is left as is only to serve as backwards compatibility purpose. Do you think only updating the DEC and .H file is more ideal? I could drop the other changes if so desired. Thanks, Kun On 7/13/2022 5:30 PM, Michael D Kinney wrote: > Hi Kun, > > Why was the PCD usage not preserved and only the value updated in the DEC file and .H file? > > Mike > >> -----Original Message----- >> From: Kun Qin >> Sent: Wednesday, July 13, 2022 5:21 PM >> To: devel@edk2.groups.io >> Cc: Yao, Jiewen ; Wang, Jian J ; Zhang, Qi1 ; Kumar, Rahul1 >> ; Andrew Fish ; Leif Lindholm ; Kinney, Michael D >> ; Gao, Liming ; Liu, Zhiguang >> Subject: Re: [edk2-devel] [edk2-staging][PATCH v1 0/7] Add TPM subclass definition >> >> Hi SecurityPkg maintainers & EDK2 stewards, >> >> I sent out this patch series intending to update/fix the PI spec through >> code first process. >> >> Could you please shed some light on it and let me know if any feedback? >> >> Thanks in advance! >> >> Regards, >> Kun >> >> On 7/5/2022 8:38 PM, Kun Qin via groups.io wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3966 >>> >>> From PI Specification v1.7 Errata A, EFI_PERIPHERAL_DOCKING is defined as >>> 0xD0000 (as well as included in PiStatusCode.h). >>> >>> However, subclass employed as PCD for TPM peripheral in SecurityPkg is >>> also defined as 0xD0000. The TPM subclass code was used in TcgPei.c when >>> reporting error codes. >>> >>> The collision of subclass definition could cause the parsing of reported >>> errors being ambiguous. >>> >>> This patch series add EFI_PERIPHERAL_TPM as a spec-defined value and >>> removed potential usages in the SecurityPkg. >>> >>> Patch v1 branch: https://github.com/kuqin12/edk2/tree/BZ3966-add_tpm_subclass >>> >>> Cc: Jiewen Yao >>> Cc: Jian J Wang >>> Cc: Qi Zhang >>> Cc: Rahul Kumar >>> Cc: Andrew Fish >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> >>> Kun Qin (7): >>> EDK2 Code First: PI Specification: New peripheral subclass for TPM >>> MdePkg: MmCommunication: Add TPM subclass definition to MdePkg >>> SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice >>> SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice >>> SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice >>> SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice >>> SecurityPkg: SubClassTpm: Updated default value >>> >>> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 +- >>> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 +- >>> SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 2 +- >>> SecurityPkg/Tcg/TcgPei/TcgPei.c | 4 +- >>> CodeFirst/BZ3966-SpecChange.md | 60 ++++++++++++++++++++ >>> MdePkg/Include/Pi/PiStatusCode.h | 1 + >>> SecurityPkg/SecurityPkg.dec | 6 +- >>> SecurityPkg/SecurityPkg.uni | 2 +- >>> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 - >>> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - >>> SecurityPkg/Tcg/TcgDxe/TcgDxe.inf | 1 - >>> SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 - >>> 12 files changed, 72 insertions(+), 15 deletions(-) >>> create mode 100644 CodeFirst/BZ3966-SpecChange.md >>> > > > >